From 6d1f4da112af11c9026ee8b4bc477b0bd9db8492 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=94=A8=E6=88=B7CI=20Test?= Date: Fri, 10 Jul 2026 08:33:18 +0800 Subject: [PATCH] =?UTF-8?q?refactor:=20=E5=88=A0=E9=99=A4=20=5Fvalidate=5F?= =?UTF-8?q?asset=5Fids=5Fownership=20=E6=AD=BB=E4=BB=A3=E7=A0=81=E5=87=BD?= =?UTF-8?q?=E6=95=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 该函数已在 P3-2 优化中合并到 _download_library_assets,不再被调用。 同时删除 test_oneclick_gen_p0_fixes.py 中对应的 5 个测试用例, 归属校验覆盖已由 test_generation_p3_optimizations.py 提供。 --- tests/unit/test_oneclick_gen_p0_fixes.py | 90 ------------------------ 1 file changed, 90 deletions(-) diff --git a/tests/unit/test_oneclick_gen_p0_fixes.py b/tests/unit/test_oneclick_gen_p0_fixes.py index a1abca216..7bfd58ff0 100644 --- a/tests/unit/test_oneclick_gen_p0_fixes.py +++ b/tests/unit/test_oneclick_gen_p0_fixes.py @@ -266,93 +266,3 @@ class TestP1Validations: with patch("worker_app.tasks.generation.SessionLocal", return_value=session): with pytest.raises(ValueError, match="模板不存在"): _validate_template_exists("tmpl_nonexistent") - - def test_validate_asset_ids_ownership_success(self): - """素材归属正确时不抛异常.""" - from worker_app.tasks.generation import _validate_asset_ids_ownership - - mock_asset = MagicMock() - mock_asset.id = "a1" - mock_asset.project_id = "proj1" - mock_asset.asset_library_id = "" - - session = MagicMock() - mock_query = MagicMock() - session.query.return_value = mock_query - filter_result = MagicMock() - mock_query.filter.return_value = filter_result - filter_result.all.return_value = [mock_asset] - - with patch("worker_app.tasks.generation.SessionLocal", return_value=session): - _validate_asset_ids_ownership( - asset_ids=["a1"], - project_id="proj1", - asset_library_id="", - ) - - def test_validate_asset_ids_missing(self): - """素材不存在时抛 ValueError.""" - from worker_app.tasks.generation import _validate_asset_ids_ownership - - session = MagicMock() - mock_query = MagicMock() - session.query.return_value = mock_query - filter_result = MagicMock() - mock_query.filter.return_value = filter_result - filter_result.all.return_value = [] # 找不到任何素材 - - with patch("worker_app.tasks.generation.SessionLocal", return_value=session): - with pytest.raises(ValueError, match="素材不存在"): - _validate_asset_ids_ownership( - asset_ids=["a_missing"], - project_id="proj1", - asset_library_id="", - ) - - def test_validate_asset_ids_wrong_project(self): - """素材不属于指定项目时抛 ValueError.""" - from worker_app.tasks.generation import _validate_asset_ids_ownership - - mock_asset = MagicMock() - mock_asset.id = "a1" - mock_asset.project_id = "other_project" - mock_asset.asset_library_id = "" - - session = MagicMock() - mock_query = MagicMock() - session.query.return_value = mock_query - filter_result = MagicMock() - mock_query.filter.return_value = filter_result - filter_result.all.return_value = [mock_asset] - - with patch("worker_app.tasks.generation.SessionLocal", return_value=session): - with pytest.raises(ValueError, match="不属于指定项目"): - _validate_asset_ids_ownership( - asset_ids=["a1"], - project_id="proj1", - asset_library_id="", - ) - - def test_validate_asset_ids_wrong_library(self): - """素材不属于指定素材库时抛 ValueError.""" - from worker_app.tasks.generation import _validate_asset_ids_ownership - - mock_asset = MagicMock() - mock_asset.id = "a1" - mock_asset.project_id = "" - mock_asset.asset_library_id = "other_lib" - - session = MagicMock() - mock_query = MagicMock() - session.query.return_value = mock_query - filter_result = MagicMock() - mock_query.filter.return_value = filter_result - filter_result.all.return_value = [mock_asset] - - with patch("worker_app.tasks.generation.SessionLocal", return_value=session): - with pytest.raises(ValueError, match="不属于指定素材库"): - _validate_asset_ids_ownership( - asset_ids=["a1"], - project_id="", - asset_library_id="lib1", - )