From be102d00889fd20292b692bfaa41d0a98b34540b Mon Sep 17 00:00:00 2001 From: CI Test Date: Sun, 28 Jun 2026 17:14:17 +0800 Subject: [PATCH] fix: fix 204 response in titles.py and voices.py delete endpoints --- apps/api/app/api/routes/titles.py | 7 ++++--- apps/api/app/api/routes/voices.py | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/apps/api/app/api/routes/titles.py b/apps/api/app/api/routes/titles.py index 5c4bdd3ca..c532e8f46 100644 --- a/apps/api/app/api/routes/titles.py +++ b/apps/api/app/api/routes/titles.py @@ -3,7 +3,7 @@ from __future__ import annotations from typing import Optional -from fastapi import APIRouter, Depends, HTTPException, Query, status +from fastapi import APIRouter, Depends, HTTPException, Query, Response, status from app.auth import AuthenticatedUser, get_current_user from app.dependencies import get_db_session, get_user_repository @@ -142,14 +142,15 @@ def update_title( return _to_response(item) -@router.delete("/{title_id}", status_code=status.HTTP_204_NO_CONTENT) +@router.delete("/{title_id}", status_code=status.HTTP_204_NO_CONTENT, response_class=Response) def delete_title( title_id: str, authenticated_user: AuthenticatedUser = Depends(get_current_user), title_repository: SQLAlchemyTitleLibraryRepository = Depends(_get_title_repository), -) -> None: +) -> Response: user_id = authenticated_user.user.id use_case = DeleteTitleLibraryUseCase(title_repository) deleted = use_case.execute(title_id, user_id) if not deleted: raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Title not found") + return Response(status_code=204) diff --git a/apps/api/app/api/routes/voices.py b/apps/api/app/api/routes/voices.py index fba24a7b5..7851ea02c 100644 --- a/apps/api/app/api/routes/voices.py +++ b/apps/api/app/api/routes/voices.py @@ -3,7 +3,7 @@ from __future__ import annotations from typing import Optional -from fastapi import APIRouter, Depends, HTTPException, Query, status +from fastapi import APIRouter, Depends, HTTPException, Query, Response, status from app.auth import AuthenticatedUser, get_current_user from app.dependencies import get_db_session, get_user_repository @@ -157,14 +157,15 @@ def update_voice( return _to_response(item) -@router.delete("/{voice_id}", status_code=status.HTTP_204_NO_CONTENT) +@router.delete("/{voice_id}", status_code=status.HTTP_204_NO_CONTENT, response_class=Response) def delete_voice( voice_id: str, authenticated_user: AuthenticatedUser = Depends(get_current_user), voice_repository: SQLAlchemyVoiceLibraryRepository = Depends(_get_voice_repository), -) -> None: +) -> Response: user_id = authenticated_user.user.id use_case = DeleteVoiceLibraryUseCase(voice_repository) deleted = use_case.execute(voice_id, user_id) if not deleted: raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Voice not found") + return Response(status_code=204)