xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 1 Packages Projects Releases 7 Wiki Activity

cleanup: 删除Step5未使用的templateName/materialCount/duration props传递链 #1396

Closed
xiaoxia wants to merge 4 commits from cleanup/remove-unused-preview-props into develop
pull from: cleanup/remove-unused-preview-props
merge into: xiaoxia:develop
Conversation 0 Commits 4 Files Changed 3
-14
xiaoxia commented 2026-08-16 20:58:31 +08:00
Owner
Copy Link
Copy Source

清理内容

删除从 GeneratePage → GenerateStepContent → Step5GeneratePreview 的未使用 props 传递链路。

修改的文件

Step5GeneratePreview.tsx

  • 接口声明中删除 templateName、materialCount、duration
  • 解构中删除 _templateName、_materialCount

GenerateStepContent.tsx

  • 接口中删除 previewTemplateName、previewMaterialCount
  • 解构中删除对应变量
  • 传递给 Step5 的 templateName、materialCount、duration 三个 prop

GeneratePage.tsx

  • 传递给 GenerateStepContent 的 previewTemplateName、previewMaterialCount

保留

  • useStep5Preview hook 中 templateName/materialCount 的计算逻辑不动（useStep7Generate 的 SummaryCard 仍在使用）

验证

  • tsc --noEmit 零错误
  • prettier 格式通过
## 清理内容 删除从 GeneratePage → GenerateStepContent → Step5GeneratePreview 的未使用 props 传递链路。 ### 修改的文件 **Step5GeneratePreview.tsx** - 接口声明中删除 `templateName`、`materialCount`、`duration` - 解构中删除 `_templateName`、`_materialCount` **GenerateStepContent.tsx** - 接口中删除 `previewTemplateName`、`previewMaterialCount` - 解构中删除对应变量 - 传递给 Step5 的 `templateName`、`materialCount`、`duration` 三个 prop **GeneratePage.tsx** - 传递给 GenerateStepContent 的 `previewTemplateName`、`previewMaterialCount` ### 保留 - `useStep5Preview` hook 中 `templateName`/`materialCount` 的计算逻辑不动（`useStep7Generate` 的 SummaryCard 仍在使用） ## 验证 - [x] tsc --noEmit 零错误 - [x] prettier 格式通过
xiaoxia added the frontend label 2026-08-16 20:58:31 +08:00
xiaoxia added 1 commit 2026-08-16 20:58:31 +08:00
cleanup: 删除Step5未使用的templateName/materialCount/duration props传递链
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Failing after 1s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 1s
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 1s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 1s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1m0s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m33s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m53s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m40s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 4m41s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 8m10s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 31s
Details
ce0128a2dd 
- Step5GeneratePreview: 移除接口声明 templateName/materialCount/duration + 解构 _templateName/_materialCount
- GenerateStepContent: 移除接口声明 previewTemplateName/previewMaterialCount + 解构 + 传递给Step5的3个prop
- GeneratePage: 移除传递给GenerateStepContent的previewTemplateName/previewMaterialCount
- 保留 useStep5Preview hook 中的计算逻辑（useStep7Generate SummaryCard 仍在使用）
xiaoxia added 1 commit 2026-08-18 10:36:33 +08:00
chore: retrigger CI after Docker infrastructure fix
CI/CD Pipeline / Check if frontend-only change (pull_request) Failing after 1s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 1s
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 1s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1s
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 1s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 25s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 9s
Details
f8483979e4
xiaoxia added 1 commit 2026-08-18 10:46:13 +08:00
chore: retrigger CI - attempt 2
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 1s
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 1s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 1s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 22s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 1s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m12s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 52s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m16s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m33s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m44s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 6s
Details
b92454d353
xiaoxia added 1 commit 2026-08-18 10:55:27 +08:00
chore: retrigger CI - final attempt
CI/CD Pipeline / Check if frontend-only change (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 0s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 0s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Failing after 1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 7s
Details
f8d12ae3d2
xiaoxia closed this pull request 2026-08-18 11:05:51 +08:00
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 0s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 0s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Failing after 1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 7s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1396
Delete Branch "cleanup/remove-unused-preview-props"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?