CI Bot
9c6c477f55
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Failing after 2m22s
CI/CD Pipeline / Unit Tests (pull_request) Failing after 2m24s
CI/CD Pipeline / Integration Tests (pull_request) Failing after 37s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 4m3s
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
P0 关键修复: - P0-1: 注册接口添加 RateLimitMiddleware 限流保护 - P0-3: /metrics 端点添加 JWT 认证（移除匿名访问） - P0-4: 修复 Celery 任务名冲突（generation_task vs generate_video） - P1-5: JWT logout token 黑名单机制 P1 修复: - P1-1: forgot_password 硬编码 localhost → 使用 settings.APP_BASE_URL - P1-2: generation.py 直接创建 DB 连接 → 使用依赖注入 - P1-6: Image.open() 未关闭 → 统一使用 with 语句 - P1-7: 订阅续费事务修复 P2 代码质量: - P2-1: 修复 EditingMode 枚举重复定义 → 统一引用 shared 包 - P2-2: 修复 SMTP_FRON_NAME → SMTP_FROM_NAME 拼写 - P2-3: UserModel subscription_quota 类型统一为 float - P2-4: .env.production DATABASE_MAX_OVERFLOW 30 → 10 - 清理 15 处 except:pass（保留 2 处有注释说明的） - 禁用 SVG 上传（XSS 风险） - 删除 decode_token_unsafe() 不安全函数 - 简化 /ready 端点 - 删除 8 处死代码、10 个空文件/模块 - 合并 3 对 100% 重复函数 - 对齐 6 个废弃环境变量 v2 修复（代码审查后）: - 修复密码重置路由路径: /password/forgot → /forgot-password, /password/reset → /reset-password（与前端 API 对齐） - 合并 _check_project_access: asset_libraries.py 和 edit_plans.py 中的重复函数统一到 _helpers.py（含空字符串守卫 + 中文错误信息） - 顺手修复: HTTPException 统一从 fastapi 导入（替换 starlette 导入） - OSS_ENDPOINT 拼写修复拆分为单独 PR，本 PR 不包含
49 lines
1.8 KiB
Python
49 lines
1.8 KiB
Python
"""路由层共享辅助函数 — 消除跨文件重复定义。"""
|
|
|
|
from typing import Any
|
|
|
|
from fastapi import HTTPException, status
|
|
|
|
from packages.application import GetProjectUseCase
|
|
from packages.ports.user_repository import UserRepository
|
|
|
|
|
|
def check_project_access(project_id: str, user_id: str, project_repository) -> None:
|
|
"""检查用户是否有项目访问权限。
|
|
|
|
合并自 asset_libraries.py / edit_plans.py 的同名函数。
|
|
- 空 project_id 直接放行（兼容 edit_plans 中 project_id 可选的场景）
|
|
- 错误信息使用中文，与项目其他路由保持一致
|
|
"""
|
|
if not project_id or not project_id.strip():
|
|
return
|
|
project = project_repository.find_by_id(project_id)
|
|
if project is None:
|
|
raise HTTPException(status_code=404, detail="项目不存在")
|
|
if not project.can_access(user_id):
|
|
raise HTTPException(status_code=403, detail="无权访问该项目")
|
|
|
|
|
|
def get_user_plan(user_id: str, user_repository: UserRepository) -> str:
|
|
"""获取用户的订阅计划名称。"""
|
|
user = user_repository.find_by_id(user_id)
|
|
if user is None:
|
|
return "free"
|
|
return getattr(user, "subscription_plan", "free") or "free"
|
|
|
|
|
|
def require_project_and_library(
|
|
project_id: str,
|
|
library_id: str,
|
|
project_repository: Any,
|
|
asset_library_repository: Any,
|
|
) -> None:
|
|
"""Verify project and asset library exist."""
|
|
project = GetProjectUseCase(project_repository).execute(project_id)
|
|
if project is None:
|
|
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Project not found")
|
|
|
|
libraries = asset_library_repository.find_by_project(project_id)
|
|
if not any(item.id == library_id for item in libraries):
|
|
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Asset library not found")
|