f42fe18269
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m38s
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m55s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m7s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m24s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m28s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 3m54s
CI/CD Pipeline / Validate - Style (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Security (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been cancelled
- 新增 test_gpu_lipsync_routes.py:register 透传 cancel_task、cancel 接受 processing - gpu_lipsync_service 测试:心跳检测取消、cancelled 不回退 pending、wait_for_result 终态 - lipsync_service 测试(真实 SQLite):cancel_job 同步取消 GPU 任务、非 gpu 前缀不动 GPU 表 - celery 测试:cancelled GPU 任务不回退 MediaKit - worker 测试:TaskHeartbeat 检测 cancel 调 /cancel、取消上报不重试 - 修复 build_engine 给 SQLite 传 pool_size/max_overflow/pool_timeout 导致 TypeError
288 lines
11 KiB
Python
288 lines
11 KiB
Python
"""Celery 任务 lipsync_gpu_process_async 直接单测 (#1978 异步化).
|
||
|
||
覆盖 apps/api/app/tasks/lipsync_gpu.py 的全部主路径:
|
||
- 成功:wait_for_result 返回 done → 签名 URL → completed
|
||
- GPU 超时/失败 → MediaKit 兜底(成功/MediaKitError/其他异常)
|
||
- job 不存在 / 状态异常提前返回
|
||
- 主流程异常 → job 标 failed
|
||
- _sign_media_url 各分支
|
||
"""
|
||
|
||
from __future__ import annotations
|
||
|
||
from unittest.mock import MagicMock, patch
|
||
|
||
import app.tasks.lipsync_gpu as task_mod
|
||
import pytest
|
||
|
||
|
||
def _make_job(status="processing"):
|
||
job = MagicMock()
|
||
job.id = "job-1"
|
||
job.user_id = "u1"
|
||
job.status = status
|
||
job.video_url = "videos/v.mp4"
|
||
job.audio_url = "audios/a.wav"
|
||
job.enable_video_loop = True
|
||
return job
|
||
|
||
|
||
def _make_gpu_task(status="done", result_url="gpu-lipsync/results/t1.mp4", result_duration=11.2):
|
||
t = MagicMock()
|
||
t.status = status
|
||
t.result_url = result_url
|
||
t.result_duration = result_duration
|
||
return t
|
||
|
||
|
||
@pytest.fixture()
|
||
def db_patch():
|
||
"""patch _get_db_session 返回 MagicMock,并在任务结束后断言 close."""
|
||
fake_db = MagicMock()
|
||
with patch.object(task_mod, "_get_db_session", return_value=fake_db):
|
||
yield fake_db
|
||
|
||
|
||
def _patch_gpu_service(final_task):
|
||
fake_svc = MagicMock()
|
||
fake_svc.wait_for_result.return_value = final_task
|
||
return patch(
|
||
"app.services.gpu_lipsync_service.GpuLipsyncService",
|
||
return_value=fake_svc,
|
||
)
|
||
|
||
|
||
def _run_task():
|
||
# @shared_task bind=True:直接调用任务对象会自动注入 self
|
||
task_mod.lipsync_gpu_process_async("job-1", "u1", "gpu-task-1")
|
||
|
||
|
||
class TestHappyPath:
|
||
def test_gpu_done_marks_completed(self, db_patch):
|
||
job = _make_job()
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
gpu_task = _make_gpu_task()
|
||
storage = MagicMock()
|
||
storage.get_download_url.return_value = "https://signed.example.com/r1.mp4?sig=x"
|
||
with (
|
||
_patch_gpu_service(gpu_task),
|
||
patch.object(task_mod, "get_shared_storage_service", return_value=storage),
|
||
):
|
||
_run_task()
|
||
assert job.status == "completed"
|
||
assert job.output_video_url == "https://signed.example.com/r1.mp4?sig=x"
|
||
assert job.output_duration == 11.2
|
||
assert job.completed_at is not None
|
||
db_patch.commit.assert_called_once()
|
||
db_patch.close.assert_called_once()
|
||
|
||
def test_gpu_done_empty_signed_url_keeps_original(self, db_patch):
|
||
job = _make_job()
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
gpu_task = _make_gpu_task(result_url="gpu/r2.mp4")
|
||
storage = MagicMock()
|
||
storage.get_download_url.return_value = ""
|
||
with (
|
||
_patch_gpu_service(gpu_task),
|
||
patch.object(task_mod, "get_shared_storage_service", return_value=storage),
|
||
):
|
||
_run_task()
|
||
assert job.status == "completed"
|
||
assert job.output_video_url == "gpu/r2.mp4"
|
||
|
||
def test_gpu_done_result_duration_none_defaults_zero(self, db_patch):
|
||
job = _make_job()
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
gpu_task = _make_gpu_task(result_duration=None)
|
||
storage = MagicMock()
|
||
with (
|
||
_patch_gpu_service(gpu_task),
|
||
patch.object(task_mod, "get_shared_storage_service", return_value=storage),
|
||
):
|
||
_run_task()
|
||
assert job.output_duration == 0.0
|
||
|
||
def test_sign_failure_uses_original_url(self, db_patch):
|
||
job = _make_job()
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
gpu_task = _make_gpu_task(result_url="gpu/r3.mp4")
|
||
with (
|
||
_patch_gpu_service(gpu_task),
|
||
patch.object(task_mod, "get_shared_storage_service", side_effect=RuntimeError("oss down")),
|
||
):
|
||
_run_task()
|
||
assert job.status == "completed"
|
||
assert job.output_video_url == "gpu/r3.mp4"
|
||
|
||
|
||
class TestJobGuards:
|
||
def test_job_not_found_returns(self, db_patch):
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = None
|
||
_run_task()
|
||
db_patch.commit.assert_not_called()
|
||
db_patch.close.assert_called_once()
|
||
|
||
def test_job_wrong_status_skipped(self, db_patch):
|
||
job = _make_job(status="completed")
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
_run_task()
|
||
db_patch.commit.assert_not_called()
|
||
|
||
|
||
class TestGpuFailureFallback:
|
||
def test_gpu_timeout_falls_back_mediakit_success(self, db_patch):
|
||
job = _make_job()
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
with (
|
||
_patch_gpu_service(None),
|
||
patch.object(task_mod, "_fallback_to_mediakit") as fb,
|
||
):
|
||
_run_task()
|
||
fb.assert_called_once_with(db_patch, job)
|
||
|
||
def test_gpu_failed_status_falls_back(self, db_patch):
|
||
job = _make_job()
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
gpu_task = _make_gpu_task(status="failed")
|
||
with (
|
||
_patch_gpu_service(gpu_task),
|
||
patch.object(task_mod, "_fallback_to_mediakit") as fb,
|
||
):
|
||
_run_task()
|
||
fb.assert_called_once_with(db_patch, job)
|
||
|
||
|
||
class TestFallbackToMediaKit:
|
||
def test_mediakit_success_marks_submitted(self, db_patch):
|
||
job = _make_job()
|
||
fake_client = MagicMock()
|
||
fake_client.submit_lipsync.return_value = {"task_id": "mk-99"}
|
||
with (
|
||
patch("app.services.mediakit_client.get_mediakit_client", return_value=fake_client),
|
||
patch.object(task_mod, "_sign_media_url", side_effect=lambda u: u + "?s"),
|
||
):
|
||
task_mod._fallback_to_mediakit(db_patch, job)
|
||
fake_client.submit_lipsync.assert_called_once()
|
||
kwargs = fake_client.submit_lipsync.call_args.kwargs
|
||
assert kwargs["enable_video_loop"] is True
|
||
assert kwargs["client_token"] == "job-1"
|
||
assert job.status == "submitted"
|
||
assert job.mediakit_task_id == "mk-99"
|
||
db_patch.commit.assert_called_once()
|
||
|
||
def test_mediakit_error_marks_failed(self, db_patch):
|
||
from app.services.mediakit_client import MediaKitError
|
||
|
||
job = _make_job()
|
||
fake_client = MagicMock()
|
||
fake_client.submit_lipsync.side_effect = MediaKitError("api reject", code="MkReject")
|
||
with (
|
||
patch("app.services.mediakit_client.get_mediakit_client", return_value=fake_client),
|
||
patch.object(task_mod, "_sign_media_url", side_effect=lambda u: u),
|
||
):
|
||
task_mod._fallback_to_mediakit(db_patch, job)
|
||
assert job.status == "failed"
|
||
assert job.error_code == "MkReject"
|
||
db_patch.commit.assert_called_once()
|
||
|
||
def test_other_exception_marks_failed(self, db_patch):
|
||
job = _make_job()
|
||
with (
|
||
patch("app.services.mediakit_client.get_mediakit_client", side_effect=RuntimeError("boom")),
|
||
patch.object(task_mod, "_sign_media_url", side_effect=lambda u: u),
|
||
):
|
||
task_mod._fallback_to_mediakit(db_patch, job)
|
||
assert job.status == "failed"
|
||
assert job.error_code == "FallbackFailed"
|
||
db_patch.commit.assert_called_once()
|
||
|
||
|
||
class TestTaskException:
|
||
def test_unexpected_exception_marks_job_failed(self, db_patch):
|
||
job = _make_job()
|
||
# query 第一次返回 job,异常路径里再次 query 也返回 job
|
||
db_patch.query.return_value.filter_by.return_value.first.return_value = job
|
||
with patch(
|
||
"app.services.gpu_lipsync_service.GpuLipsyncService",
|
||
side_effect=RuntimeError("svc ctor fail"),
|
||
):
|
||
_run_task()
|
||
assert job.status == "failed"
|
||
assert job.error_code == "GpuAsyncError"
|
||
|
||
def test_exception_handler_failure_swallowed(self, db_patch):
|
||
# 主流程异常,且异常处理中的 query 也抛异常 → 不应再抛
|
||
db_patch.query.side_effect = RuntimeError("db totally broken")
|
||
_run_task()
|
||
db_patch.close.assert_called_once()
|
||
|
||
|
||
class TestSignMediaUrl:
|
||
def test_empty_url_returned_as_is(self):
|
||
assert task_mod._sign_media_url("") == ""
|
||
|
||
def test_non_own_host_returned_as_is(self):
|
||
storage = MagicMock()
|
||
storage.public_url = "https://own-bucket.oss-cn-beijing.aliyuncs.com"
|
||
with patch.object(task_mod, "get_shared_storage_service", return_value=storage):
|
||
url = "https://other.example.com/a.wav"
|
||
assert task_mod._sign_media_url(url) == url
|
||
|
||
def test_own_host_signed(self):
|
||
storage = MagicMock()
|
||
storage.public_url = "https://own-bucket.oss-cn-beijing.aliyuncs.com"
|
||
storage.get_download_url.return_value = "https://own-bucket.oss-cn-beijing.aliyuncs.com/a?sig=1"
|
||
with patch.object(task_mod, "get_shared_storage_service", return_value=storage):
|
||
out = task_mod._sign_media_url("https://own-bucket.oss-cn-beijing.aliyuncs.com/a.wav")
|
||
assert out.endswith("?sig=1")
|
||
storage.get_download_url.assert_called_once()
|
||
|
||
def test_missing_public_url_returns_original(self):
|
||
storage = MagicMock()
|
||
storage.public_url = ""
|
||
with patch.object(task_mod, "get_shared_storage_service", return_value=storage):
|
||
url = "https://own-bucket.oss-cn-beijing.aliyuncs.com/a.wav"
|
||
assert task_mod._sign_media_url(url) == url
|
||
|
||
def test_exception_returns_original(self):
|
||
with patch.object(task_mod, "get_shared_storage_service", side_effect=RuntimeError("x")):
|
||
url = "https://own-bucket.oss-cn-beijing.aliyuncs.com/a.wav"
|
||
assert task_mod._sign_media_url(url) == url
|
||
|
||
|
||
def test_cancelled_gpu_task_does_not_fallback_mediakit(monkeypatch):
|
||
"""GPU 任务被用户取消 → Celery 任务直接标记 cancelled,不回退 MediaKit。"""
|
||
job = MagicMock()
|
||
job.id = "job-1"
|
||
job.status = "processing"
|
||
job.mediakit_task_id = "gpu:gpu-task-1"
|
||
|
||
gpu_task = MagicMock()
|
||
gpu_task.status = "cancelled"
|
||
gpu_task.error_msg = "用户取消"
|
||
|
||
fake_gpu_svc = MagicMock()
|
||
fake_gpu_svc.wait_for_result.return_value = gpu_task
|
||
|
||
fake_db = MagicMock()
|
||
fake_db.query.return_value.filter_by.return_value.first.return_value = job
|
||
# wait_for_result 直接被 mock 到 gpu_svc,这里仅备查
|
||
|
||
monkeypatch.setattr(
|
||
"app.services.gpu_lipsync_service.GpuLipsyncService",
|
||
MagicMock(return_value=fake_gpu_svc),
|
||
)
|
||
session_factory = MagicMock()
|
||
session_factory.return_value = fake_db
|
||
# _get_db_session 优先用 worker_app.db(pytest 环境可导入),两个都 patch
|
||
monkeypatch.setattr("worker_app.db.SessionLocal", session_factory)
|
||
monkeypatch.setattr("app.db.SessionLocal", session_factory)
|
||
monkeypatch.setattr("app.tasks.lipsync_gpu.logger", MagicMock())
|
||
|
||
task_mod.lipsync_gpu_process_async.run("job-1", "u1", "gpu-task-1")
|
||
|
||
assert job.status == "cancelled"
|
||
assert not str(job.mediakit_task_id).startswith("mk-")
|
||
fake_db.commit.assert_called()
|
||
fake_gpu_svc.wait_for_result.assert_called_once()
|