fix(editor): order=0不被覆盖+逐条delete触发ORM事件 (#1468)
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 34s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m11s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 40s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m56s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m51s
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Has been cancelled
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 575h40m42s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 575h40m44s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 575h41m16s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 575h41m17s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 575h41m18s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 575h41m20s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 575h41m20s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 576h14m33s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 576h15m5s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 576h15m9s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 34s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m11s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 40s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m56s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m51s
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Has been cancelled
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 575h40m42s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 575h40m44s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 575h41m16s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 575h41m17s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 575h41m18s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 575h41m20s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 575h41m20s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 576h14m33s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 576h15m5s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 576h15m9s
AI Code Review 第二轮修复: 1. order字段改用 if "order" in clip_item else i,避免order=0被覆盖 2. 批量删除改为逐个 db.delete(),确保触发 ORM before/after_delete 事件 3. B017: pytest.raises(Exception) → ValidationError
This commit is contained in:
@@ -392,12 +392,15 @@ class EditPlanService:
|
||||
|
||||
db = self._clip_repo.session
|
||||
try:
|
||||
# 1. 清空现有 clips(不 commit)
|
||||
deleted_count = db.query(EditPlanClipModel).filter(EditPlanClipModel.plan_id == plan_id).delete()
|
||||
# 1. 清空现有 clips(逐个删除以触发 ORM 事件,不 commit)
|
||||
existing_clips = db.query(EditPlanClipModel).filter(EditPlanClipModel.plan_id == plan_id).all()
|
||||
for existing in existing_clips:
|
||||
db.delete(existing)
|
||||
deleted_count = len(existing_clips)
|
||||
|
||||
# 2. 批量创建新 clips(不 commit)
|
||||
for i, clip_item in enumerate(clips_data):
|
||||
order = clip_item.get("order") or i
|
||||
order = clip_item["order"] if "order" in clip_item else i
|
||||
clip = EditPlanClip.create(
|
||||
plan_id=plan_id,
|
||||
clip_type="main",
|
||||
|
||||
Reference in New Issue
Block a user