test(feature_flag_store): P3-1第十四波 FeatureFlag存储单测 43个 (#718)
CI/CD Pipeline / Build Staging Web Image (push) Successful in 25s
CI/CD Pipeline / Build Staging Worker Image (push) Successful in 1m15s
CI/CD Pipeline / Build Staging API Image (push) Successful in 4m56s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (push) Successful in 41s
CI/CD Pipeline / ACR Image Cleanup (push) Successful in 49s
CI/CD Pipeline / Staging API Integration Tests (push) Successful in 4m37s
CI/CD Pipeline / Staging E2E Tests (push) Failing after 4m45s
CI/CD Pipeline / Validate - Type Check (mypy) (push) Successful in 15s
CI/CD Pipeline / Validate - Migration (alembic) (push) Successful in 7s
CI/CD Pipeline / Frontend Lint (push) Successful in 24s
CI/CD Pipeline / Validate - Code Quality (push) Failing after 58s
CI/CD Pipeline / Frontend Unit Tests (push) Failing after 6s
CI/CD Pipeline / Unit Tests (push) Successful in 2m16s
CI/CD Pipeline / Integration Tests (push) Failing after 2m17s
CI/CD Pipeline / Check if frontend-only change (push) Failing after 1343h21m32s
CI/CD Pipeline / Production Browser E2E (push) Failing after 1343h34m5s
CI/CD Pipeline / Deploy Production (push) Failing after 1343h34m7s
CI/CD Pipeline / Build Production Worker Image (push) Failing after 1343h34m8s
CI/CD Pipeline / Build Production API Image (push) Failing after 1343h34m8s
CI/CD Pipeline / PR Build Worker Image (push) Failing after 1343h34m24s
CI/CD Pipeline / PR Build Web Image (push) Failing after 1343h34m26s
CI/CD Pipeline / PR Build API Image (push) Failing after 1343h34m26s
CI/CD Pipeline / Build Production Web Image (push) Failing after 1344h6m23s

Co-authored-by: xiaoxia <dev@xiaoxiajianji.com>
Co-committed-by: xiaoxia <dev@xiaoxiajianji.com>
This commit was merged in pull request #718.
This commit is contained in:
2026-07-22 15:53:51 +08:00
committed by auto-approve-bot
parent a7a1a6395b
commit 34ea6a866b
3 changed files with 1533 additions and 0 deletions
+425
View File
@@ -0,0 +1,425 @@
"""
FeatureFlagStore 单元测试
覆盖:
- FeatureFlagConfig: to_dict / from_dict 序列化
- FeatureFlagConfig.is_active: 全局开关/白名单/百分比哈希
- InMemoryFeatureFlagStore: CRUD / is_active
"""
import pytest
from packages.adapters.redis.feature_flag_store import (
FEATURE_FLAG_REDIS_PREFIX,
FeatureFlagConfig,
InMemoryFeatureFlagStore,
)
# ============================================================
# 常量
# ============================================================
class TestConstants:
"""常量验证"""
def test_redis_prefix(self):
assert FEATURE_FLAG_REDIS_PREFIX == "feature_flag:"
# ============================================================
# FeatureFlagConfig - 默认值 & 基础
# ============================================================
class TestFeatureFlagConfigDefaults:
"""FeatureFlagConfig 默认值"""
def test_required_name(self):
config = FeatureFlagConfig(name="test_flag")
assert config.name == "test_flag"
def test_default_disabled(self):
config = FeatureFlagConfig(name="test_flag")
assert config.enabled is False
def test_default_percentage_zero(self):
config = FeatureFlagConfig(name="test_flag")
assert config.percentage == 0
def test_default_whitelist_empty(self):
config = FeatureFlagConfig(name="test_flag")
assert config.whitelist == set()
def test_full_config(self):
config = FeatureFlagConfig(
name="full_flag",
enabled=True,
percentage=50,
whitelist={"user1", "user2"},
)
assert config.name == "full_flag"
assert config.enabled is True
assert config.percentage == 50
assert config.whitelist == {"user1", "user2"}
# ============================================================
# FeatureFlagConfig - 序列化
# ============================================================
class TestFeatureFlagConfigSerialization:
"""to_dict / from_dict 序列化"""
def test_to_dict_defaults(self):
config = FeatureFlagConfig(name="test")
d = config.to_dict()
assert d["name"] == "test"
assert d["enabled"] is False
assert d["percentage"] == 0
assert d["whitelist"] == []
def test_to_dict_with_values(self):
config = FeatureFlagConfig(
name="test",
enabled=True,
percentage=75,
whitelist={"a", "b", "c"},
)
d = config.to_dict()
assert d["name"] == "test"
assert d["enabled"] is True
assert d["percentage"] == 75
# whitelist 排序后输出
assert sorted(d["whitelist"]) == ["a", "b", "c"]
def test_from_dict_minimal(self):
d = {"name": "test"}
config = FeatureFlagConfig.from_dict(d)
assert config.name == "test"
assert config.enabled is False
assert config.percentage == 0
assert config.whitelist == set()
def test_from_dict_full(self):
d = {
"name": "full",
"enabled": True,
"percentage": 30,
"whitelist": ["u1", "u2"],
}
config = FeatureFlagConfig.from_dict(d)
assert config.name == "full"
assert config.enabled is True
assert config.percentage == 30
assert config.whitelist == {"u1", "u2"}
def test_round_trip(self):
original = FeatureFlagConfig(
name="round_trip",
enabled=True,
percentage=42,
whitelist={"alice", "bob", "charlie"},
)
d = original.to_dict()
restored = FeatureFlagConfig.from_dict(d)
assert restored.name == original.name
assert restored.enabled == original.enabled
assert restored.percentage == original.percentage
assert restored.whitelist == original.whitelist
def test_from_dict_coerces_types(self):
"""from_dict 应该做类型转换"""
d = {
"name": "coerce",
"enabled": 1, # int → bool
"percentage": "50", # str → int
"whitelist": ("a", "b"), # tuple → set
}
config = FeatureFlagConfig.from_dict(d)
assert config.enabled is True
assert config.percentage == 50
assert config.whitelist == {"a", "b"}
# ============================================================
# FeatureFlagConfig.is_active - 全局开关
# ============================================================
class TestIsActiveGlobalSwitch:
"""is_active - 全局开关基础"""
def test_disabled_returns_false(self):
config = FeatureFlagConfig(name="test", enabled=False)
assert config.is_active() is False
def test_disabled_with_identifier_returns_false(self):
config = FeatureFlagConfig(name="test", enabled=False)
assert config.is_active(identifier="user1") is False
def test_enabled_no_percentage_no_whitelist_returns_true(self):
config = FeatureFlagConfig(name="test", enabled=True)
# percentage=0, whitelist=空,但 enabled=True
# 按逻辑:全局开了但百分比0且无白名单 → 其实应该是 False?
# 让我看代码...
# 代码里 percentage <= 0 时返回 False(没有白名单且百分比为0)
assert config.is_active() is False
def test_enabled_100_percent_returns_true(self):
config = FeatureFlagConfig(name="test", enabled=True, percentage=100)
assert config.is_active() is True
# ============================================================
# FeatureFlagConfig.is_active - 白名单
# ============================================================
class TestIsActiveWhitelist:
"""is_active - 白名单优先级"""
def test_whitelist_match_returns_true(self):
config = FeatureFlagConfig(
name="test",
enabled=True,
whitelist={"user1", "user2"},
)
assert config.is_active(identifier="user1") is True
def test_whitelist_no_match_falls_through(self):
config = FeatureFlagConfig(
name="test",
enabled=True,
percentage=0,
whitelist={"user1"},
)
# 不在白名单,且百分比为0 → False
assert config.is_active(identifier="user3") is False
def test_whitelist_overrides_percentage_zero(self):
"""白名单优先级最高,即使百分比为0也能启用"""
config = FeatureFlagConfig(
name="test",
enabled=True,
percentage=0,
whitelist={"vip_user"},
)
assert config.is_active(identifier="vip_user") is True
def test_whitelist_overrides_partial_percentage(self):
"""白名单用户即使在百分比外也能启用"""
config = FeatureFlagConfig(
name="test",
enabled=True,
percentage=1, # 只有1%的用户
whitelist={"important_user"},
)
# 白名单用户直接通过
assert config.is_active(identifier="important_user") is True
def test_no_identifier_no_whitelist_check(self):
"""不传 identifier 时不做白名单检查"""
config = FeatureFlagConfig(
name="test",
enabled=True,
percentage=100,
whitelist={"user1"},
)
# 无 identifier,直接看百分比(100%)
assert config.is_active() is True
# ============================================================
# FeatureFlagConfig.is_active - 百分比边界值
# ============================================================
class TestIsActivePercentageBoundaries:
"""is_active - 百分比边界值"""
def test_percentage_0_returns_false(self):
config = FeatureFlagConfig(name="test", enabled=True, percentage=0)
assert config.is_active(identifier="any_user") is False
def test_percentage_100_returns_true(self):
config = FeatureFlagConfig(name="test", enabled=True, percentage=100)
assert config.is_active(identifier="any_user") is True
def test_percentage_negative_treated_as_0(self):
"""percentage < 0 应该按 0 处理"""
config = FeatureFlagConfig(name="test", enabled=True, percentage=-5)
assert config.is_active(identifier="any_user") is False
def test_percentage_over_100_treated_as_100(self):
"""percentage > 100 应该按 100 处理"""
config = FeatureFlagConfig(name="test", enabled=True, percentage=150)
assert config.is_active(identifier="any_user") is True
# ============================================================
# FeatureFlagConfig.is_active - 哈希一致性
# ============================================================
class TestIsActiveHashConsistency:
"""is_active - 哈希取模一致性验证"""
def test_same_user_same_result_every_time(self):
"""同一用户多次调用结果一致(确定性哈希)"""
config = FeatureFlagConfig(name="test", enabled=True, percentage=50)
results = {config.is_active(identifier="user_xyz") for _ in range(100)}
assert len(results) == 1 # 全部相同
def test_different_flags_same_user_can_differ(self):
"""不同 flag 对同一用户可以有不同结果(因为 flag name 参与哈希)"""
config_a = FeatureFlagConfig(name="flag_a", enabled=True, percentage=50)
config_b = FeatureFlagConfig(name="flag_b", enabled=True, percentage=50)
# 不保证一定不同,但大部分情况下应该不同
# 这里只验证哈希输入包含了 flag name(通过机制保证)
# 具体是否不同取决于哈希值
def test_percentage_coverage_roughly_correct(self):
"""大量用户中,命中比例大致接近百分比"""
config = FeatureFlagConfig(name="coverage_test", enabled=True, percentage=30)
users = [f"user_{i}" for i in range(1000)]
active_count = sum(1 for u in users if config.is_active(identifier=u))
# 30% ± 10% 的容差
assert 200 <= active_count <= 400
def test_50_percent_roughly_half(self):
config = FeatureFlagConfig(name="half_test", enabled=True, percentage=50)
users = [f"user_{i}" for i in range(1000)]
active_count = sum(1 for u in users if config.is_active(identifier=u))
# 50% ± 10%
assert 400 <= active_count <= 600
def test_10_percent_roughly_tenth(self):
config = FeatureFlagConfig(name="ten_pct", enabled=True, percentage=10)
users = [f"user_{i}" for i in range(1000)]
active_count = sum(1 for u in users if config.is_active(identifier=u))
assert 50 <= active_count <= 150
def test_empty_identifier_treated_as_no_identifier(self):
"""空字符串 identifier 应该如何处理?"""
config = FeatureFlagConfig(name="test", enabled=True, percentage=50)
# 空字符串是 falsy,走无 identifier 分支(随机)
# 但白名单检查也会跳过
# 验证不会崩溃
result = config.is_active(identifier="")
assert isinstance(result, bool)
# ============================================================
# InMemoryFeatureFlagStore - CRUD
# ============================================================
class TestInMemoryFeatureFlagStore:
"""InMemoryFeatureFlagStore 内存实现"""
def test_get_nonexistent_returns_default_disabled(self):
store = InMemoryFeatureFlagStore()
config = store.get("nonexistent")
assert config.name == "nonexistent"
assert config.enabled is False
assert config.percentage == 0
def test_set_and_get(self):
store = InMemoryFeatureFlagStore()
original = FeatureFlagConfig(
name="my_flag",
enabled=True,
percentage=50,
whitelist={"admin"},
)
store.set(original)
retrieved = store.get("my_flag")
assert retrieved.name == "my_flag"
assert retrieved.enabled is True
assert retrieved.percentage == 50
assert retrieved.whitelist == {"admin"}
def test_set_overwrites_existing(self):
store = InMemoryFeatureFlagStore()
store.set(FeatureFlagConfig(name="flag", enabled=True, percentage=30))
store.set(FeatureFlagConfig(name="flag", enabled=False, percentage=70))
config = store.get("flag")
assert config.enabled is False
assert config.percentage == 70
def test_delete_existing_returns_true(self):
store = InMemoryFeatureFlagStore()
store.set(FeatureFlagConfig(name="delete_me"))
result = store.delete("delete_me")
assert result is True
# 删除后获取返回默认配置
assert store.get("delete_me").enabled is False
def test_delete_nonexistent_returns_false(self):
store = InMemoryFeatureFlagStore()
result = store.delete("no_such_flag")
assert result is False
def test_list_all_empty(self):
store = InMemoryFeatureFlagStore()
assert store.list_all() == {}
def test_list_all_multiple(self):
store = InMemoryFeatureFlagStore()
store.set(FeatureFlagConfig(name="flag1", enabled=True))
store.set(FeatureFlagConfig(name="flag2", percentage=50))
store.set(FeatureFlagConfig(name="flag3"))
all_flags = store.list_all()
assert len(all_flags) == 3
assert "flag1" in all_flags
assert "flag2" in all_flags
assert "flag3" in all_flags
assert all_flags["flag1"].enabled is True
assert all_flags["flag2"].percentage == 50
def test_list_all_returns_copy(self):
"""返回的是副本,修改不影响内部状态"""
store = InMemoryFeatureFlagStore()
store.set(FeatureFlagConfig(name="flag1"))
flags = store.list_all()
flags["fake"] = FeatureFlagConfig(name="fake")
assert "fake" not in store.list_all()
# ============================================================
# InMemoryFeatureFlagStore - is_active
# ============================================================
class TestInMemoryStoreIsActive:
"""store.is_active 便捷方法"""
def test_is_active_enabled_flag(self):
store = InMemoryFeatureFlagStore()
store.set(FeatureFlagConfig(name="on", enabled=True, percentage=100))
assert store.is_active("on") is True
def test_is_active_disabled_flag(self):
store = InMemoryFeatureFlagStore()
store.set(FeatureFlagConfig(name="off", enabled=False))
assert store.is_active("off") is False
def test_is_active_nonexistent_flag(self):
store = InMemoryFeatureFlagStore()
assert store.is_active("unknown") is False
def test_is_active_with_identifier_whitelist(self):
store = InMemoryFeatureFlagStore()
store.set(
FeatureFlagConfig(
name="beta",
enabled=True,
percentage=0,
whitelist={"tester1"},
)
)
assert store.is_active("beta", identifier="tester1") is True
assert store.is_active("beta", identifier="other_user") is False
+569
View File
@@ -0,0 +1,569 @@
"""
Module Registry 模块注册中心单元测试
覆盖:
- ModuleStatus 枚举
- QuotaRule / ModuleCapability / Module 数据类
- Module.activate / disable 状态转换
- ModuleRegistry 注册/注销/查询/能力发现/依赖检查
"""
import pytest
from packages.infrastructure.module_registry import (
Module,
ModuleCapability,
ModuleRegistry,
ModuleStatus,
QuotaRule,
module_registry,
)
# ============================================================
# ModuleStatus
# ============================================================
class TestModuleStatus:
"""ModuleStatus 枚举"""
def test_enum_values(self):
assert ModuleStatus.REGISTERED.value == "registered"
assert ModuleStatus.ACTIVE.value == "active"
assert ModuleStatus.DISABLED.value == "disabled"
assert ModuleStatus.ERROR.value == "error"
def test_is_str_enum(self):
assert isinstance(ModuleStatus.ACTIVE, str)
assert ModuleStatus.ACTIVE == "active"
def test_has_four_states(self):
assert len(ModuleStatus) == 4
# ============================================================
# QuotaRule
# ============================================================
class TestQuotaRule:
"""QuotaRule 配额规则"""
def test_required_fields(self):
rule = QuotaRule(dimension="ai_credits", per_operation=1.0)
assert rule.dimension == "ai_credits"
assert rule.per_operation == 1.0
def test_default_description_empty(self):
rule = QuotaRule(dimension="storage_gb", per_operation=0.5)
assert rule.description == ""
def test_custom_description(self):
rule = QuotaRule(
dimension="credits",
per_operation=2.0,
description="每次生成消耗2积分",
)
assert rule.description == "每次生成消耗2积分"
def test_float_per_operation(self):
rule = QuotaRule(dimension="gb", per_operation=0.25)
assert rule.per_operation == 0.25
# ============================================================
# ModuleCapability
# ============================================================
class TestModuleCapability:
"""ModuleCapability 能力定义"""
def test_required_name(self):
cap = ModuleCapability(name="generate_voice")
assert cap.name == "generate_voice"
def test_defaults(self):
cap = ModuleCapability(name="test_cap")
assert cap.description == ""
assert cap.quota_rules == []
assert cap.metadata == {}
def test_with_quota_rules(self):
rules = [QuotaRule(dimension="credits", per_operation=1.0)]
cap = ModuleCapability(
name="generate",
description="生成功能",
quota_rules=rules,
)
assert cap.description == "生成功能"
assert len(cap.quota_rules) == 1
assert cap.quota_rules[0].dimension == "credits"
def test_with_metadata(self):
cap = ModuleCapability(
name="export",
metadata={"format": "mp4", "max_resolution": "1080p"},
)
assert cap.metadata["format"] == "mp4"
assert cap.metadata["max_resolution"] == "1080p"
# ============================================================
# Module
# ============================================================
class TestModuleDefaults:
"""Module 数据类默认值"""
def test_required_name(self):
mod = Module(name="ai_voice")
assert mod.name == "ai_voice"
def test_default_version(self):
mod = Module(name="test")
assert mod.version == "1.0.0"
def test_default_description(self):
mod = Module(name="test")
assert mod.description == ""
def test_default_capabilities_empty(self):
mod = Module(name="test")
assert mod.capabilities == []
def test_default_dependencies_empty(self):
mod = Module(name="test")
assert mod.dependencies == []
def test_default_status_registered(self):
mod = Module(name="test")
assert mod.status == ModuleStatus.REGISTERED
def test_default_config_empty(self):
mod = Module(name="test")
assert mod.config == {}
def test_full_module(self):
cap = ModuleCapability(name="do_something")
mod = Module(
name="full_module",
version="2.0.0",
description="完整模块",
capabilities=[cap],
dependencies=["dep1", "dep2"],
status=ModuleStatus.ACTIVE,
config={"key": "value"},
)
assert mod.version == "2.0.0"
assert mod.description == "完整模块"
assert len(mod.capabilities) == 1
assert mod.dependencies == ["dep1", "dep2"]
assert mod.status == ModuleStatus.ACTIVE
assert mod.config["key"] == "value"
class TestModuleActivate:
"""Module.activate 状态转换"""
def test_activate_from_registered(self):
mod = Module(name="test")
mod.activate()
assert mod.status == ModuleStatus.ACTIVE
def test_activate_from_disabled(self):
mod = Module(name="test", status=ModuleStatus.DISABLED)
mod.activate()
assert mod.status == ModuleStatus.ACTIVE
def test_activate_from_error_stays_error(self):
mod = Module(name="test", status=ModuleStatus.ERROR)
mod.activate()
# error 状态不可激活
assert mod.status == ModuleStatus.ERROR
def test_activate_already_active(self):
mod = Module(name="test", status=ModuleStatus.ACTIVE)
mod.activate()
assert mod.status == ModuleStatus.ACTIVE
class TestModuleDisable:
"""Module.disable 状态转换"""
def test_disable_from_registered(self):
mod = Module(name="test")
mod.disable()
assert mod.status == ModuleStatus.DISABLED
def test_disable_from_active(self):
mod = Module(name="test", status=ModuleStatus.ACTIVE)
mod.disable()
assert mod.status == ModuleStatus.DISABLED
def test_disable_from_error(self):
mod = Module(name="test", status=ModuleStatus.ERROR)
mod.disable()
assert mod.status == ModuleStatus.DISABLED
def test_disable_already_disabled(self):
mod = Module(name="test", status=ModuleStatus.DISABLED)
mod.disable()
assert mod.status == ModuleStatus.DISABLED
# ============================================================
# ModuleRegistry - 基础操作
# ============================================================
class TestModuleRegistryBasic:
"""ModuleRegistry 基础操作"""
def test_empty_registry(self):
registry = ModuleRegistry()
assert registry.list_modules() == []
assert registry.get_active_capabilities() == {}
def test_register_single_module(self):
registry = ModuleRegistry()
mod = Module(name="test_mod")
registry.register(mod)
assert registry.get("test_mod") is mod
def test_register_duplicate_raises(self):
registry = ModuleRegistry()
registry.register(Module(name="test_mod"))
with pytest.raises(ValueError, match="already registered"):
registry.register(Module(name="test_mod"))
def test_get_nonexistent_returns_none(self):
registry = ModuleRegistry()
assert registry.get("no_such_module") is None
def test_unregister_success(self):
registry = ModuleRegistry()
registry.register(Module(name="test_mod"))
registry.unregister("test_mod")
assert registry.get("test_mod") is None
def test_unregister_nonexistent_raises(self):
registry = ModuleRegistry()
with pytest.raises(KeyError, match="not found"):
registry.unregister("no_such_module")
def test_unregister_with_dependents_raises(self):
registry = ModuleRegistry()
registry.register(Module(name="base_module"))
registry.register(Module(name="dependent_module", dependencies=["base_module"]))
with pytest.raises(ValueError, match="depended on by"):
registry.unregister("base_module")
def test_clear(self):
registry = ModuleRegistry()
registry.register(Module(name="mod1"))
registry.register(Module(name="mod2"))
registry.clear()
assert registry.list_modules() == []
# ============================================================
# ModuleRegistry - 自动激活 & 依赖
# ============================================================
class TestModuleRegistryAutoActivate:
"""注册时自动激活逻辑"""
def test_no_deps_auto_activates(self):
registry = ModuleRegistry()
mod = Module(name="standalone")
registry.register(mod)
assert mod.status == ModuleStatus.ACTIVE
def test_with_deps_all_satisfied_auto_activates(self):
registry = ModuleRegistry()
registry.register(Module(name="base")) # 无依赖,自动激活
dep_mod = Module(name="dependent", dependencies=["base"])
registry.register(dep_mod)
assert dep_mod.status == ModuleStatus.ACTIVE
def test_with_deps_not_satisfied_stays_registered(self):
registry = ModuleRegistry()
mod = Module(name="dependent", dependencies=["missing_dep"])
registry.register(mod)
# 依赖不满足,保持 REGISTERED
assert mod.status == ModuleStatus.REGISTERED
def test_later_dep_registered_manual_activate(self):
"""先注册依赖模块,再注册被依赖模块时不自动激活前者
(需要手动或在注册完所有模块后调用 check_dependencies + activate)"""
registry = ModuleRegistry()
# 先注册依赖方(依赖未满足,不激活)
dependent = Module(name="dependent", dependencies=["base"])
registry.register(dependent)
assert dependent.status == ModuleStatus.REGISTERED
# 再注册被依赖方
base = Module(name="base")
registry.register(base)
assert base.status == ModuleStatus.ACTIVE
# 依赖方仍然是 REGISTERED(不会自动激活)
assert dependent.status == ModuleStatus.REGISTERED
class TestModuleRegistryCheckDependencies:
"""check_dependencies 依赖检查"""
def test_module_not_found_returns_false(self):
registry = ModuleRegistry()
assert registry.check_dependencies("nonexistent") is False
def test_no_deps_returns_true(self):
registry = ModuleRegistry()
registry.register(Module(name="standalone"))
assert registry.check_dependencies("standalone") is True
def test_all_deps_active_returns_true(self):
registry = ModuleRegistry()
registry.register(Module(name="dep1"))
registry.register(Module(name="dep2"))
registry.register(Module(name="main", dependencies=["dep1", "dep2"]))
# main 在注册时因依赖满足已自动激活
assert registry.check_dependencies("main") is True
def test_dep_not_registered_returns_false(self):
registry = ModuleRegistry()
mod = Module(name="main", dependencies=["missing"])
registry.register(mod)
assert registry.check_dependencies("main") is False
def test_dep_registered_but_not_active_returns_false(self):
registry = ModuleRegistry()
dep = Module(name="dep", status=ModuleStatus.DISABLED)
registry.register(dep)
# 手动设为 disabled(因为 register 时无依赖会自动激活)
dep.disable()
main = Module(name="main", dependencies=["dep"])
registry.register(main)
# 依赖未激活
assert registry.check_dependencies("main") is False
# ============================================================
# ModuleRegistry - list_modules & 状态过滤
# ============================================================
class TestModuleRegistryList:
"""list_modules 列表与过滤"""
def test_list_all(self):
registry = ModuleRegistry()
registry.register(Module(name="mod1"))
registry.register(Module(name="mod2"))
modules = registry.list_modules()
assert len(modules) == 2
names = {m.name for m in modules}
assert names == {"mod1", "mod2"}
def test_filter_by_active(self):
registry = ModuleRegistry()
registry.register(Module(name="active_mod")) # 自动激活
disabled = Module(name="disabled_mod")
registry.register(disabled)
disabled.disable()
active = registry.list_modules(status=ModuleStatus.ACTIVE)
assert len(active) == 1
assert active[0].name == "active_mod"
def test_filter_by_disabled(self):
registry = ModuleRegistry()
registry.register(Module(name="active_mod"))
disabled = Module(name="disabled_mod")
registry.register(disabled)
disabled.disable()
disabled_list = registry.list_modules(status=ModuleStatus.DISABLED)
assert len(disabled_list) == 1
assert disabled_list[0].name == "disabled_mod"
def test_filter_registered(self):
registry = ModuleRegistry()
# 有依赖未满足的模块保持 REGISTERED
mod = Module(name="waiting_mod", dependencies=["missing"])
registry.register(mod)
registered = registry.list_modules(status=ModuleStatus.REGISTERED)
assert len(registered) == 1
assert registered[0].name == "waiting_mod"
# ============================================================
# ModuleRegistry - 能力发现
# ============================================================
class TestModuleRegistryCapabilities:
"""能力发现:has_capability / get_capability / get_quota_rules"""
def test_has_capability_true(self):
registry = ModuleRegistry()
registry.register(
Module(
name="voice_module",
capabilities=[ModuleCapability(name="generate_voice")],
)
)
assert registry.has_capability("generate_voice") is True
def test_has_capability_false(self):
registry = ModuleRegistry()
registry.register(
Module(
name="voice_module",
capabilities=[ModuleCapability(name="generate_voice")],
)
)
assert registry.has_capability("generate_video") is False
def test_has_capability_inactive_module_not_counted(self):
registry = ModuleRegistry()
mod = Module(
name="inactive_mod",
capabilities=[ModuleCapability(name="secret_cap")],
)
registry.register(mod)
mod.disable()
assert registry.has_capability("secret_cap") is False
def test_get_capability_returns_first_match(self):
registry = ModuleRegistry()
cap1 = ModuleCapability(name="export", description="导出1")
cap2 = ModuleCapability(name="export", description="导出2")
registry.register(Module(name="mod1", capabilities=[cap1]))
registry.register(Module(name="mod2", capabilities=[cap2]))
result = registry.get_capability("export")
assert result is not None
assert result.name == "export"
# 返回第一个匹配的(mod1)
assert result.description == "导出1"
def test_get_capability_nonexistent_returns_none(self):
registry = ModuleRegistry()
assert registry.get_capability("no_such_cap") is None
def test_get_quota_rules(self):
rules = [
QuotaRule(dimension="credits", per_operation=1.0),
QuotaRule(dimension="storage", per_operation=0.5),
]
registry = ModuleRegistry()
registry.register(
Module(
name="voice_mod",
capabilities=[ModuleCapability(name="gen", quota_rules=rules)],
)
)
result = registry.get_quota_rules("gen")
assert len(result) == 2
assert result[0].dimension == "credits"
assert result[1].dimension == "storage"
def test_get_quota_rules_nonexistent_returns_empty(self):
registry = ModuleRegistry()
assert registry.get_quota_rules("no_cap") == []
# ============================================================
# ModuleRegistry - get_active_capabilities
# ============================================================
class TestModuleRegistryActiveCapabilities:
"""get_active_capabilities 已激活能力汇总"""
def test_empty_registry(self):
registry = ModuleRegistry()
assert registry.get_active_capabilities() == {}
def test_single_module_with_caps(self):
registry = ModuleRegistry()
registry.register(
Module(
name="voice_mod",
capabilities=[
ModuleCapability(name="generate_voice"),
ModuleCapability(name="clone_voice"),
],
)
)
result = registry.get_active_capabilities()
assert "voice_mod" in result
assert set(result["voice_mod"]) == {"generate_voice", "clone_voice"}
def test_skips_inactive_modules(self):
registry = ModuleRegistry()
registry.register(
Module(
name="active_mod",
capabilities=[ModuleCapability(name="active_cap")],
)
)
inactive = Module(
name="inactive_mod",
capabilities=[ModuleCapability(name="inactive_cap")],
)
registry.register(inactive)
inactive.disable()
result = registry.get_active_capabilities()
assert "active_mod" in result
assert "inactive_mod" not in result
def test_skips_modules_without_caps(self):
registry = ModuleRegistry()
registry.register(Module(name="no_cap_mod"))
result = registry.get_active_capabilities()
assert "no_cap_mod" not in result
def test_multiple_modules(self):
registry = ModuleRegistry()
registry.register(
Module(
name="mod1",
capabilities=[ModuleCapability(name="cap_a")],
)
)
registry.register(
Module(
name="mod2",
capabilities=[ModuleCapability(name="cap_b"), ModuleCapability(name="cap_c")],
)
)
result = registry.get_active_capabilities()
assert len(result) == 2
assert result["mod1"] == ["cap_a"]
assert set(result["mod2"]) == {"cap_b", "cap_c"}
# ============================================================
# 全局单例
# ============================================================
class TestGlobalSingleton:
"""全局 module_registry 单例"""
def test_singleton_exists(self):
assert module_registry is not None
assert isinstance(module_registry, ModuleRegistry)
def test_singleton_is_same_instance(self):
from packages.infrastructure.module_registry import module_registry as mr2
assert module_registry is mr2
+539
View File
@@ -0,0 +1,539 @@
"""
SharedStorageService 单元测试
重点覆盖纯逻辑部分:
- _normalize_storage_key: URL提取 + URL解码
- _is_local_generated_url: 本地生成URL判断
- get_url: 公共URL拼接
- create_direct_upload_post: policy + HMAC签名
- get_download_url: bucket=None时的fallback
- 未配置OSS时的错误处理
- 单例模式
"""
import base64
import hashlib
import hmac
import json
import os
from unittest.mock import MagicMock, patch
import pytest
from packages.shared.storage import (
SharedStorageService,
get_shared_storage_service,
get_storage_service,
)
# ============================================================
# Fixtures
# ============================================================
def _make_service(
bucket_name="test-bucket",
endpoint="oss-cn-hangzhou.aliyuncs.com",
access_key_id="test-key-id",
access_key_secret="test-key-secret",
local_url_prefix="/generated-files",
with_bucket=True,
):
"""创建一个 SharedStorageService 实例,mock 掉 oss2 和 settings。"""
mock_settings = MagicMock()
mock_settings.oss_bucket_name = bucket_name
mock_settings.oss_endpoint = endpoint
mock_settings.oss_access_key_id = access_key_id
mock_settings.oss_access_key_secret = access_key_secret
mock_bucket = MagicMock() if with_bucket else None
with (
patch("packages.shared.storage.get_shared_settings", return_value=mock_settings),
patch.dict(os.environ, {"GENERATED_FILES_URL_PREFIX": local_url_prefix}, clear=False),
):
if with_bucket:
with patch("packages.shared.storage.oss2") as mock_oss2:
mock_oss2.Auth.return_value = MagicMock()
mock_oss2.Bucket.return_value = mock_bucket
service = SharedStorageService()
service.bucket = mock_bucket
return service, mock_bucket, mock_settings
else:
service = SharedStorageService()
service.bucket = None
return service, None, mock_settings
# ============================================================
# _normalize_storage_key
# ============================================================
class TestNormalizeStorageKey:
"""_normalize_storage_key URL 提取与解码"""
def test_plain_key_returns_as_is(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("videos/clip.mp4")
assert result == "videos/clip.mp4"
def test_key_with_leading_slash_stripped(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("/videos/clip.mp4")
assert result == "videos/clip.mp4"
def test_https_url_extracts_path(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://test-bucket.oss-cn-hangzhou.aliyuncs.com/videos/clip.mp4")
assert result == "videos/clip.mp4"
def test_http_url_extracts_path(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("http://test-bucket.oss-cn-hangzhou.aliyuncs.com/audio/voice.mp3")
assert result == "audio/voice.mp3"
def test_url_with_query_strips_query(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss-cn.com/file.mp4?signature=abc&expires=123")
assert result == "file.mp4"
def test_url_with_leading_slash_in_path(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com//double/slash.jpg")
assert result == "double/slash.jpg"
def test_url_decodes_percent_encoded_spaces(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com/my%20video.mp4")
assert result == "my video.mp4"
def test_url_decodes_percent_encoded_chinese(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com/%E4%B8%AD%E6%96%87.mp4")
assert result == "中文.mp4"
def test_url_with_special_chars_decoded(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com/file%281%29.jpg")
assert result == "file(1).jpg"
def test_plain_key_with_percent_not_decoded(self):
"""原始 key 不以 http 开头,不做 URL 解码,直接 lstrip('/')"""
service, _, _ = _make_service()
result = service._normalize_storage_key("file%20name.mp4")
# 不是 URL,直接返回(去掉前导/)
assert result == "file%20name.mp4"
def test_empty_string(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("")
assert result == ""
def test_root_slash_url(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com/")
assert result == ""
def test_nested_path_url(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com/a/b/c/d/file.txt")
assert result == "a/b/c/d/file.txt"
def test_url_with_port(self):
service, _, _ = _make_service()
result = service._normalize_storage_key("https://bucket.oss.com:443/file.txt")
assert result == "file.txt"
# ============================================================
# _is_local_generated_url
# ============================================================
class TestIsLocalGeneratedUrl:
"""_is_local_generated_url 本地URL判断"""
def test_local_prefix_returns_true(self):
service, _, _ = _make_service()
assert service._is_local_generated_url("/generated-files/abc.mp4") is True
def test_relative_local_returns_true(self):
service, _, _ = _make_service()
# 没有 scheme,直接用原字符串匹配
assert service._is_local_generated_url("/generated-files/out.mp4") is True
def test_full_url_with_local_path_returns_true(self):
service, _, _ = _make_service()
assert service._is_local_generated_url("https://example.com/generated-files/abc.mp4") is True
def test_other_path_returns_false(self):
service, _, _ = _make_service()
assert service._is_local_generated_url("/videos/abc.mp4") is False
def test_empty_string_returns_false(self):
service, _, _ = _make_service()
assert service._is_local_generated_url("") is False
def test_custom_prefix(self):
service, _, _ = _make_service(local_url_prefix="/custom-prefix")
assert service._is_local_generated_url("/custom-prefix/file.mp4") is True
assert service._is_local_generated_url("/generated-files/file.mp4") is False
# ============================================================
# get_url
# ============================================================
class TestGetUrl:
"""get_url 公共URL拼接"""
def test_returns_public_url_plus_key(self):
service, _, _ = _make_service()
result = service.get_url("videos/test.mp4")
assert result == "https://test-bucket.oss-cn-hangzhou.aliyuncs.com/videos/test.mp4"
def test_empty_key(self):
service, _, _ = _make_service()
result = service.get_url("")
assert result == "https://test-bucket.oss-cn-hangzhou.aliyuncs.com/"
def test_custom_bucket_and_endpoint(self):
service, _, _ = _make_service(
bucket_name="my-bucket",
endpoint="oss-us-east-1.aliyuncs.com",
)
result = service.get_url("file.txt")
assert result == "https://my-bucket.oss-us-east-1.aliyuncs.com/file.txt"
# ============================================================
# create_direct_upload_post
# ============================================================
class TestCreateDirectUploadPost:
"""create_direct_upload_post 直传表单生成"""
def test_returns_dict_with_expected_keys(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post(
storage_key="uploads/test.jpg",
content_type="image/jpeg",
max_size_bytes=10 * 1024 * 1024,
expires_seconds=3600,
)
assert "url" in result
assert "method" in result
assert "storage_key" in result
assert "expires_at" in result
assert "fields" in result
def test_method_is_post(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
assert result["method"] == "POST"
def test_url_is_public_url(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
assert result["url"] == "https://test-bucket.oss-cn-hangzhou.aliyuncs.com"
def test_storage_key_normalized(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("/uploads/test.jpg", "image/jpeg", 1024, 3600)
assert result["storage_key"] == "uploads/test.jpg"
assert result["fields"]["key"] == "uploads/test.jpg"
def test_fields_contain_required_keys(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
fields = result["fields"]
assert fields["key"] == "uploads/a.jpg"
assert fields["OSSAccessKeyId"] == "test-key-id"
assert fields["success_action_status"] == "201"
assert fields["Content-Type"] == "image/jpeg"
assert "policy" in fields
assert "Signature" in fields
def test_policy_signature_is_valid_hmac_sha1(self):
"""验证 HMAC-SHA1 签名是否正确"""
secret = "my-secret-key-123"
service, _, _ = _make_service(access_key_secret=secret)
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
policy = result["fields"]["policy"]
signature = result["fields"]["Signature"]
# 手动计算签名验证
expected = base64.b64encode(
hmac.new(secret.encode("utf-8"), policy.encode("utf-8"), hashlib.sha1).digest()
).decode("ascii")
assert signature == expected
def test_policy_contains_bucket_and_key(self):
service, _, _ = _make_service(bucket_name="my-bucket")
result = service.create_direct_upload_post("uploads/photo.png", "image/png", 2048, 1800)
policy = json.loads(base64.b64decode(result["fields"]["policy"]))
conditions = policy["conditions"]
assert {"bucket": "my-bucket"} in conditions
assert {"key": "uploads/photo.png"} in conditions
def test_policy_contains_content_length_range(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 5242880, 3600)
policy = json.loads(base64.b64decode(result["fields"]["policy"]))
conditions = policy["conditions"]
size_condition = [c for c in conditions if isinstance(c, list) and c[0] == "content-length-range"]
assert len(size_condition) == 1
assert size_condition[0][1] == 1
assert size_condition[0][2] == 5242880
def test_policy_content_type_starts_with(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
policy = json.loads(base64.b64decode(result["fields"]["policy"]))
conditions = policy["conditions"]
ct_condition = [c for c in conditions if isinstance(c, list) and c[0] == "starts-with"]
assert len(ct_condition) == 1
assert ct_condition[0][1] == "$Content-Type"
assert ct_condition[0][2] == "image/"
def test_policy_has_expiration(self):
service, _, _ = _make_service()
result = service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
policy = json.loads(base64.b64decode(result["fields"]["policy"]))
assert "expiration" in policy
# ISO 8601 格式
assert policy["expiration"].endswith("Z")
def test_non_uploads_key_raises_value_error(self):
service, _, _ = _make_service()
with pytest.raises(ValueError, match="uploads/"):
service.create_direct_upload_post("videos/a.mp4", "video/mp4", 1024, 3600)
def test_no_credentials_raises_runtime_error(self):
service, _, _ = _make_service(access_key_id="", access_key_secret="", with_bucket=False)
with pytest.raises(RuntimeError, match="not configured"):
service.create_direct_upload_post("uploads/a.jpg", "image/jpeg", 1024, 3600)
def test_url_normalized_key_in_uploads(self):
service, _, _ = _make_service()
# URL 形式的 key 被 normalize 后如果在 uploads/ 下应该可以
result = service.create_direct_upload_post(
"https://test-bucket.oss-cn-hangzhou.aliyuncs.com/uploads/from_url.jpg",
"image/jpeg",
1024,
3600,
)
assert result["storage_key"] == "uploads/from_url.jpg"
# ============================================================
# get_download_url (bucket=None 时的 fallback)
# ============================================================
class TestGetDownloadUrlFallback:
"""get_download_url 在 bucket 未配置时的 fallback 逻辑"""
def test_no_bucket_local_url_returns_as_is(self):
service, _, _ = _make_service(with_bucket=False)
result = service.get_download_url("/generated-files/test.mp4")
assert result == "/generated-files/test.mp4"
def test_no_bucket_regular_key_returns_public_url(self):
service, _, _ = _make_service(with_bucket=False)
result = service.get_download_url("videos/test.mp4")
assert result == "https://test-bucket.oss-cn-hangzhou.aliyuncs.com/videos/test.mp4"
def test_no_bucket_url_input_normalized(self):
service, _, _ = _make_service(with_bucket=False)
result = service.get_download_url("https://test-bucket.oss-cn-hangzhou.aliyuncs.com/videos/test.mp4")
assert result == "https://test-bucket.oss-cn-hangzhou.aliyuncs.com/videos/test.mp4"
def test_with_bucket_calls_sign_url(self):
service, mock_bucket, _ = _make_service(with_bucket=True)
mock_bucket.sign_url.return_value = "https://signed-url.com/file?sig=abc"
result = service.get_download_url("videos/test.mp4", expires_seconds=7200)
mock_bucket.sign_url.assert_called_once_with("GET", "videos/test.mp4", 7200)
assert result == "https://signed-url.com/file?sig=abc"
def test_sign_url_exception_falls_back_to_public_url(self):
service, mock_bucket, _ = _make_service(with_bucket=True)
mock_bucket.sign_url.side_effect = Exception("sign error")
result = service.get_download_url("videos/test.mp4")
assert result == "https://test-bucket.oss-cn-hangzhou.aliyuncs.com/videos/test.mp4"
# ============================================================
# 未配置 OSS 时的错误处理
# ============================================================
class TestNoBucketErrorHandling:
"""bucket=None 时的错误处理"""
def test_upload_file_raises(self):
service, _, _ = _make_service(with_bucket=False)
with pytest.raises(RuntimeError, match="not configured"):
service.upload_file("/tmp/test.txt", "uploads/test.txt")
def test_download_file_raises(self):
service, _, _ = _make_service(with_bucket=False)
with pytest.raises(RuntimeError, match="not configured"):
service.download_file("uploads/test.txt", "/tmp/test.txt")
def test_delete_file_silent_noop(self):
service, _, _ = _make_service(with_bucket=False)
# 不抛异常
result = service.delete_file("uploads/test.txt")
assert result is None
def test_file_exists_returns_false(self):
service, _, _ = _make_service(with_bucket=False)
assert service.file_exists("uploads/test.txt") is False
# ============================================================
# upload_file / delete_file / file_exists 正常路径
# ============================================================
class TestBucketOperations:
"""有 bucket 时的操作调用验证"""
def test_upload_file_with_path_string(self):
service, mock_bucket, _ = _make_service()
result = service.upload_file("/tmp/file.txt", "uploads/file.txt", "text/plain")
mock_bucket.put_object_from_file.assert_called_once()
args = mock_bucket.put_object_from_file.call_args
assert args[0][0] == "uploads/file.txt"
assert args[0][1] == "/tmp/file.txt"
assert result.startswith("https://test-bucket.")
def test_upload_file_with_file_object(self):
service, mock_bucket, _ = _make_service()
mock_file = MagicMock()
result = service.upload_file(mock_file, "uploads/file.bin", "application/octet-stream")
mock_file.seek.assert_called_once_with(0)
mock_bucket.put_object.assert_called_once()
assert result.startswith("https://test-bucket.")
def test_delete_file_calls_bucket(self):
service, mock_bucket, _ = _make_service()
service.delete_file("uploads/test.txt")
mock_bucket.delete_object.assert_called_once_with("uploads/test.txt")
def test_delete_file_exception_logged_not_raised(self):
service, mock_bucket, _ = _make_service()
mock_bucket.delete_object.side_effect = Exception("delete error")
# 不抛异常
service.delete_file("uploads/test.txt")
def test_file_exists_delegates_to_bucket(self):
service, mock_bucket, _ = _make_service()
mock_bucket.object_exists.return_value = True
assert service.file_exists("some/key") is True
mock_bucket.object_exists.assert_called_once_with("some/key")
def test_file_exists_false(self):
service, mock_bucket, _ = _make_service()
mock_bucket.object_exists.return_value = False
assert service.file_exists("some/key") is False
# ============================================================
# 单例 & 兼容别名
# ============================================================
class TestSingleton:
"""get_shared_storage_service 单例模式"""
def test_get_storage_service_is_alias(self):
# 两个函数返回同一个实例
with patch("packages.shared.storage._storage_service", None):
with patch("packages.shared.storage.SharedStorageService") as mock_cls:
mock_instance = MagicMock()
mock_cls.return_value = mock_instance
svc1 = get_shared_storage_service()
svc2 = get_storage_service()
assert svc1 is svc2
# 因为是同一个单例,类只实例化一次
assert mock_cls.call_count == 1
# ============================================================
# __init__ endpoint 处理
# ============================================================
class TestInitEndpointHandling:
"""初始化时 endpoint https 前缀处理"""
def test_endpoint_without_https_gets_prefix(self):
mock_settings = MagicMock()
mock_settings.oss_bucket_name = "test-bucket"
mock_settings.oss_endpoint = "oss-cn-hangzhou.aliyuncs.com"
mock_settings.oss_access_key_id = "key-id"
mock_settings.oss_access_key_secret = "key-secret"
with (
patch("packages.shared.storage.get_shared_settings", return_value=mock_settings),
patch("packages.shared.storage.oss2") as mock_oss2,
):
mock_oss2.Bucket.return_value = MagicMock()
service = SharedStorageService()
# 验证 Bucket 构造时 endpoint 带了 https://
call_args = mock_oss2.Bucket.call_args
assert call_args[0][1] == "https://oss-cn-hangzhou.aliyuncs.com"
def test_endpoint_with_https_keeps_as_is(self):
mock_settings = MagicMock()
mock_settings.oss_bucket_name = "test-bucket"
mock_settings.oss_endpoint = "https://oss-cn-hangzhou.aliyuncs.com"
mock_settings.oss_access_key_id = "key-id"
mock_settings.oss_access_key_secret = "key-secret"
with (
patch("packages.shared.storage.get_shared_settings", return_value=mock_settings),
patch("packages.shared.storage.oss2") as mock_oss2,
):
mock_oss2.Bucket.return_value = MagicMock()
service = SharedStorageService()
call_args = mock_oss2.Bucket.call_args
assert call_args[0][1] == "https://oss-cn-hangzhou.aliyuncs.com"
def test_endpoint_with_http_keeps_as_is(self):
mock_settings = MagicMock()
mock_settings.oss_bucket_name = "test-bucket"
mock_settings.oss_endpoint = "http://oss-cn-hangzhou.aliyuncs.com"
mock_settings.oss_access_key_id = "key-id"
mock_settings.oss_access_key_secret = "key-secret"
with (
patch("packages.shared.storage.get_shared_settings", return_value=mock_settings),
patch("packages.shared.storage.oss2") as mock_oss2,
):
mock_oss2.Bucket.return_value = MagicMock()
service = SharedStorageService()
call_args = mock_oss2.Bucket.call_args
assert call_args[0][1] == "http://oss-cn-hangzhou.aliyuncs.com"