refactor: 删除 _validate_asset_ids_ownership 死代码函数
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 41s
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m30s
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 41s
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m30s
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
该函数已在 P3-2 优化中合并到 _download_library_assets,不再被调用。 同时删除 test_oneclick_gen_p0_fixes.py 中对应的 5 个测试用例, 归属校验覆盖已由 test_generation_p3_optimizations.py 提供。
This commit is contained in:
@@ -266,93 +266,3 @@ class TestP1Validations:
|
||||
with patch("worker_app.tasks.generation.SessionLocal", return_value=session):
|
||||
with pytest.raises(ValueError, match="模板不存在"):
|
||||
_validate_template_exists("tmpl_nonexistent")
|
||||
|
||||
def test_validate_asset_ids_ownership_success(self):
|
||||
"""素材归属正确时不抛异常."""
|
||||
from worker_app.tasks.generation import _validate_asset_ids_ownership
|
||||
|
||||
mock_asset = MagicMock()
|
||||
mock_asset.id = "a1"
|
||||
mock_asset.project_id = "proj1"
|
||||
mock_asset.asset_library_id = ""
|
||||
|
||||
session = MagicMock()
|
||||
mock_query = MagicMock()
|
||||
session.query.return_value = mock_query
|
||||
filter_result = MagicMock()
|
||||
mock_query.filter.return_value = filter_result
|
||||
filter_result.all.return_value = [mock_asset]
|
||||
|
||||
with patch("worker_app.tasks.generation.SessionLocal", return_value=session):
|
||||
_validate_asset_ids_ownership(
|
||||
asset_ids=["a1"],
|
||||
project_id="proj1",
|
||||
asset_library_id="",
|
||||
)
|
||||
|
||||
def test_validate_asset_ids_missing(self):
|
||||
"""素材不存在时抛 ValueError."""
|
||||
from worker_app.tasks.generation import _validate_asset_ids_ownership
|
||||
|
||||
session = MagicMock()
|
||||
mock_query = MagicMock()
|
||||
session.query.return_value = mock_query
|
||||
filter_result = MagicMock()
|
||||
mock_query.filter.return_value = filter_result
|
||||
filter_result.all.return_value = [] # 找不到任何素材
|
||||
|
||||
with patch("worker_app.tasks.generation.SessionLocal", return_value=session):
|
||||
with pytest.raises(ValueError, match="素材不存在"):
|
||||
_validate_asset_ids_ownership(
|
||||
asset_ids=["a_missing"],
|
||||
project_id="proj1",
|
||||
asset_library_id="",
|
||||
)
|
||||
|
||||
def test_validate_asset_ids_wrong_project(self):
|
||||
"""素材不属于指定项目时抛 ValueError."""
|
||||
from worker_app.tasks.generation import _validate_asset_ids_ownership
|
||||
|
||||
mock_asset = MagicMock()
|
||||
mock_asset.id = "a1"
|
||||
mock_asset.project_id = "other_project"
|
||||
mock_asset.asset_library_id = ""
|
||||
|
||||
session = MagicMock()
|
||||
mock_query = MagicMock()
|
||||
session.query.return_value = mock_query
|
||||
filter_result = MagicMock()
|
||||
mock_query.filter.return_value = filter_result
|
||||
filter_result.all.return_value = [mock_asset]
|
||||
|
||||
with patch("worker_app.tasks.generation.SessionLocal", return_value=session):
|
||||
with pytest.raises(ValueError, match="不属于指定项目"):
|
||||
_validate_asset_ids_ownership(
|
||||
asset_ids=["a1"],
|
||||
project_id="proj1",
|
||||
asset_library_id="",
|
||||
)
|
||||
|
||||
def test_validate_asset_ids_wrong_library(self):
|
||||
"""素材不属于指定素材库时抛 ValueError."""
|
||||
from worker_app.tasks.generation import _validate_asset_ids_ownership
|
||||
|
||||
mock_asset = MagicMock()
|
||||
mock_asset.id = "a1"
|
||||
mock_asset.project_id = ""
|
||||
mock_asset.asset_library_id = "other_lib"
|
||||
|
||||
session = MagicMock()
|
||||
mock_query = MagicMock()
|
||||
session.query.return_value = mock_query
|
||||
filter_result = MagicMock()
|
||||
mock_query.filter.return_value = filter_result
|
||||
filter_result.all.return_value = [mock_asset]
|
||||
|
||||
with patch("worker_app.tasks.generation.SessionLocal", return_value=session):
|
||||
with pytest.raises(ValueError, match="不属于指定素材库"):
|
||||
_validate_asset_ids_ownership(
|
||||
asset_ids=["a1"],
|
||||
project_id="",
|
||||
asset_library_id="lib1",
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user