xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(editing-planner): 拆分 useEditPlanClips Hook，按职责拆为列表 + CRUD #1007

Closed
xiaoxia wants to merge 2 commits from refactor/use-edit-plan-clips-split into develop
pull from: refactor/use-edit-plan-clips-split
merge into: xiaoxia:develop
Conversation 6 Commits 2 Files Changed -
xiaoxia commented 2026-07-27 07:29:27 +08:00
Owner
Copy Link
Copy Source

变更说明

拆分 useEditPlanClips 巨无霸 Hook（233 行），按职责拆分为目录结构：

  • useEditPlanClipList - 列表查询 + 选中状态
  • useEditPlanClipMutations - 创建/更新/删除/批量删除/重排序/素材导入
  • index - 组合入口 + 本地撤销重做

主文件 233 → 95 行（-59%）

导入路径保持不变（@/pages/editing-planner/hooks/useEditPlanClips），向后兼容。

## 变更说明 拆分 useEditPlanClips 巨无霸 Hook（233 行），按职责拆分为目录结构： - **useEditPlanClipList** - 列表查询 + 选中状态 - **useEditPlanClipMutations** - 创建/更新/删除/批量删除/重排序/素材导入 - **index** - 组合入口 + 本地撤销重做 主文件 233 → 95 行（-59%） 导入路径保持不变（`@/pages/editing-planner/hooks/useEditPlanClips`），向后兼容。
xiaoxia added 1 commit 2026-07-27 07:29:27 +08:00
refactor(editing-planner): 拆分 useEditPlanClips Hook，按职责拆为列表 + CRUD
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 26s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 55s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m8s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m19s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 34s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m14s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m28s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m37s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 53s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m49s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m39s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 16m6s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 41s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
24db76dd04 
主文件 233→95 行（-59%），拆分为：
- useEditPlanClipList: 列表查询 + 选中状态
- useEditPlanClipMutations: 创建/更新/删除/批量删除/重排序/素材导入
- index: 组合入口 + 本地撤销重做

导入路径保持向后兼容
auto-approve-bot approved these changes 2026-07-27 07:51:56 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-27 07:51:56 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-07-27 07:52:49 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1007
预览链接 https://pr-1007.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1007 | | 预览链接 | [https://pr-1007.preview.xiaoxiajianji.com](https://pr-1007.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 07:53:03 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1007

⚠️ 问题（2个需要修改）

  1. index.ts 第21行：useUndoRedo 初始化状态与服务器数据不同步

    • 问题描述：localClips 初始化为空数组 []，且没有逻辑在 clips 数据加载或更新时同步 localClips。根据注释，localClips 用于拖拽等即时操作，但目前它始终为空，导致拖拽功能无法正常工作或操作空列表。
    • 后果：拖拽功能失效，用户无法看到或操作本地暂存的片段状态。

  2. useEditPlanClipMutations.ts 第67, 104, 122, 152行：缺少 planId 非空校验

    • 问题描述：addClip 函数中有 if (!planId) return 的防护，但 updateClip、removeClip、reorderClips、importFromAssets 等函数均缺少此校验，直接使用 planId! 调用 API。
    • 后果：在 planId 尚未就绪（如 undefined）时触发操作，会导致 API 调用错误或运行时异常。

💡 建议（1个可选）

  1. useEditPlanClipList.ts & useEditPlanClipMutations.ts：QUERY_KEY 常量重复定义
    • 建议描述：两个文件中均定义了 const QUERY_KEY = "editPlanClips"。建议将其提取到公共常量文件中统一导出，避免因字符串不一致导致缓存失效失效。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 23:53:02 | 模型:

## 代码审查结果 - PR #1007 ### ⚠️ 问题（2个需要修改） 1. **index.ts 第21行**：`useUndoRedo` 初始化状态与服务器数据不同步 - **问题描述**：`localClips` 初始化为空数组 `[]`，且没有逻辑在 `clips` 数据加载或更新时同步 `localClips`。根据注释，`localClips` 用于拖拽等即时操作，但目前它始终为空，导致拖拽功能无法正常工作或操作空列表。 - **后果**：拖拽功能失效，用户无法看到或操作本地暂存的片段状态。 2. **useEditPlanClipMutations.ts 第67, 104, 122, 152行**：缺少 `planId` 非空校验 - **问题描述**：`addClip` 函数中有 `if (!planId) return` 的防护，但 `updateClip`、`removeClip`、`reorderClips`、`importFromAssets` 等函数均缺少此校验，直接使用 `planId!` 调用 API。 - **后果**：在 `planId` 尚未就绪（如 undefined）时触发操作，会导致 API 调用错误或运行时异常。 ### 💡 建议（1个可选） 1. **useEditPlanClipList.ts & useEditPlanClipMutations.ts**：`QUERY_KEY` 常量重复定义 - **建议描述**：两个文件中均定义了 `const QUERY_KEY = "editPlanClips"`。建议将其提取到公共常量文件中统一导出，避免因字符串不一致导致缓存失效失效。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 23:53:02 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot commented 2026-07-27 08:06:47 +08:00
Collaborator
Copy Link
Copy Source

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.
xiaoxia added 1 commit 2026-07-27 12:34:22 +08:00
Merge branch 'develop' into refactor/use-edit-plan-clips-split
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 36s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m14s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 52s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m16s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m59s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 44s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 47s
Details
AI Code Review / AI Code Review (pull_request) Successful in 32s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 53s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m17s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m56s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 16s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 8m2s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m8s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 21s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
26d026a366
xiaoxia closed this pull request 2026-07-27 15:26:25 +08:00
gitea-actions bot commented 2026-07-27 16:57:09 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1007 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1007 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 36s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m14s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 52s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m16s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m59s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 44s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 47s
Details
AI Code Review / AI Code Review (pull_request) Successful in 32s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 53s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m17s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m56s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 16s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 8m2s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m8s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 21s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1007
Delete Branch "refactor/use-edit-plan-clips-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?