xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

test(wave120): 抽离ass_subtitle_builder领域模型 + 68单测 #1016

Closed
xiaoxia wants to merge 1 commits from test/wave120-ass-subtitle-builder into develop
pull from: test/wave120-ass-subtitle-builder
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 3
+791 -203
xiaoxia commented 2026-07-27 09:18:00 +08:00
Owner
Copy Link
Copy Source

变更内容

  • 从 render_subtitles.py 抽离 ASS 字幕纯逻辑到 packages/domain/ass_subtitle_builder.py
  • render_subtitles.py: 255→89行 (-65%)
  • 新增 68 个单测，覆盖颜色转换/位置映射/Style构建/文本转义/时间格式化/完整ASS生成
  • 原有 78 个测试无回归
  • 保持向后兼容：render_subtitles 模块保留全部公开接口作为薄包装
## 变更内容 - 从 render_subtitles.py 抽离 ASS 字幕纯逻辑到 packages/domain/ass_subtitle_builder.py - render_subtitles.py: 255→89行 (-65%) - 新增 68 个单测，覆盖颜色转换/位置映射/Style构建/文本转义/时间格式化/完整ASS生成 - 原有 78 个测试无回归 - 保持向后兼容：render_subtitles 模块保留全部公开接口作为薄包装
xiaoxia added 1 commit 2026-07-27 09:18:00 +08:00
test(wave120): 抽离ass_subtitle_builder领域模型 + 68单测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 19s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 55s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 47s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m7s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m19s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m32s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m2s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m38s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m33s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m55s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m16s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 28s
Details
5674487fae 
- 从 render_subtitles.py 抽离 ASS 字幕纯逻辑到 packages/domain/ass_subtitle_builder.py
- render_subtitles.py: 255→89行 (-65%)
- 新增 68 个单测，覆盖颜色转换/位置映射/Style构建/文本转义/时间格式化/完整ASS生成
- 原有 78 个测试无回归
- 保持向后兼容：render_subtitles 模块保留全部公开接口作为薄包装
gitea-actions bot commented 2026-07-27 09:32:15 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1016
预览链接 https://pr-1016.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1016 | | 预览链接 | [https://pr-1016.preview.xiaoxiajianji.com](https://pr-1016.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 09:34:07 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1016

⚠️ 问题（3个需要修改）

  1. packages/domain/ass_subtitle_builder.py 第167行：escape_ass_text 函数缺少反斜杠转义，存在渲染错误风险。

    • ASS 格式中反斜杠 \ 是转义字符（如 \N 表示换行）。如果输入文本包含字面反斜杠（如 Windows 路径 C:\Users 或数学符号），渲染器会将其解释为控制码，导致字幕显示错乱或消失。
    • 修改建议：在处理换行符之前，先将 \ 替换为 \\。例如：text = text.replace("\\", "\\\\")，然后再处理 \n 等换行符。

  2. packages/domain/ass_subtitle_builder.py 第98行：build_ass_style 函数中 font_name 未处理逗号，存在格式破坏风险。

    • ASS 样式定义是逗号分隔的。如果字体名称包含逗号（例如 "Arial, Unicode MS"），会导致解析时列数错位，破坏文件结构，导致字幕无法加载或样式错乱。
    • 修改建议：对 font_name 进行清洗，将逗号替换为空格或下划线，或者抛出明确的错误提示。

  3. packages/domain/ass_subtitle_builder.py 第224行：build_ass_content 函数对 title_text 的空值处理不严谨。

    • 代码执行 bool(title_text.strip())，如果调用方传入 None（尽管类型提示为 str，但 Python 是动态的），会直接抛出 AttributeError。
    • 修改建议：在函数入口处对文本参数进行非空断言或默认值处理，如 title_text = title_text or ""。

💡 建议（2个可选）

  1. apps/worker/video_processing/render_subtitles.py 文件权限：文件权限从 644 变更为 755（可执行），但代码首行没有 Shebang（如 #!/usr/bin/env python）。如果该模块仅作为库被导入，建议保持 644；如果需要直接执行，请添加 Shebang。

  2. packages/domain/ass_subtitle_builder.py 第234行：配置参数的类型转换缺乏容错。

    • 代码直接使用 int(title_config.get("size", 48))，如果配置中传入非数字字符串（如 "large"），会导致 ValueError。
    • 建议增加 try-except 块捕获转换异常，或使用辅助函数进行安全的类型转换，回退到默认值。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 01:34:07 | 模型:

## 代码审查结果 - PR #1016 ### ⚠️ 问题（3个需要修改） 1. **packages/domain/ass_subtitle_builder.py 第167行**：`escape_ass_text` 函数缺少反斜杠转义，存在渲染错误风险。 - ASS 格式中反斜杠 `\` 是转义字符（如 `\N` 表示换行）。如果输入文本包含字面反斜杠（如 Windows 路径 `C:\Users` 或数学符号），渲染器会将其解释为控制码，导致字幕显示错乱或消失。 - 修改建议：在处理换行符之前，先将 `\` 替换为 `\\`。例如：`text = text.replace("\\", "\\\\")`，然后再处理 `\n` 等换行符。 2. **packages/domain/ass_subtitle_builder.py 第98行**：`build_ass_style` 函数中 `font_name` 未处理逗号，存在格式破坏风险。 - ASS 样式定义是逗号分隔的。如果字体名称包含逗号（例如 "Arial, Unicode MS"），会导致解析时列数错位，破坏文件结构，导致字幕无法加载或样式错乱。 - 修改建议：对 `font_name` 进行清洗，将逗号替换为空格或下划线，或者抛出明确的错误提示。 3. **packages/domain/ass_subtitle_builder.py 第224行**：`build_ass_content` 函数对 `title_text` 的空值处理不严谨。 - 代码执行 `bool(title_text.strip())`，如果调用方传入 `None`（尽管类型提示为 `str`，但 Python 是动态的），会直接抛出 `AttributeError`。 - 修改建议：在函数入口处对文本参数进行非空断言或默认值处理，如 `title_text = title_text or ""`。 ### 💡 建议（2个可选） 1. **apps/worker/video_processing/render_subtitles.py 文件权限**：文件权限从 `644` 变更为 `755`（可执行），但代码首行没有 Shebang（如 `#!/usr/bin/env python`）。如果该模块仅作为库被导入，建议保持 `644`；如果需要直接执行，请添加 Shebang。 2. **packages/domain/ass_subtitle_builder.py 第234行**：配置参数的类型转换缺乏容错。 - 代码直接使用 `int(title_config.get("size", 48))`，如果配置中传入非数字字符串（如 "large"），会导致 `ValueError`。 - 建议增加 `try-except` 块捕获转换异常，或使用辅助函数进行安全的类型转换，回退到默认值。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 01:34:07 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-27 15:26:28 +08:00
gitea-actions bot commented 2026-07-27 16:57:35 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1016 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1016 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 19s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 55s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 47s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m7s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m19s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m32s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m2s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m38s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m33s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m55s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m16s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 28s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1016
Delete Branch "test/wave120-ass-subtitle-builder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?