xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(templates): 拆分 TemplateDetailModal 为子组件（219→106行, -52%） #1055

Closed
xiaoxia wants to merge 2 commits from refactor/template-detail-modal into develop
pull from: refactor/template-detail-modal
merge into: xiaoxia:develop
Conversation 5 Commits 2 Files Changed 8
+212 -136
xiaoxia commented 2026-07-28 10:11:00 +08:00
Owner
Copy Link
Copy Source
No description provided.
xiaoxia added 1 commit 2026-07-28 10:11:00 +08:00
refactor(templates): 拆分 TemplateDetailModal 为子组件
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 57s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m5s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m1s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
Details
AI Code Review / AI Code Review (pull_request) Has been cancelled
Details
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m20s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m22s
Details
8acae70bd7 
三阶段重构：
- Phase 1: 提取类型到 template-detail-modal/types.ts
- Phase 2: 拆分为 4 个 UI 子组件
  - PreviewArea: 预览区
  - SegmentList: 素材规则/片段列表
  - StyleConfig: 样式配置网格
  - DetailFooter: 底部操作区（收藏+按钮）
- Phase 3: 主文件 219→106 行（-52%）

保持导入路径向后兼容
auto-approve-bot added 1 commit 2026-07-28 10:16:49 +08:00
style: auto-format with black + isort + prettier [skip ci-format-check]
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m29s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m38s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m21s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m19s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m13s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m22s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m10s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m54s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 23s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 25s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m30s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
6b8f227d6d
auto-approve-bot approved these changes 2026-07-28 10:33:33 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-28 10:33:33 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-07-28 10:34:33 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1055
预览链接 https://pr-1055.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1055 | | 预览链接 | [https://pr-1055.preview.xiaoxiajianji.com](https://pr-1055.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-07-28 10:34:34 +08:00
auto-approve-bot commented 2026-07-28 10:35:20 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1055

⚠️ 问题（0个需要修改）

无

💡 建议（2个可选）

  1. PreviewArea.tsx 第18行：重复计算 typeInfo
    • 父组件 TemplateDetailModal 中已经计算过 typeInfo，子组件 PreviewArea 中又执行了一次 TEMPLATE_TYPES.find。
    • 建议通过 props 将 typeInfo 传递给 PreviewArea 组件，避免重复查找，提升极微小的性能。
  2. Git 文件权限变更：源代码文件被修改为可执行权限（mode 100755）
    • Diff 显示 .tsx 和 .ts 文件权限从 100644 变更为 100755。通常源代码文件不需要可执行权限。
    • 建议检查 Git 配置或文件创建方式，确保提交时仅包含代码变更，不包含不必要的权限变更。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 02:35:20 | 模型:

## 代码审查结果 - PR #1055 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（2个可选） 1. **PreviewArea.tsx 第18行**：重复计算 `typeInfo` - 父组件 `TemplateDetailModal` 中已经计算过 `typeInfo`，子组件 `PreviewArea` 中又执行了一次 `TEMPLATE_TYPES.find`。 - 建议通过 props 将 `typeInfo` 传递给 `PreviewArea` 组件，避免重复查找，提升极微小的性能。 2. **Git 文件权限变更**：源代码文件被修改为可执行权限（mode 100755） - Diff 显示 `.tsx` 和 `.ts` 文件权限从 `100644` 变更为 `100755`。通常源代码文件不需要可执行权限。 - 建议检查 Git 配置或文件创建方式，确保提交时仅包含代码变更，不包含不必要的权限变更。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 02:35:20 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-28 11:16:06 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1055 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1055 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m29s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m38s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m21s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m19s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m13s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m22s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m10s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m54s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 23s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 25s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m30s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1055
Delete Branch "refactor/template-detail-modal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?