xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 16 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

test(wave141): xfade_builder domain 层 +63 单测 #1061

Closed
xiaoxia wants to merge 1 commits from test/wave141-xfade-builder into develop
pull from: test/wave141-xfade-builder
merge into: xiaoxia:develop
Conversation 6 Commits 1 Files Changed 1
+579
xiaoxia commented 2026-07-28 10:19:32 +08:00
Owner
Copy Link
Copy Source

变更内容

为 packages/domain/xfade_builder.py 新增 63 个单测，0 FFmpeg 依赖。

覆盖范围

模块 数量
常量与转场映射 13
chain_filters 滤镜串联 6
resolve_xfade_transition 名称解析 11
基础结构（空/单/多片段） 8
offset 计算 4
duration 钳制（防 exit 234） 6
转场类型 8
总时长计算 7
合计 63

核心验证点

  • 20+ 种转场映射：fade/dissolve/slide(4方向)/wipe(4方向)/zoom/circle/rect 及别名
  • 枚举 + 字符串双输入：支持 TransitionEffect 枚举和字符串名称
  • duration 钳制：不超过 first_input 可用时长、不超过 second_input、最小 1ms
  • offset 计算：累积时长 - td*i，非负钳制
  • 多片段链路：中间 xf 标签串联，最终输出标签可配
  • 边界场景：0 时长片段、超长转场、极短片段、大量短片段

验证

  • pytest: 63 passed
  • black 格式化通过
## 变更内容 为 `packages/domain/xfade_builder.py` 新增 63 个单测，0 FFmpeg 依赖。 ### 覆盖范围 | 模块 | 数量 | |------|------| | 常量与转场映射 | 13 | | chain_filters 滤镜串联 | 6 | | resolve_xfade_transition 名称解析 | 11 | | 基础结构（空/单/多片段） | 8 | | offset 计算 | 4 | | duration 钳制（防 exit 234） | 6 | | 转场类型 | 8 | | 总时长计算 | 7 | | **合计** | **63** | ### 核心验证点 - **20+ 种转场映射**：fade/dissolve/slide(4方向)/wipe(4方向)/zoom/circle/rect 及别名 - **枚举 + 字符串双输入**：支持 TransitionEffect 枚举和字符串名称 - **duration 钳制**：不超过 first_input 可用时长、不超过 second_input、最小 1ms - **offset 计算**：累积时长 - td*i，非负钳制 - **多片段链路**：中间 xf 标签串联，最终输出标签可配 - **边界场景**：0 时长片段、超长转场、极短片段、大量短片段 ### 验证 - pytest: 63 passed - black 格式化通过
xiaoxia added 1 commit 2026-07-28 10:19:32 +08:00
test(wave141): xfade_builder domain 层 +63 单测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 52s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 55s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m24s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m20s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m11s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m7s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m4s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m0s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m40s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m36s
Details
AI Code Review / AI Code Review (pull_request) Successful in 7m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 6m26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m30s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m6s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 5s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 30s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 42s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
0c9e104b03 
为 domain/xfade_builder.py 新增 63 个单测，0 FFmpeg 依赖：

- 常量与映射：13 个
- chain_filters 滤镜串联：6 个
- resolve_xfade_transition 转场名称解析：11 个
- 基础结构（空/单/多片段、标签、时长）：8 个
- offset 计算：4 个
- duration 钳制（防 exit 234）：6 个
- 转场类型：8 个
- 总时长计算：7 个

核心覆盖：
- 20+ 种转场名称及别名映射（slide/wipe/zoom/circle/rect 等）
- 支持 TransitionEffect 枚举和字符串两种输入
- duration 钳制：不超过 first_input、不超过 second_input、最小 1ms
- offset 计算：累积时长 - td*i，非负
- 多片段链路中间 xf 标签串联
- 极端场景：0 时长片段、超长转场、极短片段、多片段链路
gitea-actions bot commented 2026-07-28 10:42:54 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1061
预览链接 https://pr-1061.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1061 | | 预览链接 | [https://pr-1061.preview.xiaoxiajianji.com](https://pr-1061.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-07-28 11:34:57 +08:00
gitea-actions bot commented 2026-07-28 12:12:45 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1061 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1061 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
xiaoxia reopened this pull request 2026-07-28 12:23:21 +08:00
auto-approve-bot commented 2026-07-28 12:42:09 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1061

⚠️ 问题（0个需要修改）

💡 建议（3个可选）

  1. tests/unit/domain/test_xfade_builder.py 第339, 358, 416, 432行：建议将 import re 移至文件顶部。在函数内部导入标准库会轻微影响性能，且不符合 PEP8 规范。
  2. tests/unit/domain/test_xfade_builder.py 第37行：assert len(XFADE_TRANSITION_MAP) > 10 使用了硬编码的魔法数字。建议改为 assert len(XFADE_TRANSITION_MAP) > 0，以避免未来重构时因数量变化导致测试非预期失败。
  3. tests/unit/domain/test_xfade_builder.py 第211, 234行：断言中直接匹配字符串格式（如 ":duration=0.500"）较为脆弱。建议使用正则提取数值后进行浮点数比较（如 abs(val - 0.5) < 0.001），以兼容不同的浮点格式化输出。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 04:42:09 | 模型:

## 代码审查结果 - PR #1061 ### ⚠️ 问题（0个需要修改） ### 💡 建议（3个可选） 1. **tests/unit/domain/test_xfade_builder.py 第339, 358, 416, 432行**：建议将 `import re` 移至文件顶部。在函数内部导入标准库会轻微影响性能，且不符合 PEP8 规范。 2. **tests/unit/domain/test_xfade_builder.py 第37行**：`assert len(XFADE_TRANSITION_MAP) > 10` 使用了硬编码的魔法数字。建议改为 `assert len(XFADE_TRANSITION_MAP) > 0`，以避免未来重构时因数量变化导致测试非预期失败。 3. **tests/unit/domain/test_xfade_builder.py 第211, 234行**：断言中直接匹配字符串格式（如 `":duration=0.500"`）较为脆弱。建议使用正则提取数值后进行浮点数比较（如 `abs(val - 0.5) < 0.001`），以兼容不同的浮点格式化输出。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 04:42:09 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia reviewed 2026-07-28 13:32:21 +08:00
xiaoxia left a comment
Author
Owner
Copy Link
Copy Source

Code Quality不阻塞，核心测试全绿，批准合并。

Code Quality不阻塞，核心测试全绿，批准合并。
xiaoxia closed this pull request 2026-07-28 13:35:59 +08:00
xiaoxia commented 2026-07-28 13:39:48 +08:00
Author
Owner
Copy Link
Copy Source

重复PR，tests/unit/domain/test_xfade_builder.py 已在develop上存在（579行，内容一致），直接关闭。

重复PR，tests/unit/domain/test_xfade_builder.py 已在develop上存在（579行，内容一致），直接关闭。
gitea-actions bot commented 2026-07-28 13:44:26 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1061 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1061 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 52s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 55s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m24s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m20s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m11s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m7s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m4s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m0s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m40s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m36s
Details
AI Code Review / AI Code Review (pull_request) Successful in 7m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 6m26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m30s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m6s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 5s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 30s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 42s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1061
Delete Branch "test/wave141-xfade-builder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?