xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 12 Pull Requests 2 Actions 3 Packages Projects Releases 7 Wiki Activity

refactor(voice): 拆分 useCloneModal Hook（215→46行, -79%） #1062

Closed
xiaoxia wants to merge 3 commits from refactor/use-clone-modal into develop
pull from: refactor/use-clone-modal
merge into: xiaoxia:develop
Conversation 5 Commits 3 Files Changed 4
+269 -202
xiaoxia commented 2026-07-28 10:22:41 +08:00
Owner
Copy Link
Copy Source
No description provided.
xiaoxia added 1 commit 2026-07-28 10:22:42 +08:00
refactor(voice): 拆分 useCloneModal Hook
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 18s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m44s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 57s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 58s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 48s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m57s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m21s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m16s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 50s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m41s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 14s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m20s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 21s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
399b1af7ee 
三阶段重构：
- Phase 1: 拆分为 2 个子 Hook
  - useCloneFormState: 表单状态管理（字段/录音/文件/验证）
  - useCloneSubmit: 克隆提交流程（上传→克隆→完成）
- Phase 2: 主 Hook 组合子 Hook
- Phase 3: 主文件 215→46 行（-79%）

保持导出签名向后兼容
xiaoxia added 1 commit 2026-07-28 12:45:15 +08:00
fix(useCloneModal): 修复useCloneFormState相对路径层级错误
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 36s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m32s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m22s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m51s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m45s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m13s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m14s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m31s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m0s
Details
AI Code Review / AI Code Review (pull_request) Failing after 2m17s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 7m49s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 37s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 45s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 17m0s
Details
5648ccbd76
auto-approve-bot approved these changes 2026-07-28 12:54:47 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-28 12:54:48 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-07-28 12:55:16 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1062
预览链接 https://pr-1062.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1062 | | 预览链接 | [https://pr-1062.preview.xiaoxiajianji.com](https://pr-1062.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-07-28 13:04:23 +08:00
test(CloneModal): 补充Hook拆分说明注释
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 41s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m43s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m52s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m14s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m39s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 45s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 4m25s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m28s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 5m16s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 8m18s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 44s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 17s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 11m31s
Details
1b2b65506d
xiaoxia closed this pull request 2026-07-28 13:10:11 +08:00
auto-approve-bot commented 2026-07-28 13:14:02 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1062

⚠️ 问题（1个需要修改）

  1. apps/web/src/components/voice/hooks/useCloneFormState.ts 第60行：resetState 依赖导致的计数器双重递增逻辑错误
    • 问题描述：useEffect 监听 open 变化时会调用 resetState，而 handleClose（通常在关闭弹窗时调用）内部也调用了 resetState。resetState 内部会调用 getNextDefaultName() 递增计数器。这导致每次“打开-关闭”周期，计数器会增加 2 次（例如：打开显示“我的声音 1”，关闭后再打开显示“我的声音 3”）。
    • 后果：默认名称序号不连续，跳过数字，虽然不影响核心功能但属于明显的逻辑错误。
    • 修改建议：调整逻辑，仅在弹窗真正“打开”时生成新名称。可以将 getNextDefaultName() 的调用从 resetState 中移除，仅在 useEffect 的 if (open) 分支中显式调用 setVoiceName(getNextDefaultName())，或者修改 handleClose 使其仅清理数据而不生成新名称。

💡 建议（2个可选）

  1. apps/web/src/components/voice/hooks/useCloneFormState.ts 第60行：useEffect 依赖项存在潜在的无限循环风险
    • 具体内容：useEffect 的依赖数组包含了 resetState，而 resetState 依赖于 resetRecording（来自 useAudioRecorder）。如果 useAudioRecorder 返回的 resetRecording 引用不稳定（每次渲染都变化），会导致 useEffect 在 open=true 时不断触发 resetState，进而导致组件不断重渲染甚至死循环。建议确保 useAudioRecorder 对返回函数进行了正确的 useCallback 包装，或者此处使用 useRef 来存储 resetState 的最新引用以打破依赖循环。
  2. apps/web/src/components/voice/hooks/useCloneSubmit.ts 第68行：定时器清理逻辑依赖于组件卸载
    • 具体内容：当前代码在 useEffect 的 cleanup 函数中清理定时器，这意味着只有在组件卸载时定时器才会被清除。如果父组件通过控制 open 属性来隐藏弹窗而保持组件挂载，用户手动关闭弹窗后，2秒后的定时器仍会触发，导致 onSuccess 和 onClose 被重复调用。建议在 handleClose 或 open 变化时也主动清理定时器。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 05:14:01 | 模型:

## 代码审查结果 - PR #1062 ### ⚠️ 问题（1个需要修改） 1. **apps/web/src/components/voice/hooks/useCloneFormState.ts 第60行**：`resetState` 依赖导致的计数器双重递增逻辑错误 - **问题描述**：`useEffect` 监听 `open` 变化时会调用 `resetState`，而 `handleClose`（通常在关闭弹窗时调用）内部也调用了 `resetState`。`resetState` 内部会调用 `getNextDefaultName()` 递增计数器。这导致每次“打开-关闭”周期，计数器会增加 2 次（例如：打开显示“我的声音 1”，关闭后再打开显示“我的声音 3”）。 - **后果**：默认名称序号不连续，跳过数字，虽然不影响核心功能但属于明显的逻辑错误。 - **修改建议**：调整逻辑，仅在弹窗真正“打开”时生成新名称。可以将 `getNextDefaultName()` 的调用从 `resetState` 中移除，仅在 `useEffect` 的 `if (open)` 分支中显式调用 `setVoiceName(getNextDefaultName())`，或者修改 `handleClose` 使其仅清理数据而不生成新名称。 ### 💡 建议（2个可选） 1. **apps/web/src/components/voice/hooks/useCloneFormState.ts 第60行**：`useEffect` 依赖项存在潜在的无限循环风险 - **具体内容**：`useEffect` 的依赖数组包含了 `resetState`，而 `resetState` 依赖于 `resetRecording`（来自 `useAudioRecorder`）。如果 `useAudioRecorder` 返回的 `resetRecording` 引用不稳定（每次渲染都变化），会导致 `useEffect` 在 `open=true` 时不断触发 `resetState`，进而导致组件不断重渲染甚至死循环。建议确保 `useAudioRecorder` 对返回函数进行了正确的 `useCallback` 包装，或者此处使用 `useRef` 来存储 `resetState` 的最新引用以打破依赖循环。 2. **apps/web/src/components/voice/hooks/useCloneSubmit.ts 第68行**：定时器清理逻辑依赖于组件卸载 - **具体内容**：当前代码在 `useEffect` 的 cleanup 函数中清理定时器，这意味着只有在组件卸载时定时器才会被清除。如果父组件通过控制 `open` 属性来隐藏弹窗而保持组件挂载，用户手动关闭弹窗后，2秒后的定时器仍会触发，导致 `onSuccess` 和 `onClose` 被重复调用。建议在 `handleClose` 或 `open` 变化时也主动清理定时器。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 05:14:01 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-28 13:16:01 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1062 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1062 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 41s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m43s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m52s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m14s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m39s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 45s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 4m25s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m28s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 5m16s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 8m18s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 44s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 17s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 11m31s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1062
Delete Branch "refactor/use-clone-modal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?