xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases 7 Wiki Activity

test(wave143): voice_clone_profile 单测补全 +82 #1066

Closed
xiaoxia wants to merge 1 commits from test/wave143-voice-clone-profile into develop
pull from: test/wave143-voice-clone-profile
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 1
+596 -252
xiaoxia commented 2026-07-28 10:39:29 +08:00
Owner
Copy Link
Copy Source

变更说明

VoiceCloneProfile 音色克隆领域模型单测补全，新增82个测试用例。

测试覆盖

  • VoiceCloneStatus 枚举 (5): 状态值、数量、字符串比较、从字符串构建、无效值
  • TERMINAL_STATUSES 终态 (6): 3个终态验证 + 2个非终态 + 数量
  • create 工厂方法 (18): 基础创建、各字段填充、strip处理、参数校验(空/超长/纯空白)
  • 属性 is_terminal/is_retryable/is_ready (13): 各状态下的布尔属性验证
  • transition_to 状态机 (14): 8条合法转换路径 + 4条非法转换 + 字符串输入 + updated_at更新
  • mark_ 方法* (10): mark_processing/mark_ready/mark_failed/mark_disabled 各类场景
  • prepare_retry 重试 (6): 正常重试、清除错误/voice_id、不可重试场景
  • to_dict 序列化 (6): 字段完整性、值正确性、ready/failed状态、ISO时间格式

本地验证

  • pytest: 82 passed
  • black: 已格式化
## 变更说明 VoiceCloneProfile 音色克隆领域模型单测补全，新增82个测试用例。 ## 测试覆盖 - **VoiceCloneStatus 枚举** (5): 状态值、数量、字符串比较、从字符串构建、无效值 - **TERMINAL_STATUSES 终态** (6): 3个终态验证 + 2个非终态 + 数量 - **create 工厂方法** (18): 基础创建、各字段填充、strip处理、参数校验(空/超长/纯空白) - **属性 is_terminal/is_retryable/is_ready** (13): 各状态下的布尔属性验证 - **transition_to 状态机** (14): 8条合法转换路径 + 4条非法转换 + 字符串输入 + updated_at更新 - **mark_* 方法** (10): mark_processing/mark_ready/mark_failed/mark_disabled 各类场景 - **prepare_retry 重试** (6): 正常重试、清除错误/voice_id、不可重试场景 - **to_dict 序列化** (6): 字段完整性、值正确性、ready/failed状态、ISO时间格式 ## 本地验证 - pytest: 82 passed - black: 已格式化
xiaoxia added 1 commit 2026-07-28 10:39:29 +08:00
test(wave143): add voice_clone_profile unit tests (+82)
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 29s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m27s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m9s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 40s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 28s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 18s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m26s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 49s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m7s
Details
AI Code Review / AI Code Review (pull_request) Failing after 3m27s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m34s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m12s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 55s
Details
0a8bae0772 
- VoiceCloneStatus 枚举: 5种状态值、字符串比较、从字符串构建
- TERMINAL_STATUSES: 3个终态验证
- create 工厂方法: 基础创建、各字段(description/source_audio/language/gender/max_retries/metadata)、strip处理
- 参数校验: 空user_id/空name/超长name/纯空白
- 属性: is_terminal(5种状态)、is_retryable(各种场景)、is_ready(4种场景)
- transition_to: 合法转换(8条路径)、非法转换(4条)、字符串输入、updated_at更新
- mark_*方法: mark_processing/mark_ready/mark_failed/mark_disabled 各类场景
- prepare_retry: 正常重试、清除错误/voice_id、非failed不可重试、超上限不可重试
- to_dict: 字段完整性、值正确性、ready/failed状态、ISO时间格式
gitea-actions bot commented 2026-07-28 11:27:48 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1066
预览链接 https://pr-1066.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1066 | | 预览链接 | [https://pr-1066.preview.xiaoxiajianji.com](https://pr-1066.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-28 11:28:51 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：是
  • 阻塞级问题数量：1 个

📊 审查概览

  • 整体评价：需修改
  • 建议级问题数量：1 个

🔴 阻塞级问题（必须修复）

  1. [tests/unit/test_voice_clone_profile.py: 648-650] 代码截断导致的语法错误
    • 问题类型：语法错误
    • 问题描述：Diff 显示的最后一行代码为 exp，位于 test_to_dict_keys 方法中。代码在此处中断，未完成变量定义或断言逻辑，导致 Python 语法错误，测试文件无法运行。
    • 修改建议：补全 test_to_dict_keys 方法的剩余代码（通常包括定义预期字段列表 expected_keys 并断言 d.keys() == expected_keys 或类似逻辑）。

💡 改进建议（不阻塞合并）

  1. [tests/unit/test_voice_clone_profile.py: 336] 避免在测试中使用 sleep
    • 具体内容：在 test_transition_updates_updated_at 测试中使用了 sleep(0.01) 来等待时间变化。这会降低测试执行速度，且在系统负载高时可能不稳定。建议使用 unittest.mock.patch 修改 datetime 或 time 来模拟时间流逝，提高测试的确定性和速度。

✅ 良好实践

  • 测试覆盖面非常全面，涵盖了枚举、工厂方法、属性、状态转换（合法与非法）、边界条件（如恰好100字符）、重试逻辑等。
  • 测试用例命名清晰，能够准确反映测试意图。
  • 使用了 pytest.raises 对异常场景进行了良好的验证。

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 03:28:51 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：是 - 阻塞级问题数量：1 个 ### 📊 审查概览 - 整体评价：需修改 - 建议级问题数量：1 个 ### 🔴 阻塞级问题（必须修复） 1. **[tests/unit/test_voice_clone_profile.py: 648-650] 代码截断导致的语法错误** - 问题类型：语法错误 - 问题描述：Diff 显示的最后一行代码为 `exp`，位于 `test_to_dict_keys` 方法中。代码在此处中断，未完成变量定义或断言逻辑，导致 Python 语法错误，测试文件无法运行。 - 修改建议：补全 `test_to_dict_keys` 方法的剩余代码（通常包括定义预期字段列表 `expected_keys` 并断言 `d.keys() == expected_keys` 或类似逻辑）。 ### 💡 改进建议（不阻塞合并） 1. **[tests/unit/test_voice_clone_profile.py: 336] 避免在测试中使用 sleep** - 具体内容：在 `test_transition_updates_updated_at` 测试中使用了 `sleep(0.01)` 来等待时间变化。这会降低测试执行速度，且在系统负载高时可能不稳定。建议使用 `unittest.mock.patch` 修改 `datetime` 或 `time` 来模拟时间流逝，提高测试的确定性和速度。 ### ✅ 良好实践 - 测试覆盖面非常全面，涵盖了枚举、工厂方法、属性、状态转换（合法与非法）、边界条件（如恰好100字符）、重试逻辑等。 - 测试用例命名清晰，能够准确反映测试意图。 - 使用了 `pytest.raises` 对异常场景进行了良好的验证。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 03:28:51 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-28 12:23:51 +08:00
gitea-actions bot commented 2026-07-28 12:41:27 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1066 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1066 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some required checks failed
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 29s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m27s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m9s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 40s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 28s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 18s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m26s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 49s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m7s
Details
AI Code Review / AI Code Review (pull_request) Failing after 3m27s
Required
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m34s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m12s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Required
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 55s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1066
Delete Branch "test/wave143-voice-clone-profile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?