xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 16 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

test(wave147): transition_config 单测补全 +78 #1070

Closed
xiaoxia wants to merge 1 commits from test/wave147-transition-config into develop
pull from: test/wave147-transition-config
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 1
+392 -202
xiaoxia commented 2026-07-28 10:54:03 +08:00
Owner
Copy Link
Copy Source

变更说明

transition_config 转场配置领域模型单测补全，新增78个测试用例。

测试覆盖

  • 常量 (5): min/max/default duration、范围合理性、cut常量
  • TransitionType 枚举 (11): 各类型值、总数、all_supported()、is_supported()大小写/下划线/中划线
  • parse - effect (24): None/空/空白/cut/大小写/有效效果/去空白/无效降级、10个别名
  • parse - duration (12): None/正常/min/max/低于min/0/负/超max/字符串/无效字符串/整数
  • 属性 (9): is_cut(3种)、ffmpeg_transition(6种)
  • validate (8): 正常cut/fade、边界min/max、时长太小/太大、未知效果
  • 默认值 (5): 默认effect/duration、parse无参/双None、dataclass验证

本地验证

  • pytest: 78 passed
  • black: 已格式化
## 变更说明 transition_config 转场配置领域模型单测补全，新增78个测试用例。 ## 测试覆盖 - **常量** (5): min/max/default duration、范围合理性、cut常量 - **TransitionType 枚举** (11): 各类型值、总数、all_supported()、is_supported()大小写/下划线/中划线 - **parse - effect** (24): None/空/空白/cut/大小写/有效效果/去空白/无效降级、10个别名 - **parse - duration** (12): None/正常/min/max/低于min/0/负/超max/字符串/无效字符串/整数 - **属性** (9): is_cut(3种)、ffmpeg_transition(6种) - **validate** (8): 正常cut/fade、边界min/max、时长太小/太大、未知效果 - **默认值** (5): 默认effect/duration、parse无参/双None、dataclass验证 ## 本地验证 - pytest: 78 passed - black: 已格式化
xiaoxia added 1 commit 2026-07-28 10:54:03 +08:00
test(wave147): add transition_config unit tests (+78)
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 5s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m56s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m11s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 28s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 33s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m15s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m44s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 40s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m8s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m22s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 5m55s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m51s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m19s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m27s
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 34s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 52s
Details
883af85bdc 
- 常量: min/max/default duration、范围合理性、cut常量
- TransitionType枚举: 14种类型值、all_supported()、is_supported()(大小写/下划线/中划线)
- TransitionConfig.parse effect: None/空/空白/cut/大小写/有效效果/去空白/
  无效降级、别名(crossfade/crossdissolve/fadein/fadeout/slide/wipe/zoomin/circle/rect)
- TransitionConfig.parse duration: None/正常/min/max/低于min/0/负/超max/字符串/无效字符串/整数
- 属性: is_cut、ffmpeg_transition(cut/fade/dissolve/slideleft/zoom/circlecrop/未知回退)
- validate: 正常cut/fade、边界min/max、时长太小/太大、未知效果
- 默认值: 默认effect/duration、parse无参/双None、dataclass验证
auto-approve-bot commented 2026-07-28 11:46:32 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1070

⚠️ 问题（0个需要修改）

无

💡 建议（1个可选）

  1. tests/unit/test_transition_config.py 第115行：test_is_supported_cut 方法仅包含 pass 语句，未完成测试逻辑。
    • 说明：该方法的文档字符串和注释存在歧义（文档称 cut 不被算作 supported，注释称 cut 应该在枚举映射中），且未对 TransitionType.is_supported("cut") 的实际行为进行断言。如果 is_supported 依赖于枚举映射，cut 可能会返回 True；如果依赖于 all_supported，则返回 False。建议补充断言以明确预期行为，或删除该空测试方法。

✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 03:46:32 | 模型:

## 代码审查结果 - PR #1070 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（1个可选） 1. **tests/unit/test_transition_config.py 第115行**：`test_is_supported_cut` 方法仅包含 `pass` 语句，未完成测试逻辑。 - **说明**：该方法的文档字符串和注释存在歧义（文档称 cut 不被算作 supported，注释称 cut 应该在枚举映射中），且未对 `TransitionType.is_supported("cut")` 的实际行为进行断言。如果 `is_supported` 依赖于枚举映射，cut 可能会返回 True；如果依赖于 `all_supported`，则返回 False。建议补充断言以明确预期行为，或删除该空测试方法。 --- ✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 03:46:32 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-28 11:47:12 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1070
预览链接 https://pr-1070.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1070 | | 预览链接 | [https://pr-1070.preview.xiaoxiajianji.com](https://pr-1070.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-07-28 12:24:05 +08:00
gitea-actions bot commented 2026-07-28 12:42:11 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1070 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1070 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 5s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m56s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m11s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 28s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 33s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m15s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m44s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 40s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m8s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m22s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 5m55s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m51s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m19s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m27s
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 34s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 52s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1070
Delete Branch "test/wave147-transition-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?