refactor(generate): 拆分 Step7ConfirmGenerate 为子组件(194→88行, -55%) #1091

Merged
xiaoxia merged 2 commits from refactor/step7-confirm into develop 2026-07-28 16:18:51 +08:00
Owner

变更说明

将 Step7ConfirmGenerate 组件拆分为子组件,主文件从 194 行减至 88 行(-55%)。

拆分结构

  • SummaryCard:生成摘要确认卡片(模板/素材/标题/配音/封面/生成数量)
  • GenerationStatus:生成状态反馈(进行中/成功/失败三态)
  • Step7ConfirmGenerate:主组件,组合子组件

兼容性

  • 导出路径不变
  • Props 接口完全兼容,无破坏性变更
### 变更说明 将 Step7ConfirmGenerate 组件拆分为子组件,主文件从 194 行减至 88 行(-55%)。 ### 拆分结构 - **SummaryCard**:生成摘要确认卡片(模板/素材/标题/配音/封面/生成数量) - **GenerationStatus**:生成状态反馈(进行中/成功/失败三态) - **Step7ConfirmGenerate**:主组件,组合子组件 ### 兼容性 - 导出路径不变 - Props 接口完全兼容,无破坏性变更
xiaoxia force-pushed refactor/step7-confirm from dfeae21892 to 21a31a03d1 2026-07-28 14:43:27 +08:00 Compare
xiaoxia added 2 commits 2026-07-28 16:06:07 +08:00
chore: retrigger CI
CI/CD Pipeline / Staging E2E Tests (pull_request) Blocked by required conditions
CI/CD Pipeline / Staging API Integration Tests (pull_request) Blocked by required conditions
CI/CD Pipeline / Deploy Production (pull_request) Blocked by required conditions
CI/CD Pipeline / Production Browser E2E (pull_request) Blocked by required conditions
CI/CD Pipeline / ACR Image Cleanup (pull_request) Blocked by required conditions
CI/CD Pipeline / Canary Release to Production (pull_request) Blocked by required conditions
Preview Cleanup / Cleanup Preview Environment (pull_request) Waiting to run
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 21s
CI/CD Pipeline / Unit Tests (pull_request) Waiting to run
CI/CD Pipeline / Frontend Unit Tests (pull_request) Waiting to run
CI/CD Pipeline / Build Production API Image (pull_request) Waiting to run
CI/CD Pipeline / Build Production Web Image (pull_request) Waiting to run
CI/CD Pipeline / Build Production Worker Image (pull_request) Waiting to run
CI/CD Pipeline / CI Gate (pull_request) Blocked by required conditions
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 57s
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Waiting to run
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m2s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m21s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m2s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m53s
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m5s
AI Code Review / AI Code Review (pull_request) Successful in 1m44s
CI/CD Pipeline / Integration Tests (pull_request) Waiting to run
PR Automation / Auto Approve on CI Green (pull_request) Failing after 58s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 57s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m56s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m12s
e255f27cd7
xiaoxia force-pushed refactor/step7-confirm from 7705cff1b9 to e255f27cd7 2026-07-28 16:06:07 +08:00 Compare
xiaoxia merged commit 19ca924087 into develop 2026-07-28 16:18:51 +08:00
Collaborator

【阻塞级判定】

  • 是否存在阻塞级问题:否
  • 阻塞级问题数量:0 个

📊 审查概览

  • 整体评价:通过
  • 建议级问题数量:1 个

🔴 阻塞级问题(必须修复)

💡 改进建议(不阻塞合并)

  1. [所有修改文件] 文件权限变更
    • 具体内容:Diff 显示文件模式从 100644 变更为 100755(添加了可执行权限)。对于 .tsx 源代码文件,这通常是不必要的,可能是由于 Git 配置(core.fileMode)或本地误操作导致的。建议还原文件权限,保持源码文件为普通文件权限(644),以避免干扰代码审查和部署流程。

良好实践

  • 组件拆分合理:将 Step7ConfirmGenerate 中庞大的 JSX 逻辑拆分为 SummaryCardGenerationStatus 两个子组件,符合单一职责原则,显著提升了代码的可读性和可维护性。
  • 逻辑保持一致:重构后的代码逻辑(如 Math.min(Math.round(progress), 100)、按钮禁用条件等)与原代码完全一致,未引入回归风险。
  • 类型定义清晰:新组件的 interface 定义明确,Props 传递结构清晰,有助于后续维护。

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 08:33:50 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题:否 - 阻塞级问题数量:0 个 ### 📊 审查概览 - 整体评价:通过 - 建议级问题数量:1 个 ### 🔴 阻塞级问题(必须修复) 无 ### 💡 改进建议(不阻塞合并) 1. **[所有修改文件] 文件权限变更** - 具体内容:Diff 显示文件模式从 `100644` 变更为 `100755`(添加了可执行权限)。对于 `.tsx` 源代码文件,这通常是不必要的,可能是由于 Git 配置(`core.fileMode`)或本地误操作导致的。建议还原文件权限,保持源码文件为普通文件权限(`644`),以避免干扰代码审查和部署流程。 ### ✅ 良好实践 - **组件拆分合理**:将 `Step7ConfirmGenerate` 中庞大的 JSX 逻辑拆分为 `SummaryCard` 和 `GenerationStatus` 两个子组件,符合单一职责原则,显著提升了代码的可读性和可维护性。 - **逻辑保持一致**:重构后的代码逻辑(如 `Math.min(Math.round(progress), 100)`、按钮禁用条件等)与原代码完全一致,未引入回归风险。 - **类型定义清晰**:新组件的 `interface` 定义明确,Props 传递结构清晰,有助于后续维护。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 08:33:50 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot reviewed 2026-07-28 16:34:03 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。

🚀 预览环境已部署

项目 详情
PR号 #1091
预览链接 https://pr-1091.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1091 | | 预览链接 | [https://pr-1091.preview.xiaoxiajianji.com](https://pr-1091.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
Sign in to join this conversation.