xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

test(wave178): ai_parsing AI解析配置 +53测 #1132

Closed
xiaoxia wants to merge 1 commits from test/wave178-ai-parsing into develop
pull from: test/wave178-ai-parsing
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 1
+414
xiaoxia commented 2026-07-29 13:44:16 +08:00
Owner
Copy Link
Copy Source

wave178: ai_parsing AI解析配置单测

  • 模块：domain/ai_parsing.py
  • 新增测试：53个
  • 覆盖：AI解析配置、参数校验、结果解析等纯逻辑
  • 本地验证：ruff + black + pytest 全绿
## wave178: ai_parsing AI解析配置单测 - 模块：domain/ai_parsing.py - 新增测试：53个 - 覆盖：AI解析配置、参数校验、结果解析等纯逻辑 - 本地验证：ruff + black + pytest 全绿
xiaoxia added 1 commit 2026-07-29 13:44:16 +08:00
test(wave178): ai_parsing AI响应解析 +53测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 52s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m12s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m28s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m15s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m27s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m18s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m10s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m18s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m37s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m49s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 6s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 36m21s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 37s
Details
25c53260cd
gitea-actions bot commented 2026-07-29 13:52:01 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1132
预览链接 https://pr-1132.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1132 | | 预览链接 | [https://pr-1132.preview.xiaoxiajianji.com](https://pr-1132.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-29 13:52:21 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：2 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

  1. [tests/unit/domain/test_ai_parsing.py]test_score_is_rounded_to_3_decimals 方法优化

    • 具体内容：该方法使用 str(...).split(".")[-1] 来检查小数位数。虽然对于常规情况能工作，但在处理浮点数时存在脆弱性（例如遇到科学计数法或精度边界时）。建议使用数学比较方式 assert result[0]["match_score"] == round(result[0]["match_score"], 3) 来直接验证数值精度，更加严谨可靠。

  2. [tests/unit/domain/test_ai_parsing.py]test_invalid_json_falls_back_to_line_parse 断言增强

    • 具体内容：当前测试仅断言 len(result) >= 1，这只能验证函数未崩溃且返回了非空列表，无法有效证明“按行解析”的回退逻辑是否正确执行（例如，若实现错误地返回了 ["dummy"]，测试也会通过）。建议增加对返回内容的具体断言，如验证结果列表中是否包含输入字符串的特定片段，以确保回退逻辑确实在处理文本。

✅ 良好实践

  • 测试可复现性：在 TestGenerateTitlesFallback 中使用 patch.object(random, "shuffle", ...) 锁定了随机性，保证了单元测试的稳定输出，值得肯定。
  • 覆盖度全面：测试用例覆盖了多种边界情况（空值、超长字符串、非法JSON、中英文混合、不同标点符号格式），有助于提高代码健壮性。
  • 副作用检查：包含 test_asset_dict_not_mutated 测试，验证了函数未修改输入参数，符合纯函数/无副作用的最佳实践。

🤖 由 AI 代码审查机器人自动生成 | 2026-07-29 05:52:21 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：2 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 1. **[tests/unit/domain/test_ai_parsing.py]`test_score_is_rounded_to_3_decimals` 方法优化** - 具体内容：该方法使用 `str(...).split(".")[-1]` 来检查小数位数。虽然对于常规情况能工作，但在处理浮点数时存在脆弱性（例如遇到科学计数法或精度边界时）。建议使用数学比较方式 `assert result[0]["match_score"] == round(result[0]["match_score"], 3)` 来直接验证数值精度，更加严谨可靠。 2. **[tests/unit/domain/test_ai_parsing.py]`test_invalid_json_falls_back_to_line_parse` 断言增强** - 具体内容：当前测试仅断言 `len(result) >= 1`，这只能验证函数未崩溃且返回了非空列表，无法有效证明“按行解析”的回退逻辑是否正确执行（例如，若实现错误地返回了 `["dummy"]`，测试也会通过）。建议增加对返回内容的具体断言，如验证结果列表中是否包含输入字符串的特定片段，以确保回退逻辑确实在处理文本。 ### ✅ 良好实践 - **测试可复现性**：在 `TestGenerateTitlesFallback` 中使用 `patch.object(random, "shuffle", ...)` 锁定了随机性，保证了单元测试的稳定输出，值得肯定。 - **覆盖度全面**：测试用例覆盖了多种边界情况（空值、超长字符串、非法JSON、中英文混合、不同标点符号格式），有助于提高代码健壮性。 - **副作用检查**：包含 `test_asset_dict_not_mutated` 测试，验证了函数未修改输入参数，符合纯函数/无副作用的最佳实践。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-29 05:52:21 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-29 14:28:35 +08:00
gitea-actions bot commented 2026-07-29 14:32:21 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1132 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1132 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 52s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m12s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m28s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m15s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m27s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m18s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m10s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m18s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m37s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m49s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 6s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 36m21s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 37s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1132
Delete Branch "test/wave178-ai-parsing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?