xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

test(wave174): tts_job TTS任务配置 +60测 #1136

Closed
xiaoxia wants to merge 1 commits from test/wave174-tts-job into develop
pull from: test/wave174-tts-job
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 1
+502
xiaoxia commented 2026-07-29 13:47:07 +08:00
Owner
Copy Link
Copy Source

wave174: tts_job TTS任务配置单测

  • 模块：domain/tts_job.py
  • 新增测试：60个
  • 覆盖：TTS任务状态、参数校验、语速音调配置等纯逻辑
  • 本地验证：ruff + black + pytest 全绿
## wave174: tts_job TTS任务配置单测 - 模块：domain/tts_job.py - 新增测试：60个 - 覆盖：TTS任务状态、参数校验、语速音调配置等纯逻辑 - 本地验证：ruff + black + pytest 全绿
xiaoxia added 1 commit 2026-07-29 13:47:07 +08:00
test(wave174): tts_job TTS任务领域模型 +60测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 15s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m43s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 38s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m22s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m36s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 53s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m48s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m22s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m27s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m46s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m6s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m6s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m58s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 12s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 21m34s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 28s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 40s
Details
ad66a59f58
auto-approve-bot commented 2026-07-29 14:09:29 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：2 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

  1. [tests/unit/domain/test_tts_job.py: 336] 测试中使用 time.sleep 影响性能

    • 具体内容：在 test_transition_updates_updated_at 方法中使用了 time.sleep(0.01) 来等待时间流逝。这会人为拖慢单元测试的执行速度，违反了单元测试“快速执行”的原则。建议使用 unittest.mock 来替换 datetime 或相关时间获取函数，从而在测试中可控地推进时间。

  2. [tests/unit/domain/test_tts_job.py: 169] 依赖系统时间可能导致测试不稳定

    • 具体内容：在 test_create_sets_created_at 中，通过获取当前时间 before 和 after 来断言 created_at 的范围。这种测试方式依赖于系统时钟的精度和执行速度，存在极低概率的竞态条件风险（例如在时间边界跳动时执行）。建议使用 Mock 对象固定时间，确保测试结果的确定性和稳定性。

✅ 良好实践

  • 测试覆盖面非常全面，涵盖了正常流程、边界条件（如空值、超长文本、最大重试次数）以及异常情况。
  • 测试用例命名清晰，能够准确反映测试意图。
  • 使用了 try...except...else 结构显式验证异常抛出，逻辑严密。

✅ 格式检查通过 | ✅ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-29 06:09:29 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：2 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 1. **[tests/unit/domain/test_tts_job.py: 336] 测试中使用 time.sleep 影响性能** - 具体内容：在 `test_transition_updates_updated_at` 方法中使用了 `time.sleep(0.01)` 来等待时间流逝。这会人为拖慢单元测试的执行速度，违反了单元测试“快速执行”的原则。建议使用 `unittest.mock` 来替换 `datetime` 或相关时间获取函数，从而在测试中可控地推进时间。 2. **[tests/unit/domain/test_tts_job.py: 169] 依赖系统时间可能导致测试不稳定** - 具体内容：在 `test_create_sets_created_at` 中，通过获取当前时间 `before` 和 `after` 来断言 `created_at` 的范围。这种测试方式依赖于系统时钟的精度和执行速度，存在极低概率的竞态条件风险（例如在时间边界跳动时执行）。建议使用 Mock 对象固定时间，确保测试结果的确定性和稳定性。 ### ✅ 良好实践 - 测试覆盖面非常全面，涵盖了正常流程、边界条件（如空值、超长文本、最大重试次数）以及异常情况。 - 测试用例命名清晰，能够准确反映测试意图。 - 使用了 `try...except...else` 结构显式验证异常抛出，逻辑严密。 --- ✅ 格式检查通过 | ✅ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-29 06:09:29 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-29 14:09:45 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1136
预览链接 https://pr-1136.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1136 | | 预览链接 | [https://pr-1136.preview.xiaoxiajianji.com](https://pr-1136.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-07-29 14:29:53 +08:00
gitea-actions bot commented 2026-07-29 14:32:53 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1136 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1136 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 15s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m43s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 38s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m22s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m36s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 53s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m48s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m22s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m27s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m46s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m6s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m6s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m58s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 12s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 21m34s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 28s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 40s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1136
Delete Branch "test/wave174-tts-job"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?