xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(#1341): 解耦封面类型定义，独立于 editing-planner + 修复 confirm 路径和 AI 超时 #1352

Closed
xiaoxia wants to merge 1 commits from refactor/decouple-cover-types-from-editing-planner into develop
pull from: refactor/decouple-cover-types-from-editing-planner
merge into: xiaoxia:develop
Conversation 2 Commits 1 Files Changed 18
+18 -20
xiaoxia commented 2026-08-13 00:57:24 +08:00
Owner
Copy Link
Copy Source

修改内容

1. 封面类型解耦

  • 新建 generate/types/cover.ts：智能剪辑封面类型独立定义（CoverMode, CoverConfig, DEFAULT_COVER_CONFIG, CoverTemplate）
  • 修改 14 个文件：import 路径从 editing-planner/types → generate/types/cover
  • 删除 editing-planner/types/cover.ts
  • 清理 editing-planner/types/index.ts：移除封面相关 export

2. 修复 confirm.ts API 路径

  • /tasks/${taskId}/confirm → /generation/tasks/${taskId}/confirm

3. 修复 aiFeatures.ts 超时

  • timeout: 180000 → 300000（封面生成涉及 MediaKit 抽帧，需要更长时间）

修改文件清单（18 个）

文件 改动
generate/types/cover.ts 新建（从 editing-planner 迁移）
editing-planner/types/cover.ts 删除
editing-planner/types/index.ts 移除 cover export
hooks/useStep6Cover.ts import 路径
hooks/useStep7Generate.ts import 路径
hooks/useGenerateFormState/index.ts import 路径
hooks/useGenerateFormState/useTitleCoverSync.ts import 路径
hooks/useGenerateFormState/usePlanConfigLoader.ts import 路径
hooks/generate-video/types.ts import 路径
constants.ts import 路径
components/Step6CoverSettings.tsx import 路径
components/Step7ConfirmGenerate.tsx import 路径
components/GenerateStepContent.tsx import 路径
components/cover-settings/CoverModeSelector.tsx import 路径
components/cover-settings/CoverSettingsModal.tsx import 路径
components/cover-settings/CoverEditorModal.tsx import 路径
api/cover-templates.ts import 路径
api/generation/confirm.ts API 路径修复
api/template-editor/aiFeatures.ts timeout 180s→300s

验证

  • tsc --noEmit 零错误
  • prettier 格式化通过
  • CI 全绿
## 修改内容 ### 1. 封面类型解耦 - **新建** `generate/types/cover.ts`：智能剪辑封面类型独立定义（CoverMode, CoverConfig, DEFAULT_COVER_CONFIG, CoverTemplate） - **修改 14 个文件**：import 路径从 `editing-planner/types` → `generate/types/cover` - **删除** `editing-planner/types/cover.ts` - **清理** `editing-planner/types/index.ts`：移除封面相关 export ### 2. 修复 confirm.ts API 路径 - `/tasks/${taskId}/confirm` → `/generation/tasks/${taskId}/confirm` ### 3. 修复 aiFeatures.ts 超时 - timeout: 180000 → 300000（封面生成涉及 MediaKit 抽帧，需要更长时间） ## 修改文件清单（18 个） | 文件 | 改动 | |------|------| | `generate/types/cover.ts` | 新建（从 editing-planner 迁移） | | `editing-planner/types/cover.ts` | 删除 | | `editing-planner/types/index.ts` | 移除 cover export | | `hooks/useStep6Cover.ts` | import 路径 | | `hooks/useStep7Generate.ts` | import 路径 | | `hooks/useGenerateFormState/index.ts` | import 路径 | | `hooks/useGenerateFormState/useTitleCoverSync.ts` | import 路径 | | `hooks/useGenerateFormState/usePlanConfigLoader.ts` | import 路径 | | `hooks/generate-video/types.ts` | import 路径 | | `constants.ts` | import 路径 | | `components/Step6CoverSettings.tsx` | import 路径 | | `components/Step7ConfirmGenerate.tsx` | import 路径 | | `components/GenerateStepContent.tsx` | import 路径 | | `components/cover-settings/CoverModeSelector.tsx` | import 路径 | | `components/cover-settings/CoverSettingsModal.tsx` | import 路径 | | `components/cover-settings/CoverEditorModal.tsx` | import 路径 | | `api/cover-templates.ts` | import 路径 | | `api/generation/confirm.ts` | API 路径修复 | | `api/template-editor/aiFeatures.ts` | timeout 180s→300s | ## 验证 - [x] tsc --noEmit 零错误 - [x] prettier 格式化通过 - [ ] CI 全绿
xiaoxia added 1 commit 2026-08-13 00:57:25 +08:00
refactor(#1341): 解耦封面类型定义，独立于 editing-planner + 修复 confirm 路径和 AI 超时
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 54s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m15s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m34s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m50s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m53s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m24s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m21s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m14s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m27s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m0s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 1m2s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m26s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 47s
Details
f1d485fba7 
- 新建 generate/types/cover.ts，智能剪辑封面类型独立定义
- 14 个文件的 CoverConfig/CoverMode/CoverTemplate import 改到新路径
- 删除 editing-planner/types/cover.ts，移除 index.ts 封面 export
- 修复 confirm.ts API 路径: /tasks/{id}/confirm → /generation/tasks/{id}/confirm
- 修复 aiFeatures.ts timeout: 180s → 300s
auto-approve-bot commented 2026-08-13 01:00:52 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1352

⚠️ 问题（0个需要修改）

无

💡 建议（2个可选）

  1. apps/web/src/api/generation/confirm.ts 第10行：API 路径变更风险

    • 具体内容：代码将 API 路径从 /tasks/${taskId}/confirm 修改为 /generation/tasks/${taskId}/confirm。这属于功能性变更，请确保后端接口已同步更新并部署，否则会导致线上请求 404 错误。建议此类接口变更与后端 PR 关联或分阶段上线。

  2. apps/web/src/pages/editing-planner/types/index.ts 第74-77行：类型导出移除的兼容性检查

    • 具体内容：代码移除了 CoverMode, CoverConfig 等类型的导出。由于原类型文件已被移动至 generate 模块，请务必确认 editing-planner 模块内部（或其他引用该模块的代码）不再依赖这些导出的类型，否则会导致 editing-planner 模块编译失败或运行时错误。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-08-12 17:00:52 | 模型:

## 代码审查结果 - PR #1352 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（2个可选） 1. **apps/web/src/api/generation/confirm.ts 第10行**：API 路径变更风险 - 具体内容：代码将 API 路径从 `/tasks/${taskId}/confirm` 修改为 `/generation/tasks/${taskId}/confirm`。这属于功能性变更，请确保后端接口已同步更新并部署，否则会导致线上请求 404 错误。建议此类接口变更与后端 PR 关联或分阶段上线。 2. **apps/web/src/pages/editing-planner/types/index.ts 第74-77行**：类型导出移除的兼容性检查 - 具体内容：代码移除了 `CoverMode`, `CoverConfig` 等类型的导出。由于原类型文件已被移动至 `generate` 模块，请务必确认 `editing-planner` 模块内部（或其他引用该模块的代码）不再依赖这些导出的类型，否则会导致 `editing-planner` 模块编译失败或运行时错误。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-12 17:00:52 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-08-13 01:01:34 +08:00
gitea-actions bot commented 2026-08-13 01:02:35 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1352 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1352 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 54s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m15s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m34s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m50s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m53s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m24s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m21s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m14s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m27s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m0s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 1m2s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m26s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 47s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1352
Delete Branch "refactor/decouple-cover-types-from-editing-planner"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?