xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(test): 修复 test_confirm_generation.py 中 confirm API 路径 #1355

Merged
auto-approve-bot merged 1 commits from fix/test-confirm-generation-api-path into develop 2026-08-13 15:31:00 +08:00
Conversation 5 Commits 1 Files Changed 1
+11 -11
xiaoxia commented 2026-08-13 15:13:26 +08:00
Owner
Copy Link
Copy Source

问题

tests/unit/test_confirm_generation.py 中的 confirm API 路径仍然是旧的 /api/v1/tasks/{task_id}/confirm，但实际路由已迁移到 /api/v1/generation/tasks/{task_id}/confirm。

修复

  • 更新 test fixture 的 router prefix: /api/v1 → /api/v1/generation
  • 更新 9 个测试用例的 URL 路径
  • 更新 docstring 中的端点路径描述

测试

9/9 单测全部通过

## 问题 `tests/unit/test_confirm_generation.py` 中的 confirm API 路径仍然是旧的 `/api/v1/tasks/{task_id}/confirm`，但实际路由已迁移到 `/api/v1/generation/tasks/{task_id}/confirm`。 ## 修复 - 更新 test fixture 的 router prefix: `/api/v1` → `/api/v1/generation` - 更新 9 个测试用例的 URL 路径 - 更新 docstring 中的端点路径描述 ## 测试 9/9 单测全部通过
xiaoxia added 1 commit 2026-08-13 15:13:26 +08:00
fix(test): correct confirm API path in test_confirm_generation.py
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1m1s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m5s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m15s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m37s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m14s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 4m12s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 8m7s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m23s
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 38s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 51s
Details
23be99d9dd 
Route was moved to /api/v1/generation/tasks/{task_id}/confirm but
test file still used /api/v1/tasks/{task_id}/confirm, causing 404.

- Updated app fixture prefix from /api/v1 to /api/v1/generation
- Updated all 9 test URLs to use /api/v1/generation/tasks/ path
- Updated docstring to reflect correct endpoint path
auto-approve-bot commented 2026-08-13 15:15:45 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. 文档同步更新：在修改代码的同时更新了文件头部的文档字符串，确保了文档与实际测试覆盖的端点路径一致。
  2. 修改一致性：所有涉及路径变更的测试用例（包括正常流程和错误流程）均已同步更新，覆盖全面，没有遗漏。
  3. Fixture 调整准确：准确调整了 app fixture 中的路由前缀，确保测试环境与预期的路由配置匹配。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-13 07:15:45 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **文档同步更新**：在修改代码的同时更新了文件头部的文档字符串，确保了文档与实际测试覆盖的端点路径一致。 2. **修改一致性**：所有涉及路径变更的测试用例（包括正常流程和错误流程）均已同步更新，覆盖全面，没有遗漏。 3. **Fixture 调整准确**：准确调整了 `app` fixture 中的路由前缀，确保测试环境与预期的路由配置匹配。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-13 07:15:45 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-13 15:17:13 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1355
预览链接 https://pr-1355.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1355 | | 预览链接 | [https://pr-1355.preview.xiaoxiajianji.com](https://pr-1355.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-13 15:25:32 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-13 15:25:32 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 0529c61347 into develop 2026-08-13 15:31:00 +08:00
auto-approve-bot deleted branch fix/test-confirm-generation-api-path 2026-08-13 15:31:00 +08:00
gitea-actions bot commented 2026-08-13 15:31:38 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1355 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1355 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1355
Delete Branch "fix/test-confirm-generation-api-path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?