xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 1 Packages Projects Releases 7 Wiki Activity

fix: 恢复PR#1386误删的showTitlePreview属性声明，修复TS编译错误 #1388

Closed
xiaoxia wants to merge 7 commits from fix/restore-showTitlePreview-prop into develop
pull from: fix/restore-showTitlePreview-prop
merge into: xiaoxia:develop
Conversation 5 Commits 7 Files Changed 2
+4 -2
xiaoxia commented 2026-08-16 10:14:00 +08:00
Owner
Copy Link
Copy Source

问题

PR #1386 删除了 showTitlePreview 的接口声明和 props 解构，但组件内部仍有 16 处使用该变量，导致 Docker build 中 tsc 编译失败（TS2304: Cannot find name showTitlePreview）。

修复

  1. PreviewVideoPanel.tsx: 恢复 showTitlePreview?: boolean 接口声明和 props 解构
  2. GeneratePage.tsx: 恢复传递 showTitlePreview={currentStep === 4} prop

影响

  • 修复 Web Image 构建失败的 TS 编译错误
  • Step4 显示标题预览、Step5+ 显示预览视频的逻辑恢复正常
## 问题 PR #1386 删除了 `showTitlePreview` 的接口声明和 props 解构，但组件内部仍有 16 处使用该变量，导致 Docker build 中 tsc 编译失败（TS2304: Cannot find name showTitlePreview）。 ## 修复 1. **PreviewVideoPanel.tsx**: 恢复 `showTitlePreview?: boolean` 接口声明和 props 解构 2. **GeneratePage.tsx**: 恢复传递 `showTitlePreview={currentStep === 4}` prop ## 影响 - 修复 Web Image 构建失败的 TS 编译错误 - Step4 显示标题预览、Step5+ 显示预览视频的逻辑恢复正常
xiaoxia added 3 commits 2026-08-16 10:14:00 +08:00
fix: restore showTitlePreview prop removed by PR#1386 7753a70853
fix: restore showTitlePreview prop removed by PR#1386 79223863f1
fix: restore showTitlePreview prop in GeneratePage
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 29s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m17s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m22s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m35s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m25s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 53s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m1s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m12s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m25s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m32s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m25s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 7s
Details
e45d1e99c7
xiaoxia added 1 commit 2026-08-16 10:18:37 +08:00
fix: add showTitlePreview to useCallback dependency array
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 34s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m5s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m24s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m27s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m1s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m45s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m54s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m47s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m28s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m21s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m12s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 6s
Details
b1cb929f94
xiaoxia added 1 commit 2026-08-16 10:24:15 +08:00
fix: restore showTitlePreview prop + fix dependency array
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
Details
AI Code Review / AI Code Review (pull_request) Has been cancelled
Details
PR Automation / Auto Approve on CI Green (pull_request) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been cancelled
Details
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
Details
57651843fe
xiaoxia added 1 commit 2026-08-16 10:24:28 +08:00
fix: remove duplicate imports + restore showTitlePreview prop
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 31s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m18s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m32s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m15s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m49s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m36s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m11s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m11s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m33s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m23s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m46s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 5s
Details
51dbc8c3b7
gitea-actions bot commented 2026-08-16 10:27:03 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1388
预览链接 https://pr-1388.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1388 | | 预览链接 | [https://pr-1388.preview.xiaoxiajianji.com](https://pr-1388.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-08-16 10:28:29 +08:00
fix: remove unnecessary showTitlePreview from useCallback deps
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 43s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m40s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m8s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m6s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m31s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m8s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m56s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m30s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m11s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Failing after 11m13s
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 10s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 40s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 51s
Details
fa1390c005
auto-approve-bot commented 2026-08-16 10:30:35 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. 清理未使用代码：GeneratePage.tsx 中移除了不再使用的 useQuery 和 getAssetsByKind 导入，保持了代码的整洁。
  2. 接口定义规范：PreviewVideoPanel.tsx 中为新增的 showTitlePreview 属性添加了清晰的 JSDoc 注释，提升了代码可读性。
  3. 向后兼容性：showTitlePreview 被定义为可选属性 (?)，确保了该组件在其他未传递该参数的场景下仍能正常工作，符合最小惊讶原则。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-08-16 02:30:35 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **清理未使用代码**：`GeneratePage.tsx` 中移除了不再使用的 `useQuery` 和 `getAssetsByKind` 导入，保持了代码的整洁。 2. **接口定义规范**：`PreviewVideoPanel.tsx` 中为新增的 `showTitlePreview` 属性添加了清晰的 JSDoc 注释，提升了代码可读性。 3. **向后兼容性**：`showTitlePreview` 被定义为可选属性 (`?`)，确保了该组件在其他未传递该参数的场景下仍能正常工作，符合最小惊讶原则。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-16 02:30:35 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot approved these changes 2026-08-16 10:31:26 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-16 10:31:26 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
xiaoxia closed this pull request 2026-08-16 11:06:49 +08:00
gitea-actions bot commented 2026-08-16 11:07:39 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1388 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1388 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 43s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m40s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m8s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m6s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m31s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m8s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m56s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m30s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m11s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Failing after 11m13s
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 10s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 40s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 51s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1388
Delete Branch "fix/restore-showTitlePreview-prop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?