xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(e2e): update Step 5 heading for frontend preview architecture #1428

Merged
auto-approve-bot merged 1 commits from fix/e2e-step5-preview-heading into develop 2026-08-18 21:26:00 +08:00
Conversation 6 Commits 1 Files Changed 1
+2 -6
xiaoxia commented 2026-08-18 21:12:17 +08:00
Owner
Copy Link
Copy Source

问题

Staging E2E Tests（Run #33142）失败：core-generation.spec.ts:218 等待 heading 生成预览 超时。

根因

Step 5 组件 Step5GeneratePreview.tsx 已随前端实时预览架构改造重构：

  • 旧： heading 生成预览 + .xx-preview-generate-btn 按钮 + 后端 FFmpeg 渲染
  • 新： heading 🎬 预览设置，无生成按钮，改为 PreviewVideoPanel 前端实时播放

测试用例未同步更新。

修复

更新 apps/web/e2e/core-generation.spec.ts Step 5 部分：

  • heading 匹配：/生成预览/ → /预览设置/
  • 移除 .xx-preview-generate-btn 点击和 预览生成成功 等待

关联

Fixes #1421

## 问题 Staging E2E Tests（Run #33142）失败：`core-generation.spec.ts:218` 等待 heading `生成预览` 超时。 ## 根因 Step 5 组件 `Step5GeneratePreview.tsx` 已随前端实时预览架构改造重构： - **旧：** heading `生成预览` + `.xx-preview-generate-btn` 按钮 + 后端 FFmpeg 渲染 - **新：** heading `🎬 预览设置`，无生成按钮，改为 `PreviewVideoPanel` 前端实时播放 测试用例未同步更新。 ## 修复 更新 `apps/web/e2e/core-generation.spec.ts` Step 5 部分： - heading 匹配：`/生成预览/` → `/预览设置/` - 移除 `.xx-preview-generate-btn` 点击和 `预览生成成功` 等待 ## 关联 Fixes #1421
xiaoxia added 1 commit 2026-08-18 21:12:17 +08:00
fix(e2e): update Step 5 heading for frontend preview architecture
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 43s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 46s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m39s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m57s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m19s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m49s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m57s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m19s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 8m34s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 41s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 44s
Details
b7d67234f9 
Step 5 was refactored from backend FFmpeg preview generation to
frontend real-time preview (PreviewVideoPanel). The heading changed
from '生成预览' to '🎬 预览设置' and the .xx-preview-generate-btn
no longer exists. Update the E2E test to match the new UI.

Fixes: Staging E2E Tests failure in Run #33142
Fixes #1421
auto-approve-bot commented 2026-08-18 21:13:31 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. 注释清晰：代码注释准确说明了架构变更的原因（从“后端生成”改为“前端实时预览”），有助于后续维护理解业务逻辑的演变。
  2. 提升测试效率：移除了长达 300 秒的等待逻辑，显著减少了 E2E 测试的执行时间，提高了 CI/CD 流程的效率。
  3. 选择器规范：继续使用 getByRole 等语义化定位器，保持了测试代码的稳健性和可维护性。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-18 13:13:31 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **注释清晰**：代码注释准确说明了架构变更的原因（从“后端生成”改为“前端实时预览”），有助于后续维护理解业务逻辑的演变。 2. **提升测试效率**：移除了长达 300 秒的等待逻辑，显著减少了 E2E 测试的执行时间，提高了 CI/CD 流程的效率。 3. **选择器规范**：继续使用 `getByRole` 等语义化定位器，保持了测试代码的稳健性和可维护性。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-18 13:13:31 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-18 21:14:13 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1428
预览链接 https://pr-1428.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1428 | | 预览链接 | [https://pr-1428.preview.xiaoxiajianji.com](https://pr-1428.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-18 21:14:24 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-18 21:14:24 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
xiaoxia commented 2026-08-18 21:21:22 +08:00
Author
Owner
Copy Link
Copy Source

✅ CI 全绿

Run #33153 (ci-pipeline):

  • Code Quality ✅ | mypy ✅ | alembic ✅
  • Frontend Lint ✅ | Frontend Unit Tests ✅ | PR Build Web Image ✅ | CI Gate ✅

根因： Step 5 组件从"生成预览"（后端 FFmpeg）重构为"预览设置"（前端实时预览），E2E 测试用例未同步更新。

修复： 更新 heading 匹配 + 移除已不存在的生成按钮点击。

请 review。

## ✅ CI 全绿 **Run #33153 (ci-pipeline):** - Code Quality ✅ | mypy ✅ | alembic ✅ - Frontend Lint ✅ | Frontend Unit Tests ✅ | PR Build Web Image ✅ | CI Gate ✅ **根因：** Step 5 组件从"生成预览"（后端 FFmpeg）重构为"预览设置"（前端实时预览），E2E 测试用例未同步更新。 **修复：** 更新 heading 匹配 + 移除已不存在的生成按钮点击。 请 review。
auto-approve-bot merged commit 122e9aaa86 into develop 2026-08-18 21:26:00 +08:00
auto-approve-bot deleted branch fix/e2e-step5-preview-heading 2026-08-18 21:26:00 +08:00
gitea-actions bot commented 2026-08-18 21:26:44 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1428 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1428 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1428
Delete Branch "fix/e2e-step5-preview-heading"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?