xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 15 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: 配音时长过滤 + 移除时长警告 UI #1692

Merged
auto-approve-bot merged 1 commits from fix/voice-duration-filter-and-warning-removal into develop 2026-09-04 16:09:47 +08:00
Conversation 5 Commits 1 Files Changed 2
+26 -96
xiaoxia commented 2026-09-04 16:01:40 +08:00
Owner
Copy Link
Copy Source

变更内容

1. 配音列表按时长过滤

  • 只保留 0.9 ≤ audio_duration / video_total_duration ≤ 1.1 的配音
  • AI 音色（无固定时长）始终保留
  • 过滤后底部提示"已根据视频时长自动过滤时长差异过大的配音"

2. 移除"配音时长不足"弹窗

  • 删除 Modal 及其 state（durationWarningOpen / pendingVoiceId）
  • 选中配音直接生效，不再弹确认

3. 移除"⚠ 时长不足"标签

  • 配音卡片不再显示红色时长不足标记

4. 模板时长字段

  • Step1TemplateSelect 卡片移除 estimated_duration 显示，只保留片段数

影响文件

  • apps/web/src/pages/generate/components/Step5VoiceSelect.tsx
  • apps/web/src/pages/generate/components/Step1TemplateSelect.tsx
## 变更内容 ### 1. 配音列表按时长过滤 - 只保留 `0.9 ≤ audio_duration / video_total_duration ≤ 1.1` 的配音 - AI 音色（无固定时长）始终保留 - 过滤后底部提示"已根据视频时长自动过滤时长差异过大的配音" ### 2. 移除"配音时长不足"弹窗 - 删除 Modal 及其 state（durationWarningOpen / pendingVoiceId） - 选中配音直接生效，不再弹确认 ### 3. 移除"⚠ 时长不足"标签 - 配音卡片不再显示红色时长不足标记 ### 4. 模板时长字段 - Step1TemplateSelect 卡片移除 `estimated_duration` 显示，只保留片段数 ## 影响文件 - `apps/web/src/pages/generate/components/Step5VoiceSelect.tsx` - `apps/web/src/pages/generate/components/Step1TemplateSelect.tsx`
xiaoxia added 1 commit 2026-09-04 16:01:40 +08:00
fix: 配音时长过滤 + 移除时长警告 UI
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
Details
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m58s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m4s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m6s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 2m11s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m9s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 2m34s
Details
AI Code Review / AI Code Review (pull_request) Successful in 5m21s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 7m14s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 3s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 6m14s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 11s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 38s
Details
a10d8b7ae0 
- Step5VoiceSelect: 自动过滤时长差异>±10%的配音，AI音色始终保留
- Step5VoiceSelect: 移除'配音时长不足'弹窗及相关状态
- Step5VoiceSelect: 移除'⚠ 时长不足'警告标签
- Step5VoiceSelect: 选中配音直接生效，不再弹窗确认
- Step1TemplateSelect: 模板卡片移除estimated_duration显示
- 过滤后如有被隐藏的素材，底部提示用户
gitea-actions bot commented 2026-09-04 16:03:44 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1692
预览链接 https://pr-1692.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1692 | | 预览链接 | [https://pr-1692.preview.xiaoxiajianji.com](https://pr-1692.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-09-04 16:03:46 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-09-04 16:03:46 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot commented 2026-09-04 16:06:59 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1692

⚠️ 问题（2个需要修改）

  1. apps/web/src/pages/generate/components/Step5VoiceSelect.tsx 第60行：totalVideoDuration 类型为 number | undefined，当其为 undefined 时，判断 totalVideoDuration <= 0 结果为 false。代码会继续执行除法运算导致 ratio 为 NaN，进而导致所有非 AI 配音被错误过滤掉（不可见）。
  2. apps/web/src/pages/generate/components/Step5. VoiceSelect.tsx 第66行：逻辑回归问题。代码将 duration <= 0（无效时长）的文件视为符合时长要求（return true）。旧代码会对这些文件弹出警告，新代码则将其作为有效文件展示且无任何提示，可能导致用户选择无效或损坏的音频素材。

💡 建议（1个可选）

  1. apps/web/src/pages/generate/components/Step5VoiceSelect.tsx：过滤阈值的硬编码（0.9 和 1.1）建议提取为常量（如 DURATION_TOLERANCE = 0.1），提高代码可维护性。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-09-04 08:06:59 | 模型:

## 代码审查结果 - PR #1692 ### ⚠️ 问题（2个需要修改） 1. **apps/web/src/pages/generate/components/Step5VoiceSelect.tsx 第60行**：`totalVideoDuration` 类型为 `number | undefined`，当其为 `undefined` 时，判断 `totalVideoDuration <= 0` 结果为 `false`。代码会继续执行除法运算导致 `ratio` 为 `NaN`，进而导致所有非 AI 配音被错误过滤掉（不可见）。 2. **apps/web/src/pages/generate/components/Step5. VoiceSelect.tsx 第66行**：逻辑回归问题。代码将 `duration <= 0`（无效时长）的文件视为符合时长要求（`return true`）。旧代码会对这些文件弹出警告，新代码则将其作为有效文件展示且无任何提示，可能导致用户选择无效或损坏的音频素材。 ### 💡 建议（1个可选） 1. **apps/web/src/pages/generate/components/Step5VoiceSelect.tsx**：过滤阈值的硬编码（`0.9` 和 `1.1`）建议提取为常量（如 `DURATION_TOLERANCE = 0.1`），提高代码可维护性。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-09-04 08:06:59 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot merged commit 4263e7f6ca into develop 2026-09-04 16:09:47 +08:00
auto-approve-bot deleted branch fix/voice-duration-filter-and-warning-removal 2026-09-04 16:09:53 +08:00
gitea-actions bot commented 2026-09-04 16:10:38 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1692 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1692 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1692
Delete Branch "fix/voice-duration-filter-and-warning-removal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?