xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: 移除片段时长显示 + 点击加号直接添加 #1695

Open
xiaoxia wants to merge 1 commits from fix/voice-duration-filter-and-warning-removal into develop
pull from: fix/voice-duration-filter-and-warning-removal
merge into: xiaoxia:develop
Conversation 2 Commits 1 Files Changed 3
+6 -37
xiaoxia commented 2026-09-04 17:02:21 +08:00
Owner
Copy Link
Copy Source

变更

  1. 移除时长显示

    • 时间线卡片（ClipCard）不再显示 clip.duration
    • 右侧片段列表（EditorClipList）不再显示时长

  2. 点击加号直接添加片段

    • 移除 AddClipPicker 弹窗
    • 点击 "+" 直接以默认类型和默认时长添加片段
    • 清理未使用的变量和导入
## 变更 1. **移除时长显示** - 时间线卡片（ClipCard）不再显示 clip.duration - 右侧片段列表（EditorClipList）不再显示时长 2. **点击加号直接添加片段** - 移除 AddClipPicker 弹窗 - 点击 "+" 直接以默认类型和默认时长添加片段 - 清理未使用的变量和导入
gitea-actions bot commented 2026-09-04 17:04:22 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1695
预览链接 https://pr-1695.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1695 | | 预览链接 | [https://pr-1695.preview.xiaoxiajianji.com](https://pr-1695.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-09-04 17:30:39 +08:00
fix: 移除片段时长显示 + 点击加号直接添加片段
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
Details
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 1m18s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m23s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m42s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 2m4s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 2m5s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m7s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m15s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 2m31s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 5m2s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 2s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m56s
Details
5799abbca3 
- ClipCard: 移除时间线卡片上的 clip.duration 显示
- EditorClipList: 移除右侧片段列表的时长显示 + 删除未使用的 formatDuration
- TimelinePanel: 点击加号直接调用 handleConfirmAdd，移除 AddClipPicker 弹窗
- 清理未使用的变量: availableTypes, pickerRef, pickerPos, addType, setAddType, handleTogglePicker
xiaoxia force-pushed fix/voice-duration-filter-and-warning-removal from 10678adc10 to 5799abbca3 2026-09-04 17:30:39 +08:00 Compare
auto-approve-bot commented 2026-09-04 17:31:53 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：是
  • 阻塞级问题数量：1 个

📊 审查概览

  • 整体评价：需修改
  • 建议级问题：1 个

🔴 阻塞级问题（必须修复）

  1. [TimelinePanel.tsx: 169] 回调函数替换存在严重逻辑风险
    • 问题类型：逻辑bug
    • 问题描述：将 ClipTrack 组件的 onTogglePicker prop 从 handleTogglePicker 替换为 handleConfirmAdd。
      1. handleConfirmAdd 通常用于执行“添加”动作，往往依赖于具体的业务参数（如片段类型 addType、位置 pickerPos 等）。本次提交中从 TimelinePanel 移除了 addType、pickerPos 等 props，如果 handleConfirmAdd 内部闭包引用了这些变量，将导致运行时错误。
      2. handleTogglePicker 原本用于切换弹窗状态，通常无参调用。如果 ClipTrack 内部点击事件调用 onTogglePicker() 时未传递参数，而 handleConfirmAdd 期望接收参数，将导致函数调用失败或逻辑错误。
    • 修改建议：请检查 handle 函数的具体实现。如果 handleConfirmAdd 依赖已删除的状态变量，必须修复该函数逻辑或恢复相关变量。如果意图是点击直接添加，需确保 handleConfirmAdd 支持无参调用并使用合理的默认值。

💡 改进建议（不阻塞合并）

  1. [EditorClipList.tsx, ClipCard.tsx] 确认移除时长显示的意图
    • 具体内容：代码移除了 formatDuration 函数及其在 UI 中的调用，导致界面上不再显示片段时长。请确认这是符合预期的产品需求（如简化 UI），而非误删导致的信息缺失。

✅ 良好实践

  • 及时清理了不再使用的组件（AddClipPicker）和相关工具函数（formatDuration），保持了代码整洁。
  • 移除了不再需要的 props 传递，有助于简化组件结构。

🤖 由 AI 代码审查机器人自动生成 | 2026-09-04 09:31:52 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：是 - 阻塞级问题数量：1 个 ### 📊 审查概览 - 整体评价：需修改 - 建议级问题：1 个 ### 🔴 阻塞级问题（必须修复） 1. **[TimelinePanel.tsx: 169] 回调函数替换存在严重逻辑风险** - 问题类型：逻辑bug - 问题描述：将 `ClipTrack` 组件的 `onTogglePicker` prop 从 `handleTogglePicker` 替换为 `handleConfirmAdd`。 1. `handleConfirmAdd` 通常用于执行“添加”动作，往往依赖于具体的业务参数（如片段类型 `addType`、位置 `pickerPos` 等）。本次提交中从 `TimelinePanel` 移除了 `addType`、`pickerPos` 等 props，如果 `handleConfirmAdd` 内部闭包引用了这些变量，将导致运行时错误。 2. `handleTogglePicker` 原本用于切换弹窗状态，通常无参调用。如果 `ClipTrack` 内部点击事件调用 `onTogglePicker()` 时未传递参数，而 `handleConfirmAdd` 期望接收参数，将导致函数调用失败或逻辑错误。 - 修改建议：请检查 `handle` 函数的具体实现。如果 `handleConfirmAdd` 依赖已删除的状态变量，必须修复该函数逻辑或恢复相关变量。如果意图是点击直接添加，需确保 `handleConfirmAdd` 支持无参调用并使用合理的默认值。 ### 💡 改进建议（不阻塞合并） 1. **[EditorClipList.tsx, ClipCard.tsx] 确认移除时长显示的意图** - 具体内容：代码移除了 `formatDuration` 函数及其在 UI 中的调用，导致界面上不再显示片段时长。请确认这是符合预期的产品需求（如简化 UI），而非误删导致的信息缺失。 ### ✅ 良好实践 - 及时清理了不再使用的组件（`AddClipPicker`）和相关工具函数（`formatDuration`），保持了代码整洁。 - 移除了不再需要的 props 传递，有助于简化组件结构。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-09-04 09:31:52 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
Some checks are pending
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
Details
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Failing after 1m18s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m23s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m42s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 2m4s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 2m5s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m7s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m15s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 2m31s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 5m2s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 2s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m56s
Details
This pull request has changes conflicting with the target branch.
  • apps/web/src/pages/editing-planner/components/EditorClipList.tsx
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/voice-duration-filter-and-warning-removal:fix/voice-duration-filter-and-warning-removal
git checkout fix/voice-duration-filter-and-warning-removal
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1695
Delete Branch "fix/voice-duration-filter-and-warning-removal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?