xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 16 Pull Requests 12 Actions 34.2k Packages Projects Releases 7 Wiki Activity

chore(cover): 清理PreviewCountModal残留+修复批量finalize封面标题错配 #2048

Merged
auto-approve-bot merged 1 commits from fix/cleanup-previewcount-batchfinalize-20260926 into develop 2026-09-26 09:46:37 +08:00
Conversation 4 Commits 1 Files Changed 3
+7 -184
xiaoxia commented 2026-09-26 09:41:17 +08:00
Owner
Copy Link
Copy Source

背景

#2047 去掉Step2数量弹窗外，残留了 PreviewCountModal 组件、import、state（countModalOpen）、handleCountConfirm 回调和 JSX 渲染块没清理。另外批量finalize存在一个对齐bug。

改动

  1. 清理死代码（-177行）：
    • 删除 apps/web/src/pages/generate/components/PreviewCountModal.tsx
    • GeneratePage.tsx：移除 import、countModalOpen state、handleCountConfirm 回调、JSX 里的 <PreviewCountModal> 渲染
    • smoke.test.tsx：移除无意义的 PreviewCountModal import
  2. 修复批量finalize封面/标题错配：原代码 taskIds.map((taskId, idx) => previewCovers[idx]) 按 taskIds 数组下标取封面/标题，但 batchTasks 顺序不保证与 variantIndex 一致（重试、失败任务可能影响顺序），改为 batchTasks.map(task => previewCovers[task.variantIndex]) 按变体序号对齐

验证

tsc / eslint(max-warnings=0) / prettier 全过。

## 背景 #2047 去掉Step2数量弹窗外，残留了 PreviewCountModal 组件、import、state（countModalOpen）、handleCountConfirm 回调和 JSX 渲染块没清理。另外批量finalize存在一个对齐bug。 ## 改动 1. **清理死代码**（-177行）： - 删除 `apps/web/src/pages/generate/components/PreviewCountModal.tsx` - GeneratePage.tsx：移除 import、`countModalOpen` state、`handleCountConfirm` 回调、JSX 里的 `<PreviewCountModal>` 渲染 - smoke.test.tsx：移除无意义的 PreviewCountModal import 2. **修复批量finalize封面/标题错配**：原代码 `taskIds.map((taskId, idx) => previewCovers[idx])` 按 taskIds 数组下标取封面/标题，但 batchTasks 顺序不保证与 variantIndex 一致（重试、失败任务可能影响顺序），改为 `batchTasks.map(task => previewCovers[task.variantIndex])` 按变体序号对齐 ## 验证 tsc / eslint(max-warnings=0) / prettier 全过。
xiaoxia added 1 commit 2026-09-26 09:41:17 +08:00
chore(cover): 清理PreviewCountModal残留代码 + 修复批量finalize封面/标题错配
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
Details
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 1s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m40s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m53s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m58s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 2m26s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m24s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 3m4s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 4m32s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 1s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m22s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 31s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 36s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m32s
Details
fc1d285f41 
- 删除 PreviewCountModal 组件及 GeneratePage 中残留的 import/state/handleCountConfirm/JSX
- 删除 smoke.test.tsx 中无意义的 PreviewCountModal import
- 修复批量 finalize 时按 taskIds 数组下标取 previewCovers/previewTitles 的bug：
  batchTasks 顺序不保证与 variantIndex 一致，改为按 batchTasks[i].variantIndex 对齐封面和标题
gitea-actions bot commented 2026-09-26 09:43:07 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #2048
预览链接 https://pr-2048.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #2048 | | 预览链接 | [https://pr-2048.preview.xiaoxiajianji.com](https://pr-2048.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-09-26 09:43:15 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-09-26 09:43:15 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 44a98b8fcb into develop 2026-09-26 09:46:37 +08:00
auto-approve-bot deleted branch fix/cleanup-previewcount-batchfinalize-20260926 2026-09-26 09:46:40 +08:00
gitea-actions bot commented 2026-09-26 09:47:08 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #2048 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #2048 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot frontend-dev xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#2048
Delete Branch "fix/cleanup-previewcount-batchfinalize-20260926"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?