xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: 缩略图上传失败（upload_to_oss str/Path 类型不匹配） #602

Merged
auto-approve-bot merged 1 commits from fix/thumbnail-upload-str-path-bug into develop 2026-07-19 17:53:27 +08:00
Conversation 4 Commits 1 Files Changed 1
+3 -2
xiaoxia commented 2026-07-19 17:46:02 +08:00
Owner
Copy Link
Copy Source

问题

upload_to_oss 函数签名写的是 local_path: Path，但 thumbnail_generator.py 等调用方传的是 str，导致 local_path.stat() 报 AttributeError: 'str' object has no attribute 'stat'，缩略图上传失败返回 None，异常被吞掉不影响主流程但视频封面一直是默认图。

修复

  • 函数入参兼容 Path | str
  • 入口处统一 local_path = Path(local_path) 转 Path 对象
  • 其他传 Path 的调用方无副作用

影响面

仅缩略图上传链路修复，其他调用方（render_adapter、generation.py 等）传的是 Path 对象，转一下也没问题，无副作用。

## 问题 `upload_to_oss` 函数签名写的是 `local_path: Path`，但 `thumbnail_generator.py` 等调用方传的是 `str`，导致 `local_path.stat()` 报 `AttributeError: 'str' object has no attribute 'stat'`，缩略图上传失败返回 None，异常被吞掉不影响主流程但视频封面一直是默认图。 ## 修复 - 函数入参兼容 `Path | str` - 入口处统一 `local_path = Path(local_path)` 转 Path 对象 - 其他传 Path 的调用方无副作用 ## 影响面 仅缩略图上传链路修复，其他调用方（render_adapter、generation.py 等）传的是 Path 对象，转一下也没问题，无副作用。
xiaoxia added 1 commit 2026-07-19 17:46:03 +08:00
fix: 缩略图上传失败（upload_to_oss str/Path 类型不匹配）
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 25s
Details
AI Code Review / AI Code Review (pull_request) Failing after 41s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 35s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 3m6s
Details
Auto Approve CI PRs / Auto Approve on CI Green (pull_request) Successful in 4m40s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m36s
Details
Auto Merge CI PRs / Auto Merge on CI Green + Approved (pull_request) Successful in 7m24s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 8s
Details
d2a8aa1173 
thumbnail_generator.py 等调用方传 str 类型路径，upload_to_oss 函数签名
写的是 Path，导致 local_path.stat() 报 AttributeError，缩略图上传失败
返回 None，异常被吞掉不影响主流程但封面一直是默认图。

修复：函数入参兼容 Path | str，入口处统一转 Path 对象。
其他传 Path 的调用方无副作用。
xiaoxia reviewed 2026-07-19 17:46:56 +08:00
xiaoxia left a comment
Author
Owner
Copy Link
Copy Source

LGTM，一行修复，str/Path 类型兼容，无副作用。

LGTM，一行修复，str/Path 类型兼容，无副作用。
auto-approve-bot approved these changes 2026-07-19 17:50:43 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-19 17:50:43 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 6e392ca4a6 into develop 2026-07-19 17:53:27 +08:00
auto-approve-bot deleted branch fix/thumbnail-upload-str-path-bug 2026-07-19 17:53:27 +08:00
gitea-actions bot commented 2026-07-19 17:53:35 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #602 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #602 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#602
Delete Branch "fix/thumbnail-upload-str-path-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?