fix(ci): 修复auto-fix在tarball checkout模式下git不可用的问题 #629

Merged
auto-approve-bot merged 4 commits from fix/ci-autofix-git-repo into develop 2026-07-20 12:27:32 +08:00
Owner

问题

Checkout脚本(step_checkout.sh)使用tarball方式下载代码,没有.git目录。导致auto_fix_formatting.py中的git status命令失败,自动格式化修复功能完全不可用。

修复

auto_fix_formatting.py中新增ensure_git_repo()函数:

  • 检测到当前目录不是git仓库时,自动执行git init
  • 配置带token认证的remote
  • fetch PR源分支并checkout
  • tarball内容与PR HEAD完全一致,checkout后工作区为clean状态

影响

  • auto-fix功能从「完全不可用」恢复正常
  • 不改变checkout方式(tarball比git clone更快更稳定)
  • 仅在需要auto-fix时才初始化git,不影响正常CI流程

关联:#619 CI稳定性全面根治

## 问题 Checkout脚本(`step_checkout.sh`)使用tarball方式下载代码,没有`.git`目录。导致`auto_fix_formatting.py`中的`git status`命令失败,自动格式化修复功能完全不可用。 ## 修复 在`auto_fix_formatting.py`中新增`ensure_git_repo()`函数: - 检测到当前目录不是git仓库时,自动执行`git init` - 配置带token认证的remote - fetch PR源分支并checkout - tarball内容与PR HEAD完全一致,checkout后工作区为clean状态 ## 影响 - auto-fix功能从「完全不可用」恢复正常 - 不改变checkout方式(tarball比git clone更快更稳定) - 仅在需要auto-fix时才初始化git,不影响正常CI流程 关联:#619 CI稳定性全面根治
xiaoxia added 1 commit 2026-07-20 11:30:27 +08:00
fix(ci): 修复auto-fix在tarball checkout模式下git不可用的问题
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 18s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m9s
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Failing after 1m13s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m39s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m30s
AI Code Review / AI Code Review (pull_request) Successful in 3m34s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m18s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 5m47s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m50s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
1e68045510

🚀 预览环境已部署

项目 详情
PR号 #629
预览链接 https://pr-629.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #629 | | 预览链接 | [https://pr-629.preview.xiaoxiajianji.com](https://pr-629.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
xiaoxia added 1 commit 2026-07-20 11:43:16 +08:00
fix(ci): 修复auto-fix git初始化方式,避免tarball文件与checkout冲突
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 12s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m37s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Failing after 2m59s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m18s
AI Code Review / AI Code Review (pull_request) Successful in 4m37s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 5m27s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m21s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 8m11s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m49s
8286a46d90
Collaborator

代码审查结果 - PR #629

⚠️ 问题(2个需要修改)

  1. scripts/ci/auto_fix_formatting.py 第33行:敏感信息泄露风险。代码将包含 token 的完整 URL 直接通过 git remote add origin 写入 git 配置文件。这会导致 token 明文存储在 .git/config 中,如果后续脚本执行 git config --list 或打印该文件,token 将泄露。此外,进程列表(如 ps)也可能捕获该参数。建议仅添加不带认证信息的 remote,在 fetch 时临时使用带 token 的 URL,或利用 git credential helper
  2. scripts/ci/auto_fix_formatting.py 第36-38行:缺少网络请求异常处理。urllib.request.urlopen 可能会因网络波动、API 限流或认证失败抛出 URLError/HTTPErrorjson.loads 可能因响应格式错误抛出 JSONDecodeError。当前代码未捕获这些异常,会导致脚本直接崩溃并抛出堆栈信息,不利于 CI 排错。建议增加 try-except 块捕获异常并打印友好的错误日志。

💡 建议(1个可选)

  1. scripts/ci/auto_fix_formatting.py 第48-50行:存在并发竞态风险。脚本获取 PR 的 head ref 进行 fetch,但工作区内容来自 tarball。如果在 CI 启动下载 tarball 与脚本执行 fetch 之间,PR 被推送了新的提交,会导致 FETCH_HEAD 指向新的 commit,而工作区是旧代码。随后的 git read-tree 会导致工作区被视为“回退”状态,最终 commit 可能会意外覆盖他人的更新。建议 CI 环境传入具体的 commit SHA,而非动态获取分支 HEAD;或者确认 CI 平台在运行期间会锁定 PR。

格式检查通过 | 逻辑审查需修改 | 性能良好


🤖 由 AI 代码审查机器人自动生成 | 2026-07-20 11:47:53 | 模型:

## 代码审查结果 - PR #629 ### ⚠️ 问题(2个需要修改) ) 1. **scripts/ci/auto_fix_formatting.py 第33行**:敏感信息泄露风险。代码将包含 `token` 的完整 URL 直接通过 `git remote add origin` 写入 git 配置文件。这会导致 token 明文存储在 `.git/config` 中,如果后续脚本执行 `git config --list` 或打印该文件,token 将泄露。此外,进程列表(如 `ps`)也可能捕获该参数。建议仅添加不带认证信息的 remote,在 fetch 时临时使用带 token 的 URL,或利用 `git credential helper`。 2. **scripts/ci/auto_fix_formatting.py 第36-38行**:缺少网络请求异常处理。`urllib.request.urlopen` 可能会因网络波动、API 限流或认证失败抛出 `URLError`/`HTTPError`,`json.loads` 可能因响应格式错误抛出 `JSONDecodeError`。当前代码未捕获这些异常,会导致脚本直接崩溃并抛出堆栈信息,不利于 CI 排错。建议增加 `try-except` 块捕获异常并打印友好的错误日志。 ### 💡 建议(1个可选) 1. **scripts/ci/auto_fix_formatting.py 第48-50行**:存在并发竞态风险。脚本获取 PR 的 `head` ref 进行 fetch,但工作区内容来自 tarball。如果在 CI 启动下载 tarball 与脚本执行 fetch 之间,PR 被推送了新的提交,会导致 `FETCH_HEAD` 指向新的 commit,而工作区是旧代码。随后的 `git read-tree` 会导致工作区被视为“回退”状态,最终 commit 可能会意外覆盖他人的更新。建议 CI 环境传入具体的 commit SHA,而非动态获取分支 HEAD;或者确认 CI 平台在运行期间会锁定 PR。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-20 11:47:53 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia added 1 commit 2026-07-20 12:15:08 +08:00
fix(ci): 修复增量模式下RUFF_FILES空格残留导致ruff全目录扫描的bug
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 16s
AI Code Review / AI Code Review (pull_request) Failing after 35s
CI/CD Pipeline / Check if frontend-only change (pull_request) Has been cancelled
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / Frontend Lint (pull_request) Has been cancelled
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Successful in 51s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 37s
2fbb7fe00e
xiaoxia added 1 commit 2026-07-20 12:15:51 +08:00
fix(ci): auto-fix强制checkout到PR源分支,避免merge commit差异
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 5s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 17s
AI Code Review / AI Code Review (pull_request) Failing after 37s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m49s
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 3m2s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m4s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 7m38s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m45s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 11m18s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 20s
43a1ecc058
auto-approve-bot approved these changes 2026-07-20 12:23:37 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot approved these changes 2026-07-20 12:23:37 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot merged commit 8dc8de0c59 into develop 2026-07-20 12:27:32 +08:00
auto-approve-bot deleted branch fix/ci-autofix-git-repo 2026-07-20 12:27:32 +08:00

🗑️ 预览环境已清理

PR #629 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #629 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.