ci: PR构建验证 + Agent提交格式化 + buildx清理 #690

Merged
auto-approve-bot merged 2 commits from ci/pr-build-validation-plus into develop 2026-07-22 00:26:52 +08:00
Owner

变更内容

1. PR阶段Docker构建验证(核心修复)

  • 新增 build-pr job,pull_request事件触发
  • 三个镜像(api/worker/web)并行构建,只build不push
  • 只读缓存(develop分支缓存),不写缓存避免污染
  • 构建失败直接让PR变红,Dockerfile改动PR阶段就能发现

2. auto-merge门禁升级

  • auto-approve和auto-merge的CONTEXTS加入3个PR Build检查
  • 后端PR从2个门禁→5个门禁

3. buildx builder自动清理

  • build-staging构建后always步骤清理builder
  • 防止磁盘泄漏,之前积累了398个孤儿卷

4. Agent提交格式化脚本

  • 新增 scripts/agent-commit.sh
  • 提交前自动跑black + isort + ruff check
  • ruff不通过阻止提交,从源头消灭格式类CI失败

5. PR构建专用脚本

  • 新增 scripts/ci/docker_build_only.sh
  • 只读缓存、只load不push、带缓存损坏自动修复

预期收益

  • 🎯 从根上解决"PR过了但develop炸了"的问题
  • 🛡️ Dockerfile/构建脚本改动PR阶段零验证 → 100%验证
  • 💾 磁盘不再缓慢泄漏
  • 🧹 Agent提交格式问题从源头消灭(占CI失败19%)
## 变更内容 ### 1. PR阶段Docker构建验证(核心修复) - 新增 `build-pr` job,pull_request事件触发 - 三个镜像(api/worker/web)并行构建,**只build不push** - 只读缓存(develop分支缓存),不写缓存避免污染 - 构建失败直接让PR变红,Dockerfile改动PR阶段就能发现 ### 2. auto-merge门禁升级 - auto-approve和auto-merge的CONTEXTS加入3个PR Build检查 - 后端PR从2个门禁→5个门禁 ### 3. buildx builder自动清理 - build-staging构建后always步骤清理builder - 防止磁盘泄漏,之前积累了398个孤儿卷 ### 4. Agent提交格式化脚本 - 新增 `scripts/agent-commit.sh` - 提交前自动跑black + isort + ruff check - ruff不通过阻止提交,从源头消灭格式类CI失败 ### 5. PR构建专用脚本 - 新增 `scripts/ci/docker_build_only.sh` - 只读缓存、只load不push、带缓存损坏自动修复 ## 预期收益 - 🎯 从根上解决"PR过了但develop炸了"的问题 - 🛡️ Dockerfile/构建脚本改动PR阶段零验证 → 100%验证 - 💾 磁盘不再缓慢泄漏 - 🧹 Agent提交格式问题从源头消灭(占CI失败19%)
xiaoxia added 1 commit 2026-07-22 00:14:24 +08:00
ci: PR构建验证 + Agent提交格式化脚本 + buildx清理
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 18s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 40s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m16s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m32s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m8s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m11s
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 3m7s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m14s
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Successful in 5m21s
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 5m29s
38c9c545cf
- 新增build-pr job:PR阶段只构建不推送,验证Dockerfile/构建脚本
- auto-approve/auto-merge的CONTEXTS加入3个PR Build检查
- build-staging构建后自动清理buildx builder,防磁盘泄漏
- 新增scripts/ci/docker_build_only.sh:PR构建专用(只读缓存不写)
- 新增scripts/agent-commit.sh:Agent提交前自动black+isort+ruff检查

🚀 预览环境已部署

项目 详情
PR号 #690
预览链接 https://pr-690.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #690 | | 预览链接 | [https://pr-690.preview.xiaoxiajianji.com](https://pr-690.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
xiaoxia added 1 commit 2026-07-22 00:19:46 +08:00
fix: auto-approve用快速检查,auto-merge才等全部构建
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 49s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m33s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m36s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 3m18s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m18s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m10s
AI Code Review / AI Code Review (pull_request) Successful in 3m21s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m4s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m26s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 5m57s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 6m32s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 15s
71740879c8
- auto-approve只检查Validate+Frontend Lint,快速给审批(~3min)
- auto-merge检查全部5个门禁,含3个PR Build,确保全绿才合
- 避免Worker Build 20min+导致auto-approve超时无人审批
auto-approve-bot approved these changes 2026-07-22 00:23:06 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot approved these changes 2026-07-22 00:23:06 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
Collaborator

代码审查结果 - PR #690

⚠️ 问题(4个需要修改)

  1. scripts/agent-commit.sh 第22行find 命令使用了 head -100,导致如果项目中有超过100个 Python 文件,超出的文件将被忽略,不会进行格式化和检查。这会导致代码质量检查不完整。
  2. scripts/agent-commit.sh 第38行:Ruff 检查逻辑存在严重缺陷。grep -c "^" 统计的是输出行数而非错误数量,且判断逻辑 if [ "$RUFF_ERRORS" -le 2 ] 极其不可靠(例如:如果 ruff 输出包含 3 行警告信息,脚本会报错退出;但如果只有 1 行包含 10 个错误的描述,脚本反而会通过)。这会导致代码质量门禁失效。
  3. scripts/agent-commit.sh 第66行:在 set -e 模式下,如果 blackisort 没有对文件做任何修改(即代码已经是格式化的),git commit 会因为 "nothing to commit" 而报错退出,导致脚本中断,用户体验差且逻辑不严谨。
  4. scripts/ci/docker_build_only.sh 第20行:构建参数拼接时未加引号 BUILD_ARGS="$BUILD_ARGS --build-arg $arg"。如果构建参数的值中包含空格(例如 APP_VERSION="1.0.0 beta"),会导致 Docker 命令解析错误,构建失败。

💡 建议(2个可选)

  1. scripts/agent-commit.sh:脚本中多处使用变量(如 $TARGETS)时未加引号(例如第26行 black $TARGETS)。如果路径中包含空格,命令会执行失败。建议对所有变量引用添加双引号。
  2. .gitea/workflows/ci-pipeline.yml 第432行:使用了 curl ... | bash 的方式下载代码,这是一种潜在的安全风险(中间人攻击或仓库被入侵时可能执行恶意脚本)。建议使用 Gitea/GH Actions 标准的 actions/checkout,或者至少校验下载脚本的 Hash 值。

格式检查通过 | 逻辑审查需修改 | ⚠️ 建议关注性能


🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 00:23:15 | 模型:

## 代码审查结果 - PR #690 ### ⚠️ 问题(4个需要修改) 1. **scripts/agent-commit.sh 第22行**:`find` 命令使用了 `head -100`,导致如果项目中有超过100个 Python 文件,超出的文件将被忽略,不会进行格式化和检查。这会导致代码质量检查不完整。 2. **scripts/agent-commit.sh 第38行**:Ruff 检查逻辑存在严重缺陷。`grep -c "^"` 统计的是输出行数而非错误数量,且判断逻辑 `if [ "$RUFF_ERRORS" -le 2 ]` 极其不可靠(例如:如果 ruff 输出包含 3 行警告信息,脚本会报错退出;但如果只有 1 行包含 10 个错误的描述,脚本反而会通过)。这会导致代码质量门禁失效。 3. **scripts/agent-commit.sh 第66行**:在 `set -e` 模式下,如果 `black` 或 `isort` 没有对文件做任何修改(即代码已经是格式化的),`git commit` 会因为 "nothing to commit" 而报错退出,导致脚本中断,用户体验差且逻辑不严谨。 4. **scripts/ci/docker_build_only.sh 第20行**:构建参数拼接时未加引号 `BUILD_ARGS="$BUILD_ARGS --build-arg $arg"`。如果构建参数的值中包含空格(例如 `APP_VERSION="1.0.0 beta"`),会导致 Docker 命令解析错误,构建失败。 ### 💡 建议(2个可选) 1. **scripts/agent-commit.sh**:脚本中多处使用变量(如 `$TARGETS`)时未加引号(例如第26行 `black $TARGETS`)。如果路径中包含空格,命令会执行失败。建议对所有变量引用添加双引号。 2. **.gitea/workflows/ci-pipeline.yml 第432行**:使用了 `curl ... | bash` 的方式下载代码,这是一种潜在的安全风险(中间人攻击或仓库被入侵时可能执行恶意脚本)。建议使用 Gitea/GH Actions 标准的 `actions/checkout`,或者至少校验下载脚本的 Hash 值。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 00:23:15 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot merged commit 2b0724dd57 into develop 2026-07-22 00:26:52 +08:00
auto-approve-bot deleted branch ci/pr-build-validation-plus 2026-07-22 00:26:52 +08:00

🗑️ 预览环境已清理

PR #690 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #690 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.