xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 1 Packages Projects Releases 7 Wiki Activity

test: P3-1 第35波单元测试（voice_library/voice_clone/tts_job） #815

Closed
xiaoxia wants to merge 1 commits from test/unit-test-wave35 into develop
pull from: test/unit-test-wave35
merge into: xiaoxia:develop
Conversation 2 Commits 1 Files Changed 3
+781 -629
xiaoxia commented 2026-07-24 11:00:29 +08:00
Owner
Copy Link
Copy Source

变更内容

P3-1 第35波单元测试补充，合计 +62 个测试。

测试文件

  1. test_voice_library_use_cases.py (19个) - 音色库UseCase

    • ListVoiceLibraryUseCase：正常/状态过滤/分页/空列表（返回items+total）
    • GetVoiceLibraryUseCase：存在/不存在
    • CreateVoiceLibraryUseCase：成功/配额超限
    • UpdateVoiceLibraryUseCase：改名称/改状态/多字段/不存在
    • DeleteVoiceLibraryUseCase：成功/不存在

  2. test_voice_clone_use_cases.py (21个) - 音色克隆UseCase

    • CreateVoiceCloneUseCase：成功/默认参数
    • ListVoiceClonesUseCase：正常/状态过滤/分页/空列表
    • GetVoiceCloneUseCase：存在/不存在/非本人
    • GetVoiceCloneStatusUseCase：正常/不存在/非本人
    • DeleteVoiceCloneUseCase：成功/不存在/非本人
    • RetryVoiceCloneUseCase：失败重试/不存在/非本人/completed不可重试/processing不可重试

  3. test_tts_job_use_cases.py (22个) - TTS任务UseCase

    • CreateTTSJobUseCase：成功/默认值/克隆音色/metadata
    • ListTTSJobsUseCase：正常/状态过滤/分页/空列表
    • GetTTSJobUseCase：存在/不存在/非本人
    • GetTTSJobStatusUseCase：pending/completed/不存在/非本人
    • DeleteTTSJobUseCase：成功/不存在/非本人

测试结果

4439 passed, 8 skipped
## 变更内容 P3-1 第35波单元测试补充，合计 +62 个测试。 ### 测试文件 1. **test_voice_library_use_cases.py** (19个) - 音色库UseCase - ListVoiceLibraryUseCase：正常/状态过滤/分页/空列表（返回items+total） - GetVoiceLibraryUseCase：存在/不存在 - CreateVoiceLibraryUseCase：成功/配额超限 - UpdateVoiceLibraryUseCase：改名称/改状态/多字段/不存在 - DeleteVoiceLibraryUseCase：成功/不存在 2. **test_voice_clone_use_cases.py** (21个) - 音色克隆UseCase - CreateVoiceCloneUseCase：成功/默认参数 - ListVoiceClonesUseCase：正常/状态过滤/分页/空列表 - GetVoiceCloneUseCase：存在/不存在/非本人 - GetVoiceCloneStatusUseCase：正常/不存在/非本人 - DeleteVoiceCloneUseCase：成功/不存在/非本人 - RetryVoiceCloneUseCase：失败重试/不存在/非本人/completed不可重试/processing不可重试 3. **test_tts_job_use_cases.py** (22个) - TTS任务UseCase - CreateTTSJobUseCase：成功/默认值/克隆音色/metadata - ListTTSJobsUseCase：正常/状态过滤/分页/空列表 - GetTTSJobUseCase：存在/不存在/非本人 - GetTTSJobStatusUseCase：pending/completed/不存在/非本人 - DeleteTTSJobUseCase：成功/不存在/非本人 ### 测试结果 ``` 4439 passed, 8 skipped ```
xiaoxia added this to the 代码质量清理专项 milestone 2026-07-24 11:00:29 +08:00
xiaoxia added 1 commit 2026-07-24 11:00:29 +08:00
test: P3-1 第35波单元测试
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 9s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m31s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 28s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Failing after 11s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 25s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 52s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 20s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m47s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m15s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m20s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m6s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m59s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 42s
Details
c864c9b2e1 
- voice_library use case: 19个测试（列表带count/获取/创建+配额/更新/删除）
- voice_clone use case: 21个测试（创建/列表/获取/状态查询/删除/重试/权限校验）
- tts_job use case: 22个测试（创建/列表/获取/状态查询/删除/权限校验）

合计+62
auto-approve-bot commented 2026-07-24 11:32:12 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #815

⚠️ 问题（1个需要修改）

  1. tests/unit/test_voice_clone_use_cases.py 第68行：测试断言与输入数据不匹配，导致测试无法验证业务逻辑正确性。
    • 说明：在 test_create_success 中，调用 use_case.execute 时传入的 name 参数为 "新音色"，但断言检查的是 result.name == "我的音色"（这是 sample_job fixture 的默认值）。由于 mock_repo.create.return_value 被硬编码为 sample_profile，无论 UseCase 是否正确处理了传入的 name，这个断言都会通过。这导致测试失去了验证参数传递有效性的作用。
    • 建议：参考同文件中 test_create_with_defaults 的写法，将 mock_repo.create.side_effect 设置为 lambda x: x，或者检查 mock_repo.create.call_args[0][0].name 的值，确保断言验证的是实际传入的参数值（即 "新音色"）。

💡 建议（2个可选）

  1. tests/unit/test_voice_clone_use_cases.py 第68行：建议统一 Mock 策略。该文件中 test_createSuccess 使用硬编码 return_value，而 test_create_with_defaults 使用 side_effect = lambda x: x。建议统一使用 side_effect 或检查 call_args 的方式，使测试更健壮，能真实反映输入输出关系。
  2. tests/unit/test_voice_clone_use_cases.py 第258行：断言条件过于宽松。在 test_retry_failed_profile 中，assert result.retry_count >= 1 仅验证了下限。如果初始重试次数为 0，建议断言为 == 1，以精确验证重试逻辑是否正确递增了计数器。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 03:32:12 | 模型:

## 代码审查结果 - PR #815 ### ⚠️ 问题（1个需要修改） 1. **tests/unit/test_voice_clone_use_cases.py 第68行**：测试断言与输入数据不匹配，导致测试无法验证业务逻辑正确性。 - **说明**：在 `test_create_success` 中，调用 `use_case.execute` 时传入的 `name` 参数为 `"新音色"`，但断言检查的是 `result.name == "我的音色"`（这是 `sample_job` fixture 的默认值）。由于 `mock_repo.create.return_value` 被硬编码为 `sample_profile`，无论 UseCase 是否正确处理了传入的 `name`，这个断言都会通过。这导致测试失去了验证参数传递有效性的作用。 - **建议**：参考同文件中 `test_create_with_defaults` 的写法，将 `mock_repo.create.side_effect` 设置为 `lambda x: x`，或者检查 `mock_repo.create.call_args[0][0].name` 的值，确保断言验证的是实际传入的参数值（即 `"新音色"`）。 ### 💡 建议（2个可选） 1. **tests/unit/test_voice_clone_use_cases.py 第68行**：建议统一 Mock 策略。该文件中 `test_createSuccess` 使用硬编码 `return_value`，而 `test_create_with_defaults` 使用 `side_effect = lambda x: x`。建议统一使用 `side_effect` 或检查 `call_args` 的方式，使测试更健壮，能真实反映输入输出关系。 2. **tests/unit/test_voice_clone_use_cases.py 第258行**：断言条件过于宽松。在 `test_retry_failed_profile` 中，`assert result.retry_count >= 1` 仅验证了下限。如果初始重试次数为 0，建议断言为 `== 1`，以精确验证重试逻辑是否正确递增了计数器。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 03:32:12 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-24 17:21:54 +08:00
gitea-actions bot commented 2026-07-24 17:24:11 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #815 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #815 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 9s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m31s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 28s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Failing after 11s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 25s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 52s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 20s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m47s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m15s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m20s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m6s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m59s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 42s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone 代码质量清理专项
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#815
Delete Branch "test/unit-test-wave35"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?