xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

fix(ci): Preview Deploy npm ci参数错误修复 #834

Merged
xiaoxia merged 1 commits from fix/ci-preview-deploy-npm-ci into develop 2026-07-24 19:19:52 +08:00
Conversation 2 Commits 1 Files Changed 1
+2 -2
xiaoxia commented 2026-07-24 17:33:03 +08:00
Owner
Copy Link
Copy Source

问题

Preview Deploy构建失败，npm ci阶段报错。

根因

npm ci --include=dev 参数错误。--include=dev 是 npm install 的参数，npm ci 不支持该参数。且 npm ci 默认就安装 devDependencies，不需要额外指定。

修复

移除两处 --include=dev 参数，使用默认的 npm ci 即可。

## 问题 Preview Deploy构建失败，npm ci阶段报错。 ## 根因 `npm ci --include=dev` 参数错误。`--include=dev` 是 `npm install` 的参数，`npm ci` 不支持该参数。且 npm ci 默认就安装 devDependencies，不需要额外指定。 ## 修复 移除两处 `--include=dev` 参数，使用默认的 `npm ci` 即可。
xiaoxia added 1 commit 2026-07-24 19:04:56 +08:00
fix(ci): preview deploy npm ci remove --include=dev
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m11s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 52s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 28s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 28s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 16s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m30s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m32s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 17s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m59s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m45s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m16s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m4s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 6s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 48m25s
Details
74c3acdf7d
xiaoxia force-pushed fix/ci-preview-deploy-npm-ci from 2e4d3c8fdf to 74c3acdf7d 2026-07-24 19:04:56 +08:00 Compare
auto-approve-bot commented 2026-07-24 19:14:17 +08:00
Collaborator
Copy Link
Copy Source

📊 审查概览

  • 整体评价：需修改
  • 严重问题数量：1 个
  • 一般建议数量：0 个

❌ 需修改的问题（严重）

  1. [.gitea/workflows/preview-deploy.yml: 118, 122] 移除 --include=dev 参数导致构建依赖缺失
    • 问题描述：代码移除了 npm ci 命令中的 --include=dev 参数。默认情况下，npm ci 只会安装 dependencies 中的依赖，而不会安装 devDependencies。在名为 "preview-deploy" 的工作流中，后续步骤极有可能需要运行构建命令（如 npm run build），而构建工具（如 Webpack, Vite, TypeScript 等）通常定义在 devDependencies 中。移除此参数将导致这些工具缺失，进而导致构建失败。
    • 修改建议：请确认后续构建步骤是否依赖 devDependencies。如果是，必须恢复 --include=dev 参数。如果确实不需要，请忽略此条建议（但这在预览部署场景中很少见）。

💡 改进建议（一般）

无

✅ 良好实践

  • 保留了依赖安装失败后的清理重试逻辑（rm -rf node_modules），这是一种处理 CI 环境下偶尔出现的依赖损坏问题的有效实践。

🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 11:14:17 | 模型:

### 📊 审查概览 - 整体评价：需修改 - 严重问题数量：1 个 - 一般建议数量：0 个 ### ❌ 需修改的问题（严重） 1. **[.gitea/workflows/preview-deploy.yml: 118, 122] 移除 `--include=dev` 参数导致构建依赖缺失** - **问题描述**：代码移除了 `npm ci` 命令中的 `--include=dev` 参数。默认情况下，`npm ci` 只会安装 `dependencies` 中的依赖，而不会安装 `devDependencies`。在名为 "preview-deploy" 的工作流中，后续步骤极有可能需要运行构建命令（如 `npm run build`），而构建工具（如 Webpack, Vite, TypeScript 等）通常定义在 `devDependencies` 中。移除此参数将导致这些工具缺失，进而导致构建失败。 - **修改建议**：请确认后续构建步骤是否依赖 `devDependencies`。如果是，必须恢复 `--include=dev` 参数。如果确实不需要，请忽略此条建议（但这在预览部署场景中很少见）。 ### 💡 改进建议（一般） 无 ### ✅ 良好实践 - 保留了依赖安装失败后的清理重试逻辑（`rm -rf node_modules`），这是一种处理 CI 环境下偶尔出现的依赖损坏问题的有效实践。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 11:14:17 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit 42f92017de into develop 2026-07-24 19:19:52 +08:00
gitea-actions bot commented 2026-07-24 19:23:09 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #834 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #834 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#834
Delete Branch "fix/ci-preview-deploy-npm-ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?