xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(test): 修复test_dedup_pure收集阶段db连接副作用（P0） #894

Closed
xiaoxia wants to merge 1 commits from fix/dedup-pure-test-db-import into develop
pull from: fix/dedup-pure-test-db-import
merge into: xiaoxia:develop
Conversation 1 Commits 1 Files Changed 1
+57 -1
xiaoxia commented 2026-07-25 16:50:14 +08:00
Owner
Copy Link
Copy Source

问题

test_dedup_pure.py 在 pytest 收集阶段就挂了——纯函数测试不该有数据库依赖。

根因

video_processing/dedup.py 顶层直接 import worker_app.db，而 db.py 在模块加载时就执行 ensure_database_exists(settings.database_url) 触发数据库连接。CI环境没有数据库，导致收集阶段直接报错。

修复

在测试模块顶部预先 mock 掉所有有副作用的模块：

  • cv2
  • celery
  • sqlalchemy（包结构）
  • worker_app / worker_app.db / worker_app.celery_app / worker_app.core.config
  • packages.adapters.sqlalchemy_impl
  • packages.shared.config / packages.shared.storage

确保 import dedup 时不会触发真实的数据库连接。

验证

20 passed ✅

### 问题 test_dedup_pure.py 在 pytest 收集阶段就挂了——纯函数测试不该有数据库依赖。 ### 根因 `video_processing/dedup.py` 顶层直接 import `worker_app.db`，而 `db.py` 在模块加载时就执行 `ensure_database_exists(settings.database_url)` 触发数据库连接。CI环境没有数据库，导致收集阶段直接报错。 ### 修复 在测试模块顶部预先 mock 掉所有有副作用的模块： - cv2 - celery - sqlalchemy（包结构） - worker_app / worker_app.db / worker_app.celery_app / worker_app.core.config - packages.adapters.sqlalchemy_impl - packages.shared.config / packages.shared.storage 确保 `import dedup` 时不会触发真实的数据库连接。 ### 验证 20 passed ✅
xiaoxia added 1 commit 2026-07-25 16:50:15 +08:00
fix(test): 修复test_dedup_pure收集阶段db连接副作用
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 11s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 50s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 30s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 46s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 30s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 17s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m9s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m35s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 12s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m0s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m0s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 48m41s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
c10552dae1 
根因：video_processing/dedup.py 顶层import worker_app.db，
而 db.py 模块加载时就执行 ensure_database_exists() 触发数据库连接。
纯函数测试不需要任何db/celery/cv2依赖。

修复：在测试模块顶部预先mock掉所有有副作用的模块
（cv2/celery/sqlalchemy/worker_app/packages.adapters/packages.shared），
确保 import dedup 时不会触发真实的数据库连接。

20 passed ✅
xiaoxia closed this pull request 2026-07-25 20:53:41 +08:00
gitea-actions bot commented 2026-07-25 20:56:25 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #894 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #894 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 11s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 50s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 30s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 46s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 30s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 17s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m9s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m35s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 12s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m1s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m0s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m0s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 48m41s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#894
Delete Branch "fix/dedup-pure-test-db-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?