xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(lint): 移除 clipProperties.ts 中未使用的 ClipType import #936

Closed
xiaoxia wants to merge 3 commits from fix/frontend-lint-clip-type-import into develop
pull from: fix/frontend-lint-clip-type-import
merge into: xiaoxia:develop
Conversation 3 Commits 3 Files Changed 4
+5 -5
xiaoxia commented 2026-07-26 16:18:35 +08:00
Owner
Copy Link
Copy Source

修复 EditingPlanner 第二轮重构带进来的前端 lint 错误，移除未使用的 ClipType import。

该错误导致所有基于 develop 的新 PR 前端 lint 全部挂掉，阻塞合并。

修复 EditingPlanner 第二轮重构带进来的前端 lint 错误，移除未使用的 ClipType import。 该错误导致所有基于 develop 的新 PR 前端 lint 全部挂掉，阻塞合并。
xiaoxia added 1 commit 2026-07-26 16:18:35 +08:00
fix(lint): remove unused ClipType import in clipProperties.ts
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 20s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 55s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 30s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m35s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m0s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m20s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m11s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 26s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m36s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m23s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
aa65e84e21
xiaoxia added 1 commit 2026-07-26 16:27:08 +08:00
fix(lint): replace any type with PipGridPosition in LayerConfig
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 28s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m27s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m1s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 36s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 43s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 48s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m19s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m19s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m54s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 44s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 26s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 15s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
5ee630aa79
xiaoxia added 1 commit 2026-07-26 16:48:55 +08:00
fix(ts): 修复TtsPanel和TtsSlider的TypeScript类型错误
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 10s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m48s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m55s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 2m4s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 17s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m12s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m18s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 53s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 53s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m33s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m28s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 16s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 12s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 37s
Details
e467ed1c1c
gitea-actions bot commented 2026-07-26 16:53:30 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #936
预览链接 https://pr-936.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #936 | | 预览链接 | [https://pr-936.preview.xiaoxiajianji.com](https://pr-936.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-26 16:53:53 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #936

⚠️ 问题（1个需要修改）

  1. apps/web/src/pages/editing-planner/components/tts/TtsSlider.tsx 第49行：tooltip 属性回退值从 false 修改为 undefined 可能导致非预期的行为变更。
    • 原因：在大多数 UI 组件库（如 Ant Design）中，tooltip={false} 通常表示明确禁用 Tooltip，而 tooltip={undefined} 通常表示启用默认行为。如果之前的意图是“没有 formatter 时不显示提示”，此修改会导致默认提示意外出现。
    • 后果：用户界面可能在不需要的地方显示提示信息，影响用户体验。

💡 建议（1个可选）

  1. apps/web/src/pages/editing-planner/components/TtsPanel.tsx 第77行：确认 handleTextChange 函数签名已同步更新。
    • 说明：代码显式传递了 e.target.value，请确保 handleTextChange 的定义已修改为接受 string 类型参数，而非 React.ChangeEvent 对象，否则会导致运行时错误。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 08:53:53 | 模型:

## 代码审查结果 - PR #936 ### ⚠️ 问题（1个需要修改） 1. **apps/web/src/pages/editing-planner/components/tts/TtsSlider.tsx 第49行**：`tooltip` 属性回退值从 `false` 修改为 `undefined` 可能导致非预期的行为变更。 - **原因**：在大多数 UI 组件库（如 Ant Design）中，`tooltip={false}` 通常表示明确禁用 Tooltip，而 `tooltip={undefined}` 通常表示启用默认行为。如果之前的意图是“没有 formatter 时不显示提示”，此修改会导致默认提示意外出现。 - **后果**：用户界面可能在不需要的地方显示提示信息，影响用户体验。 ### 💡 建议（1个可选） 1. **apps/web/src/pages/editing-planner/components/TtsPanel.tsx 第77行**：确认 `handleTextChange` 函数签名已同步更新。 - **说明**：代码显式传递了 `e.target.value`，请确保 `handleTextChange` 的定义已修改为接受 `string` 类型参数，而非 `React.ChangeEvent` 对象，否则会导致运行时错误。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 08:53:53 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-26 17:07:40 +08:00
gitea-actions bot commented 2026-07-26 17:15:15 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #936 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #936 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 10s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m48s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m55s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 2m4s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 17s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m12s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m18s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 53s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 53s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m33s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m28s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 16s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 12s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 37s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#936
Delete Branch "fix/frontend-lint-clip-type-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?