xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

第89波 - 拆分asset_analyzer评分纯逻辑 + 64单测 #938

Closed
xiaoxia wants to merge 1 commits from test/wave89-asset-analyzer-split into develop
pull from: test/wave89-asset-analyzer-split
merge into: xiaoxia:develop
Conversation 2 Commits 1 Files Changed 3
+1148 -354
xiaoxia commented 2026-07-26 16:30:28 +08:00
Owner
Copy Link
Copy Source
No description provided.
xiaoxia added 1 commit 2026-07-26 16:30:28 +08:00
refactor+test(asset): 第89波 - 拆分asset_analyzer评分纯逻辑 + 64单测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 9s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 59s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m36s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 58s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 29s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m3s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m23s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m58s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request), CI/CD Pipeline / Frontend Lint (pull_request), CI/CD Pipeline / PR Build Web Image (pull_request) [backend-only]
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 56s
Details
3be0aca709 
- 从799行asset_analyzer.py拆出asset_quality_scoring.py纯逻辑模块
- 质量评分：分辨率/帧率/码率/清晰度/稳定性 5个维度纯函数
- 分类评分：9个分类（风景/产品/人物/动物/美食/科技/运动/音乐/其他）
- 64个单测全覆盖：边界值、numpy数组、分类组合、数据类
- 原文件从799行瘦身到467行（-332行）
- 向后兼容：classify_asset_real / calculate_quality_score_real 入口不变
auto-approve-bot commented 2026-07-26 16:44:33 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #938

⚠️ 问题（0个需要修改）

无

💡 建议（3个可选）

  1. apps/worker/worker_app/tasks/asset_quality_scoring.py 第215行：循环内重复导入模块

    • 问题描述：from scipy import signal 位于 for 循环内部。虽然代码逻辑上可行（为了配合 try-except 捕获 ImportError），但每次循环都会执行导入操作，造成不必要的性能开销。
    • 修改建议：将 from scipy import signal 移至 try 块的开始处（循环外部）。如果 scipy 缺失，会在进入循环前抛出 ImportError 并被捕获，效果相同且更高效。

  2. apps/worker/worker_app/tasks/asset_quality_scoring.py 第435行：冗余的空值检查

    • 问题描述：if not scores: 检查是死代码。调用的 calculate_category_scores 函数始终会返回包含至少一个键（AssetClassification.OTHER.value）的字典，因此 scores 永远不会为空。
    • 修改建议：删除 if not scores: 及其对应的 return 分支，直接执行后续的 max 逻辑。

  3. apps/worker/worker_app/tasks/asset_quality_scoring.py 第204行 & 第254行：异常捕获过于宽泛且缺少日志

    • 问题描述：except Exception: 捕获了所有异常。虽然对于非关键的评分任务，返回默认分（10.0）可以防止任务中断，但静默吞掉异常（如内存错误、意外的数据类型错误）会掩盖潜在的问题。
    • 修改建议：建议捕获具体异常（如 ImportError, ValueError），或在 except Exception 块中添加 logger.warning 记录异常堆栈，便于排查问题。

✅ 格式检查通过 | ✅ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 08:44:33 | 模型:

## 代码审查结果 - PR #938 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（3个可选） 1. **apps/worker/worker_app/tasks/asset_quality_scoring.py 第215行**：循环内重复导入模块 - 问题描述：`from scipy import signal` 位于 `for` 循环内部。虽然代码逻辑上可行（为了配合 try-except 捕获 ImportError），但每次循环都会执行导入操作，造成不必要的性能开销。 - 修改建议：将 `from scipy import signal` 移至 `try` 块的开始处（循环外部）。如果 scipy 缺失，会在进入循环前抛出 ImportError 并被捕获，效果相同且更高效。 2. **apps/worker/worker_app/tasks/asset_quality_scoring.py 第435行**：冗余的空值检查 - 问题描述：`if not scores:` 检查是死代码。调用的 `calculate_category_scores` 函数始终会返回包含至少一个键（`AssetClassification.OTHER.value`）的字典，因此 `scores` 永远不会为空。 - 修改建议：删除 `if not scores:` 及其对应的 return 分支，直接执行后续的 `max` 逻辑。 3. **apps/worker/worker_app/tasks/asset_quality_scoring.py 第204行 & 第254行**：异常捕获过于宽泛且缺少日志 - 问题描述：`except Exception:` 捕获了所有异常。虽然对于非关键的评分任务，返回默认分（10.0）可以防止任务中断，但静默吞掉异常（如内存错误、意外的数据类型错误）会掩盖潜在的问题。 - 修改建议：建议捕获具体异常（如 `ImportError`, `ValueError`），或在 `except Exception` 块中添加 `logger.warning` 记录异常堆栈，便于排查问题。 --- ✅ 格式检查通过 | ✅ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 08:44:33 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-27 19:48:57 +08:00
gitea-actions bot commented 2026-07-27 20:59:11 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #938 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #938 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 9s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 59s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m36s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 58s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 29s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m3s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m23s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m58s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request), CI/CD Pipeline / Frontend Lint (pull_request), CI/CD Pipeline / PR Build Web Image (pull_request) [backend-only]
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 56s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#938
Delete Branch "test/wave89-asset-analyzer-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?