xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions 1 Packages Projects Releases 7 Wiki Activity

test(wave90): add 52 unit tests for plan_generator_utils + extract from plan_generator_service #940

Closed
xiaoxia wants to merge 3 commits from test/wave90-plan-generator-utils into develop
pull from: test/wave90-plan-generator-utils
merge into: xiaoxia:develop
Conversation 2 Commits 3 Files Changed 7
+2186 -603
xiaoxia commented 2026-07-26 16:48:58 +08:00
Owner
Copy Link
Copy Source

第90波单测+重构专项

重构

从 plan_generator_service.py 中抽出纯逻辑模块 packages/domain/plan_generator_utils.py：

  • distribute_assets: 4种模式素材分配（ONE_TAKE/PIP/VOICE_OVER/VOICE_PIP）
  • map_clip_types_for_mode: 根据生成模式映射clip类型
  • generate_default_clips: 按模式生成默认clip结构
  • create_clips_from_configs: 从配置列表创建clip，含duration计算
  • 常量定义：DEFAULT_DURATION、各模式clip配置

瘦身效果

  • 原文件：437行 → 209行（-228行，-52%）

单测覆盖（52个）

模块 数量
TestDistributeAssets 14
TestMapClipTypesForMode 6
TestGenerateDefaultClips 12
TestCreateClipsFromConfigs 11
TestConstants 3

本地验证

  • ✅ 52 passed in 1.57s
  • ✅ black formatted
  • ✅ 向后兼容，原有服务入口不变
## 第90波单测+重构专项 ### 重构 从 `plan_generator_service.py` 中抽出纯逻辑模块 `packages/domain/plan_generator_utils.py`： - `distribute_assets`: 4种模式素材分配（ONE_TAKE/PIP/VOICE_OVER/VOICE_PIP） - `map_clip_types_for_mode`: 根据生成模式映射clip类型 - `generate_default_clips`: 按模式生成默认clip结构 - `create_clips_from_configs`: 从配置列表创建clip，含duration计算 - 常量定义：DEFAULT_DURATION、各模式clip配置 ### 瘦身效果 - 原文件：437行 → 209行（-228行，-52%） ### 单测覆盖（52个） | 模块 | 数量 | |------|------| | TestDistributeAssets | 14 | | TestMapClipTypesForMode | 6 | | TestGenerateDefaultClips | 12 | | TestCreateClipsFromConfigs | 11 | | TestConstants | 3 | ### 本地验证 - ✅ 52 passed in 1.57s - ✅ black formatted - ✅ 向后兼容，原有服务入口不变
xiaoxia added 2 commits 2026-07-26 16:48:58 +08:00
refactor+test(asset): 第89波 - 拆分asset_analyzer评分纯逻辑 + 64单测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 9s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 59s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m36s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 58s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 29s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m3s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m23s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m58s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m4s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request), CI/CD Pipeline / Frontend Lint (pull_request), CI/CD Pipeline / PR Build Web Image (pull_request) [backend-only]
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 56s
Details
3be0aca709 
- 从799行asset_analyzer.py拆出asset_quality_scoring.py纯逻辑模块
- 质量评分：分辨率/帧率/码率/清晰度/稳定性 5个维度纯函数
- 分类评分：9个分类（风景/产品/人物/动物/美食/科技/运动/音乐/其他）
- 64个单测全覆盖：边界值、numpy数组、分类组合、数据类
- 原文件从799行瘦身到467行（-332行）
- 向后兼容：classify_asset_real / calculate_quality_score_real 入口不变
test(wave90): add 52 unit tests for plan_generator_utils + extract from plan_generator_service
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 13s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 38s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m7s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m41s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 42s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 57s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 33s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m33s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m19s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m56s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m23s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m59s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
5354093417 
- Extract pure logic from plan_generator_service.py to packages/domain/plan_generator_utils.py
  - distribute_assets: 4-mode asset distribution (ONE_TAKE/PIP/VOICE_OVER/VOICE_PIP)
  - map_clip_types_for_mode: clip type mapping based on generation mode
  - generate_default_clips: default clip structure generation per mode
  - create_clips_from_configs: clip creation from config list with duration calculation
  - Constants: DEFAULT_DURATION, mode clip configs
- Original file: 437 lines -> 209 lines (-228, -52%)
- 52 unit tests covering all functions and edge cases
- black formatted
xiaoxia added 1 commit 2026-07-27 00:41:51 +08:00
fix(test): 修复test_agent_docs.py相对路径问题，从apps/api运行也能找到docs
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 25s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 40s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m14s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m46s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 33s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m24s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m7s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 41s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m27s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m17s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m13s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m47s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m17s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request), CI/CD Pipeline / Frontend Lint (pull_request), CI/CD Pipeline / PR Build Web Image (pull_request) [backend-only]
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 49s
Details
7da2a07a1a 
使用 __file__ 定位项目根目录，避免依赖pytest运行目录。
修复后Unit Tests CI从apps/api目录运行也能正常通过。
auto-approve-bot commented 2026-07-27 01:02:38 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #940

⚠️ 问题（0个需要修改）

无

💡 建议（0个可选）

无

✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:02:38 | 模型:

## 代码审查结果 - PR #940 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（0个可选） 无 --- ✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:02:38 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-27 19:48:57 +08:00
gitea-actions bot commented 2026-07-27 20:59:03 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #940 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #940 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 25s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 40s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m14s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m46s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 33s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m24s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m7s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 41s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m27s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m17s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m13s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m47s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m17s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request), CI/CD Pipeline / Frontend Lint (pull_request), CI/CD Pipeline / PR Build Web Image (pull_request) [backend-only]
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 49s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#940
Delete Branch "test/wave90-plan-generator-utils"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?