xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(task-center): 三阶段重构 TaskCenter（423→76行, -82%） #965

Closed
xiaoxia wants to merge 2 commits from refactor/task-center into develop
pull from: refactor/task-center
merge into: xiaoxia:develop
Conversation 6 Commits 2 Files Changed 7
+546 -386
xiaoxia commented 2026-07-26 17:48:00 +08:00
Owner
Copy Link
Copy Source

变更说明

TaskCenter 任务中心三阶段重构，主文件 423→76 行（-82%）

Phase 1: 常量/工具

  • constants.tsx: STATUS_TABS / TYPE_OPTIONS / STATUS_CONFIG / TYPE_LABELS
  • utils.ts: formatDuration / formatTime

Phase 2: UI 组件

  • components/TaskFilterBar.tsx: 筛选栏（状态 Tab + 类型下拉）
  • components/TaskTable.tsx: 任务表格（含 7 列定义 + 分页 + 展开行）
  • components/TaskErrorDetail.tsx: 错误详情展开面板

Phase 3: 业务 Hook

  • hooks/useTaskList.ts: 筛选状态 + 任务查询（自动轮询） + 重试 mutation + 展开逻辑

说明

  • 所有功能保持不变，纯结构重构
  • 表格列定义独立，后续新增列更方便
## 变更说明 TaskCenter 任务中心三阶段重构，主文件 423→76 行（-82%） ### Phase 1: 常量/工具 - `constants.tsx`: STATUS_TABS / TYPE_OPTIONS / STATUS_CONFIG / TYPE_LABELS - `utils.ts`: formatDuration / formatTime ### Phase 2: UI 组件 - `components/TaskFilterBar.tsx`: 筛选栏（状态 Tab + 类型下拉） - `components/TaskTable.tsx`: 任务表格（含 7 列定义 + 分页 + 展开行） - `components/TaskErrorDetail.tsx`: 错误详情展开面板 ### Phase 3: 业务 Hook - `hooks/useTaskList.ts`: 筛选状态 + 任务查询（自动轮询） + 重试 mutation + 展开逻辑 ### 说明 - 所有功能保持不变，纯结构重构 - 表格列定义独立，后续新增列更方便
xiaoxia added 1 commit 2026-07-26 17:48:01 +08:00
refactor(task-center): 三阶段重构 TaskCenter（423→76行, -82%）
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 31s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m17s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 47s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m12s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 33s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m5s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 59s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m14s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m18s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m37s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m25s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m14s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 57s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
a3e098b8da 
- Phase 1: 抽 constants(STATUS_CONFIG/TYPE_LABELS等) + utils(formatDuration/formatTime)
- Phase 2: 抽 3 个 UI 组件（TaskFilterBar/TaskTable/TaskErrorDetail）
- Phase 3: 抽 useTaskList 业务 Hook（筛选+查询+重试）
- 主文件 423→76 行，职责清晰，表格列定义独立维护
xiaoxia added 1 commit 2026-07-27 12:34:49 +08:00
Merge branch 'develop' into refactor/task-center
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 12s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 52s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m7s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m11s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m37s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 30s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m54s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 47s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m3s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 15m25s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request) [frontend-only]
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 23s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
6d601dfbc3
auto-approve-bot approved these changes 2026-07-27 13:53:15 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-27 13:53:15 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-07-27 13:54:03 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #965
预览链接 https://pr-965.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #965 | | 预览链接 | [https://pr-965.preview.xiaoxiajianji.com](https://pr-965.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 13:55:08 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #965

⚠️ 问题（2个需要修改）

  1. apps/web/src/pages/tasks/components/TaskTable.tsx 第144行：重试按钮的 loading 状态使用了全局布尔值 retryLoading。

    • 问题描述：retryLoading 来自 useTaskList hook 中的 retryMutation.isPending，这是一个全局状态。当用户点击列表中某一个任务的“重试”时，列表中所有失败任务的“重试”按钮都会同时进入 loading 状态，导致交互反馈不准确，用户会误以为所有任务都在重试。
    • 修改建议：在 useTaskList 中维护 retryingId: string | null 状态，mutation 开始时设置为当前 ID，结束时重置为 null。将 retryingId 传给 TaskTable，在列渲染时判断 record.id === retryingId 来决定是否显示 loading。

  2. apps/web/src/pages/tasks/utils.ts 第4行：formatDuration 函数对 0 值处理不当。

    • 问题描述：代码使用 if (!seconds) 进行判断。如果任务耗时正好为 0 秒（例如瞬间完成的任务），该条件成立，函数会返回 -，而不是预期的 0秒。这会导致信息展示错误。
    • 修改建议：应明确区分 null/undefined 和 0。修改为 if (seconds === undefined || seconds === null) return "-"。

💡 建议（1个可选）

  1. apps/web/src/pages/tasks/components/TaskTable.tsx 第37行：columns 定义在组件内部，每次渲染都会重新创建。
    • 具体内容：虽然 React 对比 props 机制能处理大部分情况，但将 columns 数组（包含内联函数）直接定义在组件函数体中，会导致每次父组件渲染时子组件（如 Table 内部的 Cell）也发生不必要的重渲染。建议使用 useMemo 包裹 columns 定义，依赖项包含 onRetry, onViewDetail, onExpand 等回调函数。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能尚可

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 05:55:08 | 模型:

## 代码审查结果 - PR #965 ### ⚠️ 问题（2个需要修改） 1. **apps/web/src/pages/tasks/components/TaskTable.tsx 第144行**：重试按钮的 `loading` 状态使用了全局布尔值 `retryLoading`。 - **问题描述**：`retryLoading` 来自 `useTaskList` hook 中的 `retryMutation.isPending`，这是一个全局状态。当用户点击列表中某一个任务的“重试”时，列表中所有失败任务的“重试”按钮都会同时进入 loading 状态，导致交互反馈不准确，用户会误以为所有任务都在重试。 - **修改建议**：在 `useTaskList` 中维护 `retryingId: string | null` 状态，mutation 开始时设置为当前 ID，结束时重置为 null。将 `retryingId` 传给 `TaskTable`，在列渲染时判断 `record.id === retryingId` 来决定是否显示 loading。 2. **apps/web/src/pages/tasks/utils.ts 第4行**：`formatDuration` 函数对 `0` 值处理不当。 - **问题描述**：代码使用 `if (!seconds)` 进行判断。如果任务耗时正好为 0 秒（例如瞬间完成的任务），该条件成立，函数会返回 `-`，而不是预期的 `0秒`。这会导致信息展示错误。 - **修改建议**：应明确区分 `null/undefined` 和 `0`。修改为 `if (seconds === undefined || seconds === null) return "-"`。 ### 💡 建议（1个可选） 1. **apps/web/src/pages/tasks/components/TaskTable.tsx 第37行**：`columns` 定义在组件内部，每次渲染都会重新创建。 - **具体内容**：虽然 React 对比 props 机制能处理大部分情况，但将 `columns` 数组（包含内联函数）直接定义在组件函数体中，会导致每次父组件渲染时子组件（如 Table 内部的 Cell）也发生不必要的重渲染。建议使用 `useMemo` 包裹 `columns` 定义，依赖项包含 `onRetry`, `onViewDetail`, `onExpand` 等回调函数。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能尚可 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 05:55:08 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot commented 2026-07-27 14:08:40 +08:00
Collaborator
Copy Link
Copy Source

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.
xiaoxia closed this pull request 2026-07-27 16:33:18 +08:00
gitea-actions bot commented 2026-07-27 18:15:29 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #965 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #965 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 12s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 52s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m7s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m11s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m37s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 30s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m54s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 47s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m3s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 15m25s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request) [frontend-only]
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 23s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#965
Delete Branch "refactor/task-center"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?