xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(generate): 拆分 useStep4Title Hook，按职责拆为 AI 生成 + 样式更新 #1004

Closed
xiaoxia wants to merge 2 commits from refactor/use-step4-title-split into develop
pull from: refactor/use-step4-title-split
merge into: xiaoxia:develop
Conversation 6 Commits 2 Files Changed -
xiaoxia commented 2026-07-27 07:25:12 +08:00
Owner
Copy Link
Copy Source

变更说明

拆分 useStep4Title 巨无霸 Hook（251 行），按职责拆分为目录结构：

  • useAiTitleGenerator - AI 标题生成、刷新、选择逻辑
  • useTitleStyleUpdaters - 标题文字/位置/字体/样式等所有设置更新
  • index - 组合入口 + 标题库数据查询

主文件 251 → 75 行（-70%）

导入路径保持不变（@/pages/generate/hooks/useStep4Title），向后兼容。

## 变更说明 拆分 useStep4Title 巨无霸 Hook（251 行），按职责拆分为目录结构： - **useAiTitleGenerator** - AI 标题生成、刷新、选择逻辑 - **useTitleStyleUpdaters** - 标题文字/位置/字体/样式等所有设置更新 - **index** - 组合入口 + 标题库数据查询 主文件 251 → 75 行（-70%） 导入路径保持不变（`@/pages/generate/hooks/useStep4Title`），向后兼容。
xiaoxia added 1 commit 2026-07-27 07:25:12 +08:00
refactor(generate): 拆分 useStep4Title Hook，按职责拆为 AI 生成 + 样式更新
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 28s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m16s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m57s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 41s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 43s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m17s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m14s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m27s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m23s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 6m14s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 16m7s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 42s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
3ccf2c6fa6 
主文件 251→75 行（-70%），拆分为：
- useAiTitleGenerator: AI 标题生成、刷新、选择逻辑
- useTitleStyleUpdaters: 标题文字/位置/字体/样式等所有设置更新
- index: 组合入口 + 标题库数据查询

导入路径保持向后兼容
auto-approve-bot approved these changes 2026-07-27 07:40:04 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-27 07:40:04 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-07-27 07:40:54 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1004
预览链接 https://pr-1004.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1004 | | 预览链接 | [https://pr-1004.preview.xiaoxiajianji.com](https://pr-1004.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 07:43:15 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1004

⚠️ 问题（2个需要修改）

  1. useTitleStyleUpdaters.ts 多处：所有更新回调函数（如 updateTitle, toggleBold 等）均依赖 titleSettings 作为 useCallback 的依赖项。这会导致每次 titleSettings 更新时，所有回调函数都会重新创建，进而导致引用这些函数的子组件发生不必要的重渲染，影响性能。

    • 修改建议：使用函数式更新 onTitleSettingsChange(prev => ({ ...prev, title }))，并将 titleSettings 从依赖数组中移除，仅保留 onTitleSettingsChange。同理适用于 useAiTitleGenerator.ts 中的 handleSelectAiTitle。

  2. useAiTitleGenerator.ts 第73行 & 第86行：handleGenerateAiTitles 和 handleRefreshAiTitles 内部包含异步操作（setTimeout），但在异步状态更新（setAiTitleResults、setAiTitleGenerating）前未检查组件是否已卸载。如果在异步操作完成前组件卸载，会导致 React "Can't perform a React state update on an unmounted component" 警告及内存泄漏。

    • 修改建议：引入一个 useRef 来跟踪组件的挂载状态（如 isMounted.current = false 在 useEffect cleanup 中），或在异步操作结束后检查该标志位再调用 setState。

💡 建议（1个可选）

  1. useAiTitleGenerator.ts & useTitleStyleUpdaters.ts：extractTopic、generateTitlesFromTopic 和 getActivePreset 等纯函数不依赖组件内部状态，目前定义在组件内部，每次组件渲染都会重新创建函数引用。
    • 建议描述：将这些纯函数移至组件外部，避免不必要的函数创建开销。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 23:43:15 | 模型:

## 代码审查结果 - PR #1004 ### ⚠️ 问题（2个需要修改） 1. **useTitleStyleUpdaters.ts 多处**：所有更新回调函数（如 `updateTitle`, `toggleBold` 等）均依赖 `titleSettings` 作为 `useCallback` 的依赖项。这会导致每次 `titleSettings` 更新时，所有回调函数都会重新创建，进而导致引用这些函数的子组件发生不必要的重渲染，影响性能。 - **修改建议**：使用函数式更新 `onTitleSettingsChange(prev => ({ ...prev, title }))`，并将 `titleSettings` 从依赖数组中移除，仅保留 `onTitleSettingsChange`。同理适用于 `useAiTitleGenerator.ts` 中的 `handleSelectAiTitle`。 2. **useAiTitleGenerator.ts 第73行 & 第86行**：`handleGenerateAiTitles` 和 `handleRefreshAiTitles` 内部包含异步操作（`setTimeout`），但在异步状态更新（`setAiTitleResults`、`setAiTitleGenerating`）前未检查组件是否已卸载。如果在异步操作完成前组件卸载，会导致 React "Can't perform a React state update on an unmounted component" 警告及内存泄漏。 - **修改建议**：引入一个 `useRef` 来跟踪组件的挂载状态（如 `isMounted.current = false` 在 `useEffect` cleanup 中），或在异步操作结束后检查该标志位再调用 setState。 ### 💡 建议（1个可选） 1. **useAiTitleGenerator.ts & useTitleStyleUpdaters.ts**：`extractTopic`、`generateTitlesFromTopic` 和 `getActivePreset` 等纯函数不依赖组件内部状态，目前定义在组件内部，每次组件渲染都会重新创建函数引用。 - **建议描述**：将这些纯函数移至组件外部，避免不必要的函数创建开销。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 23:43:15 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot commented 2026-07-27 07:55:31 +08:00
Collaborator
Copy Link
Copy Source

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.
xiaoxia added 1 commit 2026-07-27 12:34:24 +08:00
Merge branch 'develop' into refactor/use-step4-title-split
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 38s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 48s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m16s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m52s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 44s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 34s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m6s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m13s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m54s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m19s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 14s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m56s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 7m15s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 34s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
68d26c2c7a
xiaoxia closed this pull request 2026-07-27 15:26:24 +08:00
gitea-actions bot commented 2026-07-27 16:57:07 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1004 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1004 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 38s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 48s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m16s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m52s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 44s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 34s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m6s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m13s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m54s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m19s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 14s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m56s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 7m15s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 34s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1004
Delete Branch "refactor/use-step4-title-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?