xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 8 Pull Requests 1 Actions 2 Packages Projects Releases 7 Wiki Activity

fix(ci): 同步daily-check和acr-cleanup的docker兼容性修复到main #1012

Merged
xiaoxia merged 2 commits from fix/ci-workflow-docker-main-sync into main 2026-07-27 08:46:05 +08:00
Conversation 2 Commits 2 Files Changed 2
+15 -130
xiaoxia commented 2026-07-27 07:57:33 +08:00
Owner
Copy Link
Copy Source

cherry-pick #981的核心修复到main分支，用于schedule类workflow的最终验证。

修复内容：

  • daily-check.yml: checkout步骤改为curl下载step_checkout.sh方式，兼容docker runner
  • acr-cleanup.yml: 同上，修复Setup Python秒败问题

相关PR: #981
相关工单: #980

cherry-pick #981的核心修复到main分支，用于schedule类workflow的最终验证。 修复内容： - daily-check.yml: checkout步骤改为curl下载step_checkout.sh方式，兼容docker runner - acr-cleanup.yml: 同上，修复Setup Python秒败问题 相关PR: #981 相关工单: #980
xiaoxia added 2 commits 2026-07-27 07:57:33 +08:00
fix(ci): docker runner兼容性修复 - daily-check.yml 490eaca7e5
fix(ci): docker runner兼容性修复 - acr-cleanup.yml
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 11s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 59s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 56s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 29s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 56s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m2s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 2m52s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m15s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m29s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m27s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m53s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 22s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
540463d873
auto-approve-bot commented 2026-07-27 08:26:01 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1012

⚠️ 问题（3个需要修改）

  1. .gitea/workflows/acr-cleanup.yml 第41行, .gitea/workflows/daily-check.yml 第30/101/211行：curl 命令缺少 -f (fail) 参数。如果 API 返回 404 或 500 错误，curl 默认会将错误页面 HTML 输出到 stdout 并返回 0，导致 bash 尝试解析执行 HTML 代码，产生难以排查的错误或安全风险。
  2. .gitea/workflows/acr-cleanup.yml 第41行, .gitea/workflows/daily-check.yml 第30/101/211行：移除了原有的 Python 脚本中实现的健壮的重试机制（5次重试、指数退避）。新的 curl 命令没有重试逻辑，在网络不稳定的环境下极易导致 CI 流水线失败。
  3. .gitea/workflows/acr-cleanup.yml 第36-41行：移除了 actions/setup-python@v5 步骤。如果该 Job 的后续步骤依赖 Python 3.12 环境，现在将完全依赖 Runner 镜像预装的 Python 版本，存在环境不一致导致构建失败的风险。

💡 建议（1个可选）

  1. .gitea/workflows/acr-cleanup.yml 第41行, .gitea/workflows/daily-check.yml 第30/101/211行：直接使用 curl ... | bash 存在供应链安全风险（如脚本被篡改或中间人攻击）。建议改为下载脚本到临时文件后执行，或者使用 bash <(curl ... -f) 以减少管道带来的不确定性，并确保 curl 失败时流程终止。

❌ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 00:26:01 | 模型:

## 代码审查结果 - PR #1012 ### ⚠️ 问题（3个需要修改） 1. **.gitea/workflows/acr-cleanup.yml 第41行, .gitea/workflows/daily-check.yml 第30/101/211行**：`curl` 命令缺少 `-f` (fail) 参数。如果 API 返回 404 或 500 错误，`curl` 默认会将错误页面 HTML 输出到 stdout 并返回 0，导致 `bash` 尝试解析执行 HTML 代码，产生难以排查的错误或安全风险。 2. **.gitea/workflows/acr-cleanup.yml 第41行, .gitea/workflows/daily-check.yml 第30/101/211行**：移除了原有的 Python 脚本中实现的健壮的重试机制（5次重试、指数退避）。新的 `curl` 命令没有重试逻辑，在网络不稳定的环境下极易导致 CI 流水线失败。 3. **.gitea/workflows/acr-cleanup.yml 第36-41行**：移除了 `actions/setup-python@v5` 步骤。如果该 Job 的后续步骤依赖 Python 3.12 环境，现在将完全依赖 Runner 镜像预装的 Python 版本，存在环境不一致导致构建失败的风险。 ### 💡 建议（1个可选） 1. **.gitea/workflows/acr-cleanup.yml 第41行, .gitea/workflows/daily-check.yml 第30/101/211行**：直接使用 `curl ... | bash` 存在供应链安全风险（如脚本被篡改或中间人攻击）。建议改为下载脚本到临时文件后执行，或者使用 `bash <(curl ... -f)` 以减少管道带来的不确定性，并确保 `curl` 失败时流程终止。 --- ❌ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 00:26:01 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit 77704e7ec6 into main 2026-07-27 08:46:05 +08:00
xiaoxia deleted branch fix/ci-workflow-docker-main-sync 2026-07-27 08:46:05 +08:00
gitea-actions bot commented 2026-07-27 09:12:54 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1012 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1012 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1012
Delete Branch "fix/ci-workflow-docker-main-sync"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?