xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

test(wave129): asset_scoring资产评分 + 64单测 #1032

Closed
xiaoxia wants to merge 1 commits from test/wave129-asset-scoring into develop
pull from: test/wave129-asset-scoring
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 1
+515
xiaoxia commented 2026-07-27 13:37:50 +08:00
Owner
Copy Link
Copy Source

wave129: asset_scoring 资产评分模块单测覆盖

测试覆盖

模块 用例数 覆盖场景
权重验证 2 权重和=1 / quality权重最高
分辨率评分 9 目标/超目标/720p/480p/None/0/自定义目标/范围/最低分
时长评分 9 最佳区间/太短/越短越低/接近最佳/太长/超长兜底/None/0/负数
码率评分 6 最佳区间/低码率/高码率/None/文件大小0/时长0
加权总分 5 全满分/全0/计算验证/质量主导/4位小数舍入
单素材评分 5 正常/未知质量/满分质量/0分质量/自定义目标
时长分桶 7 short/medium/long/边界值/unknown
多样性选择 10 空列表/0数量/负数/多桶分布/去重/不超量/不足回退/单桶/最高分优先/包含全局高分
候选过滤 10 ready通过/非ready过滤/非video过滤/video前缀/低质量计数/None质量通过/门槛值通过/空列表/None mime
数据类 2 ScoreDetail / SmartSelectResult
合计 64

说明

  • 纯逻辑模块，无外部依赖，测试全绿
  • 所有边界值和异常输入均已覆盖
## wave129: asset_scoring 资产评分模块单测覆盖 ### 测试覆盖 | 模块 | 用例数 | 覆盖场景 | |------|--------|----------| | 权重验证 | 2 | 权重和=1 / quality权重最高 | | 分辨率评分 | 9 | 目标/超目标/720p/480p/None/0/自定义目标/范围/最低分 | | 时长评分 | 9 | 最佳区间/太短/越短越低/接近最佳/太长/超长兜底/None/0/负数 | | 码率评分 | 6 | 最佳区间/低码率/高码率/None/文件大小0/时长0 | | 加权总分 | 5 | 全满分/全0/计算验证/质量主导/4位小数舍入 | | 单素材评分 | 5 | 正常/未知质量/满分质量/0分质量/自定义目标 | | 时长分桶 | 7 | short/medium/long/边界值/unknown | | 多样性选择 | 10 | 空列表/0数量/负数/多桶分布/去重/不超量/不足回退/单桶/最高分优先/包含全局高分 | | 候选过滤 | 10 | ready通过/非ready过滤/非video过滤/video前缀/低质量计数/None质量通过/门槛值通过/空列表/None mime | | 数据类 | 2 | ScoreDetail / SmartSelectResult | | **合计** | **64** | | ### 说明 - 纯逻辑模块，无外部依赖，测试全绿 - 所有边界值和异常输入均已覆盖
gitea-actions bot commented 2026-07-27 16:26:05 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1032
预览链接 https://pr-1032.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1032 | | 预览链接 | [https://pr-1032.preview.xiaoxiajianji.com](https://pr-1032.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-07-27 18:27:07 +08:00
test(wave129): asset_scoring资产评分+64单测
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 5s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m32s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 31s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m41s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m36s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 1s
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 38s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m55s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 36s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m40s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
22d80f3d94 
- 覆盖8大模块：权重/分辨率评分/时长评分/码率评分/加权总分/单素材评分/分桶/多样性选择/候选过滤/数据类
- 边界值全覆盖：0/None/负数/临界值/最佳区间
- 多样性选择验证：多桶分布/去重/配额/不足时回退
xiaoxia force-pushed test/wave129-asset-scoring from 9ea3bbdb63 to 22d80f3d94 2026-07-27 18:27:07 +08:00 Compare
xiaoxia closed this pull request 2026-07-27 18:30:27 +08:00
auto-approve-bot commented 2026-07-27 20:00:56 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1032

⚠️ 问题（0个需要修改）

无

💡 建议（2个可选）

  1. tests/unit/test_asset_scoring_domain.py 第36行：建议避免测试私有函数 _bucket_by_duration

    • 原因：以下划线开头的函数通常被视为内部实现细节。直接测试私有函数会导致测试代码与实现细节强耦合，不利于后续重构（如修改函数名或内部逻辑时测试即失败）。
    • 建议：建议通过测试公共接口 diverse_selection 的行为来间接验证分桶逻辑的正确性，或者如果该逻辑足够复杂且必须独立验证，考虑将其提升为模块级公共函数。

  2. tests/unit/test_asset_scoring_domain.py 第432行：建议修正 MockAsset 中的类型注解与实际使用不符的问题

    • 原因：MockAsset 中定义 mime_type: str = "video/mp4"，但在测试用例中传入 None 并使用了 # type: ignore 来绕过检查。这种做法掩盖了类型系统的优势，如果被测函数 filter_candidates 实际上不处理 None 值（例如直接调用 .startswith()），测试可能掩盖了潜在的运行时错误。
    • 建议：如果 None 是有效的边界输入，应将类型注解修改为 mime_type: str | None = "video/mp4"，并移除 type: ignore 注释。

✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 12:00:55 | 模型:

## 代码审查结果 - PR #1032 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（2个可选） 1. **tests/unit/test_asset_scoring_domain.py 第36行**：建议避免测试私有函数 `_bucket_by_duration` - **原因**：以下划线开头的函数通常被视为内部实现细节。直接测试私有函数会导致测试代码与实现细节强耦合，不利于后续重构（如修改函数名或内部逻辑时测试即失败）。 - **建议**：建议通过测试公共接口 `diverse_selection` 的行为来间接验证分桶逻辑的正确性，或者如果该逻辑足够复杂且必须独立验证，考虑将其提升为模块级公共函数。 2. **tests/unit/test_asset_scoring_domain.py 第432行**：建议修正 `MockAsset` 中的类型注解与实际使用不符的问题 - **原因**：`MockAsset` 中定义 `mime_type: str = "video/mp4"`，但在测试用例中传入 `None` 并使用了 `# type: ignore` 来绕过检查。这种做法掩盖了类型系统的优势，如果被测函数 `filter_candidates` 实际上不处理 `None` 值（例如直接调用 `.startswith()`），测试可能掩盖了潜在的运行时错误。 - **建议**：如果 `None` 是有效的边界输入，应将类型注解修改为 `mime_type: str | None = "video/mp4"`，并移除 `type: ignore` 注释。 --- ✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 12:00:55 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-27 20:03:56 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1032 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1032 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 5s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m32s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 31s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m41s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m36s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 1s
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 38s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m55s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 36s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m40s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1032
Delete Branch "test/wave129-asset-scoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?