xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(ci): 修复CI Gate失败时返回exit 0的P0 Bug (develop) #1058

Merged
xiaoxia merged 1 commits from fix/ci-gate-exit-code-develop into develop 2026-07-28 13:33:26 +08:00
Conversation 3 Commits 1 Files Changed 1
+1 -1
xiaoxia commented 2026-07-28 10:13:47 +08:00
Owner
Copy Link
Copy Source

问题描述

CI Gate判断失败时脚本错误地写了exit 0，导致所有PR不管CI失败成什么样，Gate永远显示success，分支保护完全失效。

铁证

  • #1051 Code Quality=failure，但CI Gate=success
  • 日志输出"❌ CI Gate: FAILED"但最终"🏁 Job succeeded"

修复

.gitea/workflows/ci-pipeline.yml L1808：将失败分支的exit 0改为exit 1

影响

main + develop双分支都有此问题，本PR修复develop分支。

## 问题描述 CI Gate判断失败时脚本错误地写了`exit 0`，导致所有PR不管CI失败成什么样，Gate永远显示success，分支保护完全失效。 ## 铁证 - #1051 Code Quality=failure，但CI Gate=success - 日志输出"❌ CI Gate: FAILED"但最终"🏁 Job succeeded" ## 修复 `.gitea/workflows/ci-pipeline.yml` L1808：将失败分支的`exit 0`改为`exit 1` ## 影响 main + develop双分支都有此问题，本PR修复develop分支。
xiaoxia added 1 commit 2026-07-28 10:13:47 +08:00
fix(ci): 修复CI Gate失败时返回exit 0而非exit 1的P0 Bug
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 37s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m29s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m39s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m44s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m17s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m56s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m31s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m25s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 5m19s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 7m24s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 4m18s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m3s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 46m54s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 5s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 37s
Details
862340ace5
auto-approve-bot commented 2026-07-28 10:26:00 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  • 修复了 CI 流水线中的关键逻辑错误。将检测到失败项时的退出码从 exit 0 修改为 exit 1，确保了当 CI Gate 判定失败时，能够正确终止流程并反馈错误状态，避免了“失败却误判为成功”的严重隐患。

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 02:26:00 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 - 修复了 CI 流水线中的关键逻辑错误。将检测到失败项时的退出码从 `exit 0` 修改为 `exit 1`，确保了当 CI Gate 判定失败时，能够正确终止流程并反馈错误状态，避免了“失败却误判为成功”的严重隐患。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 02:26:00 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-28 10:27:00 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1058
预览链接 https://pr-1058.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1058 | | 预览链接 | [https://pr-1058.preview.xiaoxiajianji.com](https://pr-1058.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia merged commit d4c3743e45 into develop 2026-07-28 13:33:26 +08:00
gitea-actions bot commented 2026-07-28 13:38:34 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1058 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1058 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1058
Delete Branch "fix/ci-gate-exit-code-develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?