xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 8 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

test(wave146): trim_config 单测补全 +78 #1069

Merged
auto-approve-bot merged 1 commits from test/wave146-trim-config into develop 2026-07-28 12:23:46 +08:00
Conversation 3 Commits 1 Files Changed 1
+471 -255
xiaoxia commented 2026-07-28 10:50:24 +08:00
Owner
Copy Link
Copy Source

变更说明

trim_config 裁剪配置领域模型单测补全，新增78个测试用例。

测试覆盖

  • TrimConfig.from_dict (11): None/空/全0、三选二组合、单参数语义、字符串/None值兼容
  • validate_and_resolve (14): 三选二推导(5种场景)、start负钳制、end超时长、start超时长、start>=end无效、0/负素材时长、精确时长、duration非负
  • 属性 (9): is_valid(有效/0/阈值/低于阈值)、is_noop(3种)、trim_from_start(3种)
  • TrimSegment.from_dict (4): 基础、默认order、缺segment_id、duration
  • build_video_trim_filter (6): noop、start+duration、only_start、from_start、标签保持、三位小数精度
  • build_audio_trim_filter (4): noop、start+duration、only_duration、用atrim而非trim
  • resolve_segments (6): 空/单段/多段排序/过滤无效段/负order/边界钳制
  • parse_segments_from_config (8): None/空/多段/空列表/非列表/单段/多段优先/过滤非dict
  • extract_trim_from_clip_config (8): None/空/trim子字典/扁平字段/子字典优先/非dict回退/无裁剪字段

本地验证

  • pytest: 78 passed
  • black: 已格式化
## 变更说明 trim_config 裁剪配置领域模型单测补全，新增78个测试用例。 ## 测试覆盖 - **TrimConfig.from_dict** (11): None/空/全0、三选二组合、单参数语义、字符串/None值兼容 - **validate_and_resolve** (14): 三选二推导(5种场景)、start负钳制、end超时长、start超时长、start>=end无效、0/负素材时长、精确时长、duration非负 - **属性** (9): is_valid(有效/0/阈值/低于阈值)、is_noop(3种)、trim_from_start(3种) - **TrimSegment.from_dict** (4): 基础、默认order、缺segment_id、duration - **build_video_trim_filter** (6): noop、start+duration、only_start、from_start、标签保持、三位小数精度 - **build_audio_trim_filter** (4): noop、start+duration、only_duration、用atrim而非trim - **resolve_segments** (6): 空/单段/多段排序/过滤无效段/负order/边界钳制 - **parse_segments_from_config** (8): None/空/多段/空列表/非列表/单段/多段优先/过滤非dict - **extract_trim_from_clip_config** (8): None/空/trim子字典/扁平字段/子字典优先/非dict回退/无裁剪字段 ## 本地验证 - pytest: 78 passed - black: 已格式化
xiaoxia added 1 commit 2026-07-28 10:50:24 +08:00
test(wave146): add trim_config unit tests (+78)
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 4s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m52s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m14s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 30s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 29s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 52s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m6s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m11s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m3s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 4m28s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m2s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 4m5s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 7s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 43m19s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m14s
Details
ffb9db32af 
- TrimConfig.from_dict: None/空/全0、start+end/duration/end二组合、单参数、字符串/None值
- validate_and_resolve: 三选二推导(5种场景)、start负钳制、end超时长、start超时长、
  start>=end无效、0/负素材时长、精确时长、duration非负
- 属性: is_valid(有效/0/阈值/低于阈值)、is_noop(3种)、trim_from_start(3种)
- TrimSegment.from_dict: 基础、默认order、缺segment_id、duration
- build_video_trim_filter: noop、start+duration、only_start、from_start、标签保持、精度
- build_audio_trim_filter: noop、start+duration、only_duration、用atrim
- resolve_segments: 空/单段/多段排序/过滤无效段/负order/边界钳制
- parse_segments_from_config: None/空/多段/空列表/非列表/单段/多段优先/过滤非dict
- extract_trim_from_clip_config: None/空/trim子字典/扁平字段/子字典优先/非dict回退/无字段
gitea-actions bot commented 2026-07-28 11:41:35 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1069
预览链接 https://pr-1069.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1069 | | 预览链接 | [https://pr-1069.preview.xiaoxiajianji.com](https://pr-1069.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-28 11:44:12 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. 测试覆盖全面：新增的测试用例覆盖了 TrimConfig 的各种组合（三选二推导）、边界条件（负数、超限、0值）以及异常输入（None、字符串），体现了高质量的测试思维。
  2. 注释清晰：每个测试方法都添加了清晰的中文文档字符串，说明了测试意图，大大提高了代码的可读性和可维护性。
  3. 结构化良好：测试类和方法组织合理，按功能模块划分（如 TestTrimConfigFromDict, TestTrimConfigValidateAndResolve），便于定位和扩展。

🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 03:44:12 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **测试覆盖全面**：新增的测试用例覆盖了 `TrimConfig` 的各种组合（三选二推导）、边界条件（负数、超限、0值）以及异常输入（None、字符串），体现了高质量的测试思维。 2. **注释清晰**：每个测试方法都添加了清晰的中文文档字符串，说明了测试意图，大大提高了代码的可读性和可维护性。 3. **结构化良好**：测试类和方法组织合理，按功能模块划分（如 `TestTrimConfigFromDict`, `TestTrimConfigValidateAndResolve`），便于定位和扩展。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-28 03:44:12 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot merged commit e2ddc679bb into develop 2026-07-28 12:23:46 +08:00
auto-approve-bot deleted branch test/wave146-trim-config 2026-07-28 12:23:46 +08:00
gitea-actions bot commented 2026-07-28 12:41:36 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1069 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1069 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1069
Delete Branch "test/wave146-trim-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?