fix(#1197): 第3步生成预览增加真正的预览生成逻辑,禁止直接跳过 #1200

Merged
auto-approve-bot merged 11 commits from fix/step3-preview-generation into develop 2026-07-30 17:06:12 +08:00
Owner

问题

第3步「生成预览」只是静态信息展示,用户点下一步直接跳过,没有真正的预览生成过程

修改内容

  1. useStep3Preview.ts: 重写hook,增加预览生成状态机(idle/generating/ready/error),目前为mock实现(1.5s模拟生成),预留后端接口位置
  2. Step3GeneratePreview.tsx: 重构组件,支持4种状态展示:未生成(生成按钮)/生成中/生成失败/生成成功(预览详情)
  3. useStepNavigation.ts: Step3增加校验,必须先生成预览才能进入下一步
  4. GenerateStepContent.tsx: 传递Step3预览相关props
  5. GeneratePage.tsx: 集成useStep3Preview hook,贯通预览状态
  6. generate.css: 新增预览生成相关样式(生成按钮区、加载状态、错误状态、重新生成按钮)

待后端对齐

  • 预览生成接口:POST /generate-preview(入参:template_id, material_ids, duration, video_ratio, style;出参:preview_id, status, clip_count, preview_video_url)
  • 后端接口就绪后,替换useStep3Preview中的mock逻辑即可

影响范围

  • 智能剪辑生成向导第3步
  • 仅前端改动,不影响后端
## 问题 第3步「生成预览」只是静态信息展示,用户点下一步直接跳过,没有真正的预览生成过程 ## 修改内容 1. **useStep3Preview.ts**: 重写hook,增加预览生成状态机(idle/generating/ready/error),目前为mock实现(1.5s模拟生成),预留后端接口位置 2. **Step3GeneratePreview.tsx**: 重构组件,支持4种状态展示:未生成(生成按钮)/生成中/生成失败/生成成功(预览详情) 3. **useStepNavigation.ts**: Step3增加校验,必须先生成预览才能进入下一步 4. **GenerateStepContent.tsx**: 传递Step3预览相关props 5. **GeneratePage.tsx**: 集成useStep3Preview hook,贯通预览状态 6. **generate.css**: 新增预览生成相关样式(生成按钮区、加载状态、错误状态、重新生成按钮) ## 待后端对齐 - 预览生成接口:POST /generate-preview(入参:template_id, material_ids, duration, video_ratio, style;出参:preview_id, status, clip_count, preview_video_url) - 后端接口就绪后,替换useStep3Preview中的mock逻辑即可 ## 影响范围 - 智能剪辑生成向导第3步 - 仅前端改动,不影响后端
xiaoxia added 6 commits 2026-07-30 14:01:49 +08:00
fix(#1197): 增加Step3预览生成相关CSS样式(生成按钮/加载/错误状态)
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 38s
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 32s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m13s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 53s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m35s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m41s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m43s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m52s
AI Code Review / AI Code Review (pull_request) Failing after 2m23s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m11s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m28s
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Failing after 1m26s
e7b28623d6

🚀 预览环境已部署

项目 详情
PR号 #1200
预览链接 https://pr-1200.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1200 | | 预览链接 | [https://pr-1200.preview.xiaoxiajianji.com](https://pr-1200.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
xiaoxia added 1 commit 2026-07-30 14:29:15 +08:00
fix(#1197): 参数变化时重置预览状态 + 校验失败展示错误提示
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 28s
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 52s
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m32s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m18s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m34s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m47s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m38s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m37s
AI Code Review / AI Code Review (pull_request) Failing after 1m52s
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m35s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m32s
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Failing after 7s
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
e8b210504e
xiaoxia added 1 commit 2026-07-30 15:42:36 +08:00
fix(#1197): Prettier格式对齐 + 预览生成请求ID竞态防护
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 10s
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m6s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m7s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m10s
AI Code Review / AI Code Review (pull_request) Successful in 1m46s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m16s
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m47s
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 26s
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m23s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m27s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m49s
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Failing after 6s
72f4be0b3c
xiaoxia added 1 commit 2026-07-30 15:53:35 +08:00
xiaoxia added 1 commit 2026-07-30 15:53:35 +08:00
fix(#1197): Prettier格式对齐
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m37s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m38s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m59s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 1m27s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m47s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m23s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m27s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m52s
AI Code Review / AI Code Review (pull_request) Successful in 4m16s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m22s
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Failing after 5s
5335d60193
auto-approve-bot approved these changes 2026-07-30 15:55:59 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot approved these changes 2026-07-30 15:55:59 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
Collaborator

【阻塞级判定】

  • 是否存在阻塞级问题:否
  • 阻塞级问题数量:0 个

📊 审查概览

  • 整体评价:通过
  • 建议级问题数量:2 个

🔴 阻塞级问题(必须修复)

💡 改进建议(不阻塞合并)

  1. [apps/web/src/pages/generate/hooks/useStep3Preview.ts: useEffect依赖项] 优化 useEffect 依赖项

    • 具体内容:useEffect 的依赖项数组中包含了 previewStatus。该 Effect 的主要目的是监听输入参数(如模板、素材)的变化来重置预览状态。包含 previewStatus 会导致每次预览状态改变(如从 generating 变为 ready)时都触发 Effect 重新执行,虽然逻辑上有保护机制不会出错,但属于不必要的性能开销。建议移除 previewStatus,仅在输入参数变化时执行重置逻辑。
  2. [apps/web/src/pages/generate/hooks/useStepNavigation.ts: 末尾导出] 移除多余的默认导出

    • 具体内容:文件末尾添加了 export default useStepNavigation。该文件主要使用命名导出 export const useStepNavigation。添加默认导出容易造成导入时的混淆(如 import useStepNavigation from ... vs import { useStepNavigation } from ...),建议保持一致性,移除默认导出。

良好实践

  • 竞态条件处理:在 useStep3Preview 中使用了 requestIdRef 来处理异步请求的竞态问题,防止旧请求的结果覆盖新请求的状态,这是处理异步状态更新的最佳实践。
  • 状态重置逻辑:在关键参数(模板、素材等)发生变化时,能够自动重置预览状态,避免了用户在修改参数后看到旧预览数据的问题。
  • 导航守卫:在 useStepNavigation 中增加了 previewReady 的校验,强制用户必须生成预览后才能进入下一步,符合业务流程逻辑。

格式检查通过 | 逻辑审查通过 | 性能良好


🤖 由 AI 代码审查机器人自动生成 | 2026-07-30 07:57:52 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题:否 - 阻塞级问题数量:0 个 ### 📊 审查概览 - 整体评价:通过 - 建议级问题数量:2 个 ### 🔴 阻塞级问题(必须修复) 无 ### 💡 改进建议(不阻塞合并) 1. **[apps/web/src/pages/generate/hooks/useStep3Preview.ts: useEffect依赖项] 优化 useEffect 依赖项** - 具体内容:`useEffect` 的依赖项数组中包含了 `previewStatus`。该 Effect 的主要目的是监听输入参数(如模板、素材)的变化来重置预览状态。包含 `previewStatus` 会导致每次预览状态改变(如从 `generating` 变为 `ready`)时都触发 Effect 重新执行,虽然逻辑上有保护机制不会出错,但属于不必要的性能开销。建议移除 `previewStatus`,仅在输入参数变化时执行重置逻辑。 2. **[apps/web/src/pages/generate/hooks/useStepNavigation.ts: 末尾导出] 移除多余的默认导出** - 具体内容:文件末尾添加了 `export default useStepNavigation`。该文件主要使用命名导出 `export const useStepNavigation`。添加默认导出容易造成导入时的混淆(如 `import useStepNavigation from ...` vs `import { useStepNavigation } from ...`),建议保持一致性,移除默认导出。 ### ✅ 良好实践 - **竞态条件处理**:在 `useStep3Preview` 中使用了 `requestIdRef` 来处理异步请求的竞态问题,防止旧请求的结果覆盖新请求的状态,这是处理异步状态更新的最佳实践。 - **状态重置逻辑**:在关键参数(模板、素材等)发生变化时,能够自动重置预览状态,避免了用户在修改参数后看到旧预览数据的问题。 - **导航守卫**:在 `useStepNavigation` 中增加了 `previewReady` 的校验,强制用户必须生成预览后才能进入下一步,符合业务流程逻辑。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-30 07:57:52 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia added 1 commit 2026-07-30 16:58:33 +08:00
test: 添加Step3预览生成smoke test以修复vitest related匹配
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 50s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m39s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m1s
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 32s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 51s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m2s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m8s
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m20s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m45s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 5m58s
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
AI Code Review / AI Code Review (pull_request) Successful in 6m27s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 11s
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 11s
91cb26b4cd
auto-approve-bot merged commit a05cc94fdb into develop 2026-07-30 17:06:12 +08:00
auto-approve-bot deleted branch fix/step3-preview-generation 2026-07-30 17:06:12 +08:00

🗑️ 预览环境已清理

PR #1200 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1200 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.