xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 4 Actions 5 Packages Projects Releases 7 Wiki Activity

fix(title): 预设样式解耦字号 + 右侧标题实时预览 #1232

Merged
xiaoxia merged 3 commits from fix/title-preset-decouple-and-preview into develop 2026-08-04 10:09:23 +08:00
Conversation 5 Commits 3 Files Changed 3
+85 -2
xiaoxia commented 2026-08-04 10:03:48 +08:00
Owner
Copy Link
Copy Source

修改内容

任务1：预设样式不再绑定字号

  • 文件：useTitleStyleUpdaters.ts
  • applyPreset：去掉 size: preset.style.size，预设只覆盖 color/bold/italic/stroke/shadow，字号保持不变
  • getActivePreset：匹配条件去掉 settings.size === p.style.size，只用 color/bold/italic/stroke/shadow 匹配预设
  • constants.ts 中 TITLE_PRESETS 的 style.size 保留作为推荐字号（初始值），不变

任务2：标题选择后实时预览

  • 文件：PreviewVideoPanel.tsx
    • 新增 props：titleText: string、titleSettings: TitleSettings
    • 预览视频下方新增标题预览区域
    • 样式完全按照 titleSettings 渲染：字体、字号、颜色、粗体、斜体、描边（WebkitTextStroke）、阴影（textShadow）
    • 位置根据 titleSettings.position（top/center/bottom）调整
    • 空标题显示"请选择或输入标题"占位
  • 文件：GeneratePage.tsx
    • 向 PreviewVideoPanel 传递 titleText={titleSettings.title} 和 titleSettings={titleSettings}

验收

  • 切换预设时字号不跟着变
  • 改标题文字/字号/颜色/位置等，右侧预览实时同步
## 修改内容 ### 任务1：预设样式不再绑定字号 - **文件**：`useTitleStyleUpdaters.ts` - `applyPreset`：去掉 `size: preset.style.size`，预设只覆盖 color/bold/italic/stroke/shadow，字号保持不变 - `getActivePreset`：匹配条件去掉 `settings.size === p.style.size`，只用 color/bold/italic/stroke/shadow 匹配预设 - `constants.ts` 中 TITLE_PRESETS 的 style.size 保留作为推荐字号（初始值），不变 ### 任务2：标题选择后实时预览 - **文件**：`PreviewVideoPanel.tsx` - 新增 props：`titleText: string`、`titleSettings: TitleSettings` - 预览视频下方新增标题预览区域 - 样式完全按照 titleSettings 渲染：字体、字号、颜色、粗体、斜体、描边（WebkitTextStroke）、阴影（textShadow） - 位置根据 titleSettings.position（top/center/bottom）调整 - 空标题显示"请选择或输入标题"占位 - **文件**：`GeneratePage.tsx` - 向 PreviewVideoPanel 传递 `titleText={titleSettings.title}` 和 `titleSettings={titleSettings}` ## 验收 - 切换预设时字号不跟着变 - 改标题文字/字号/颜色/位置等，右侧预览实时同步
xiaoxia added 3 commits 2026-08-04 10:03:48 +08:00
fix(title): 预设样式不再绑定字号，applyPreset/getActivePreset去掉size匹配 cc072bf22d
feat(title): PreviewVideoPanel新增标题实时预览区域，支持样式渲染 c29119e179
feat(title): GeneratePage向PreviewVideoPanel传递titleText和titleSettings
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 41s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m2s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m2s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m35s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m0s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m49s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m59s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m20s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m43s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m28s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m5s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 11s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 41s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m13s
Details
3687da034d
gitea-actions bot commented 2026-08-04 10:05:20 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1232
预览链接 https://pr-1232.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1232 | | 预览链接 | [https://pr-1232.preview.xiaoxiajianji.com](https://pr-1232.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-04 10:05:37 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-04 10:05:37 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot commented 2026-08-04 10:06:16 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1232

⚠️ 问题（1个需要修改）

  1. PreviewVideoPanel.tsx 第33行：fontSize 计算存在逻辑漏洞。当 settings.size 为 undefined 或 null 时（例如 titleSettings 为空对象 {} 或初始化不完整），Math.min(undefined, 36) 返回 NaN，导致字体样式失效，文字可能不可见或异常。应增加默认值处理（如 settings.size || 16）。

💡 建议（2个可选）

  1. PreviewVideoPanel.tsx 第135行：showTitlePreview 的判断条件 !!titleSettings 过于宽松。如果传入空对象 {}，条件依然为真，但后续渲染可能出错。建议增加对关键字段（如 size）的检查，或者确保父组件传入的 titleSettings 结构完整。
  2. PreviewVideoPanel.tsx 第21-26行：positionAlignStyle 函数中使用了魔法数字（如 paddingTop: 16），建议提取为常量以提高代码可维护性。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-08-04 02:06:16 | 模型:

## 代码审查结果 - PR #1232 ### ⚠️ 问题（1个需要修改） 1. **PreviewVideoPanel.tsx 第33行**：`fontSize` 计算存在逻辑漏洞。当 `settings.size` 为 `undefined` 或 `null` 时（例如 `titleSettings` 为空对象 `{}` 或初始化不完整），`Math.min(undefined, 36)` 返回 `NaN`，导致字体样式失效，文字可能不可见或异常。应增加默认值处理（如 `settings.size || 16`）。 ### 💡 建议（2个可选） 1. **PreviewVideoPanel.tsx 第135行**：`showTitlePreview` 的判断条件 `!!titleSettings` 过于宽松。如果传入空对象 `{}`，条件依然为真，但后续渲染可能出错。建议增加对关键字段（如 `size`）的检查，或者确保父组件传入的 `titleSettings` 结构完整。 2. **PreviewVideoPanel.tsx 第21-26行**：`positionAlignStyle` 函数中使用了魔法数字（如 `paddingTop: 16`），建议提取为常量以提高代码可维护性。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-04 02:06:16 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit 7ef1299f64 into develop 2026-08-04 10:09:23 +08:00
xiaoxia deleted branch fix/title-preset-decouple-and-preview 2026-08-04 10:09:23 +08:00
gitea-actions bot commented 2026-08-04 10:10:35 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1232 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1232 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1232
Delete Branch "fix/title-preset-decouple-and-preview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?