xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: 更新 test_render_adapter.py 中 ASR mock 路径以匹配 PR #1307 #1309

Merged
auto-approve-bot merged 1 commits from fix/pr-1307-test-import-path into develop 2026-08-08 21:01:00 +08:00
Conversation 5 Commits 1 Files Changed 1
+3 -3
xiaoxia commented 2026-08-08 20:51:59 +08:00
Owner
Copy Link
Copy Source

问题

PR #1307 将 render_adapter.py 中的 import 路径从 services.asr_service_factory 改为 apps.worker.services.asr_service_factory，但测试文件中的 mock 路径未同步更新，导致 Unit Tests 失败。

修复

更新 TestGetAsrService 类中 3 处 patch 路径：

  • services.asr_service_factory.get_asr_service → apps.worker.services.asr_service_factory.get_asr_service

关联

## 问题 PR #1307 将 `render_adapter.py` 中的 import 路径从 `services.asr_service_factory` 改为 `apps.worker.services.asr_service_factory`，但测试文件中的 mock 路径未同步更新，导致 Unit Tests 失败。 ## 修复 更新 `TestGetAsrService` 类中 3 处 patch 路径： - `services.asr_service_factory.get_asr_service` → `apps.worker.services.asr_service_factory.get_asr_service` ## 关联 - PR #1307 - Issue #1294
xiaoxia added 1 commit 2026-08-08 20:51:59 +08:00
fix: 更新 test_render_adapter.py 中 ASR mock 路径以匹配 PR #1307
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 30s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 56s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 56s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m22s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m27s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m37s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m2s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m15s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m30s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m4s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m14s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m14s
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 53s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 2m7s
Details
55c768bbd7 
PR #1307 将 render_adapter.py 中的 import 路径从 services.asr_service_factory
改为 apps.worker.services.asr_service_factory，但测试文件中的 mock 路径未同步更新，
导致 Unit Tests 失败。

修复：更新 TestGetAsrService 类中 3 处 patch 路径
auto-approve-bot commented 2026-08-08 20:53:21 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. Mock 路径修正准确：将 mock 路径从 services.asr_service_factory 修正为 apps.worker.services.asr_service_factory，这通常是修复测试中因模块导入路径变更导致的 Mock 失效问题，确保了测试覆盖的是正确的代码路径。
  2. 测试覆盖完整：三个测试用例分别覆盖了服务正常返回、导入失败、初始化失败三种场景，边界条件考虑周全。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-08 12:53:21 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **Mock 路径修正准确**：将 mock 路径从 `services.asr_service_factory` 修正为 `apps.worker.services.asr_service_factory`，这通常是修复测试中因模块导入路径变更导致的 Mock 失效问题，确保了测试覆盖的是正确的代码路径。 2. **测试覆盖完整**：三个测试用例分别覆盖了服务正常返回、导入失败、初始化失败三种场景，边界条件考虑周全。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-08 12:53:21 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-08 20:53:27 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1309
预览链接 https://pr-1309.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1309 | | 预览链接 | [https://pr-1309.preview.xiaoxiajianji.com](https://pr-1309.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-08 21:00:29 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-08 21:00:29 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 9c7bf7f67f into develop 2026-08-08 21:01:00 +08:00
auto-approve-bot deleted branch fix/pr-1307-test-import-path 2026-08-08 21:01:00 +08:00
gitea-actions bot commented 2026-08-08 21:01:52 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1309 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1309 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1309
Delete Branch "fix/pr-1307-test-import-path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?