xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 4 Actions 2 Packages Projects Releases 7 Wiki Activity

fix: Modal 组件默认居中 + 4 个弹窗统一使用 Modal 封装 #1325

Merged
auto-approve-bot merged 1 commits from fix/modal-centered-and-unify into develop 2026-08-09 22:01:06 +08:00
Conversation 6 Commits 1 Files Changed 5
+15 -14
xiaoxia commented 2026-08-09 21:55:52 +08:00
Owner
Copy Link
Copy Source

修复内容

#1319 — Modal 组件默认居中

  • components/ui/Modal.tsx 添加 centered = true 默认值
  • 修复弹窗偏移/裁剪问题，全局所有使用 Modal 的弹窗受益

#1318 — 4 个弹窗统一使用 Modal 封装

以下弹窗从 import { Modal as AntModal } from "antd" 改为 import Modal from "@/components/ui/Modal"：

  • AIGenerateModal.tsx
  • CreateTitleModal.tsx
  • PlayModal.tsx
  • BatchClassifyModal.tsx

统一走 V21 样式，确保弹窗外观一致。

## 修复内容 ### #1319 — Modal 组件默认居中 - `components/ui/Modal.tsx` 添加 `centered = true` 默认值 - 修复弹窗偏移/裁剪问题，全局所有使用 Modal 的弹窗受益 ### #1318 — 4 个弹窗统一使用 Modal 封装 以下弹窗从 `import { Modal as AntModal } from "antd"` 改为 `import Modal from "@/components/ui/Modal"`： - `AIGenerateModal.tsx` - `CreateTitleModal.tsx` - `PlayModal.tsx` - `BatchClassifyModal.tsx` 统一走 V21 样式，确保弹窗外观一致。
xiaoxia added the bugfrontend labels 2026-08-09 21:55:52 +08:00
xiaoxia added 1 commit 2026-08-09 21:55:52 +08:00
fix: Modal 组件默认居中 + 4 个弹窗统一使用 Modal 封装
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 42s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 48s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 58s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m42s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m43s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m44s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m34s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m18s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m36s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m40s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 47s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 1m1s
Details
15ad1ba514 
#1319: Modal 组件添加 centered=true 默认值，修复弹窗偏移/裁剪
#1318: AIGenerateModal/CreateTitleModal/PlayModal/BatchClassifyModal
  从 antd Modal 改为 @/components/ui/Modal，统一走 V21 样式
gitea-actions bot commented 2026-08-09 21:57:28 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1325
预览链接 https://pr-1325.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1325 | | 预览链接 | [https://pr-1325.preview.xiaoxiajianji.com](https://pr-1325.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-08-09 21:57:32 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：有建议
  • 建议级问题数量：1 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

  1. [apps/web/src/components/ui/Modal.tsx: 25] 默认行为变更确认
    • 具体内容：代码中将 centered 属性的默认值硬编码为 true。Ant Design 原生 Modal 组件的 centered 默认值为 false。此变更将导致所有使用该自定义 Modal 且未显式指定 centered 的弹窗强制变为垂直居中。请确认这是符合项目 UI 设计规范的预期行为。如果是为了保持与旧版本一致，建议移除该默认值或保持与 Antd 一致。

✅ 良好实践

  • 统一将业务组件中的 antd Modal 替换为项目自定义的 @/components/ui/Modal，有利于 UI 风格的统一管理和后续维护。
  • 使用 ...rest 进行 props 透传，确保了 Antd Modal 原有功能的完整性，避免了属性丢失。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-09 13:57:32 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：有建议 - 建议级问题数量：1 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 1. **[apps/web/src/components/ui/Modal.tsx: 25] 默认行为变更确认** - 具体内容：代码中将 `centered` 属性的默认值硬编码为 `true`。Ant Design 原生 Modal 组件的 `centered` 默认值为 `false`。此变更将导致所有使用该自定义 Modal 且未显式指定 `centered` 的弹窗强制变为垂直居中。请确认这是符合项目 UI 设计规范的预期行为。如果是为了保持与旧版本一致，建议移除该默认值或保持与 Antd 一致。 ### ✅ 良好实践 - 统一将业务组件中的 `antd` Modal 替换为项目自定义的 `@/components/ui/Modal`，有利于 UI 风格的统一管理和后续维护。 - 使用 `...rest` 进行 props 透传，确保了 Antd Modal 原有功能的完整性，避免了属性丢失。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-09 13:57:32 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot approved these changes 2026-08-09 21:58:10 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-09 21:58:10 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
xiaoxia commented 2026-08-09 22:00:26 +08:00
Author
Owner
Copy Link
Copy Source

✅ CI 全绿，已 squash merge 到 develop（c3f3f83f）

✅ CI 全绿，已 squash merge 到 develop（`c3f3f83f`）
auto-approve-bot merged commit cd3d8730af into develop 2026-08-09 22:01:06 +08:00
auto-approve-bot deleted branch fix/modal-centered-and-unify 2026-08-09 22:01:06 +08:00
gitea-actions bot commented 2026-08-09 22:01:52 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1325 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1325 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label bug frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1325
Delete Branch "fix/modal-centered-and-unify"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?