xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions 2 Packages Projects Releases 7 Wiki Activity

fix: 移除封面设置中已选模板默认文案 #1340

Closed
xiaoxia wants to merge 1 commits from fix/remove-selected-template-text into develop
pull from: fix/remove-selected-template-text
merge into: xiaoxia:develop
Conversation 4 Commits 1 Files Changed 1
-3
xiaoxia commented 2026-08-11 13:44:40 +08:00
Owner
Copy Link
Copy Source

删除已选模板文案行，清理 selectedTemplateName 解构

删除已选模板文案行，清理 selectedTemplateName 解构
xiaoxia added the bugfrontend labels 2026-08-11 13:44:40 +08:00
xiaoxia added 1 commit 2026-08-11 13:44:40 +08:00
fix: 移除封面设置中'已选模板: 默认'文案
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 30s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m34s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m46s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m55s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m25s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m32s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m3s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m48s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m52s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 12s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Waiting to run
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 57s
Details
1677941cfe
gitea-actions bot commented 2026-08-11 13:46:24 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1340
预览链接 https://pr-1340.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1340 | | 预览链接 | [https://pr-1340.preview.xiaoxiajianji.com](https://pr-1340.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-08-11 13:46:44 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：1 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

  1. [Step6CoverSettings.tsx] 父组件传参检查
    • 具体内容：代码移除了 selectedTemplateName 属性的解构和使用，请同步检查并移除父组件中传递该属性的代码，以避免 React 的 "unknown prop" 警告或 TypeScript 类型检查报错。

✅ 良好实践

  • 及时清理了未使用的 props 变量及其对应的 UI 渲染逻辑，有效减少了代码冗余。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-11 05:46:44 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：1 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 1. **[Step6CoverSettings.tsx] 父组件传参检查** - 具体内容：代码移除了 `selectedTemplateName` 属性的解构和使用，请同步检查并移除父组件中传递该属性的代码，以避免 React 的 "unknown prop" 警告或 TypeScript 类型检查报错。 ### ✅ 良好实践 - 及时清理了未使用的 props 变量及其对应的 UI 渲染逻辑，有效减少了代码冗余。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-11 05:46:44 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-08-15 09:49:13 +08:00
xiaoxia commented 2026-08-15 09:49:14 +08:00
Author
Owner
Copy Link
Copy Source

develop 后续重构已包含此修复，此PR关闭。感谢贡献。

develop 后续重构已包含此修复，此PR关闭。感谢贡献。
gitea-actions bot commented 2026-08-15 09:50:10 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1340 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1340 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 30s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m34s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m46s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m55s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m25s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m32s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m3s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m48s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m52s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 12s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Waiting to run
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 57s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label bug frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1340
Delete Branch "fix/remove-selected-template-text"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?