xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(#1341): 修复 EditorDrawers totalDuration 重复定义 #1344

Closed
xiaoxia wants to merge 1 commits from fix/totalDuration-duplicate-develop into develop
pull from: fix/totalDuration-duplicate-develop
merge into: xiaoxia:develop
Conversation 4 Commits 1 Files Changed 2
-2
xiaoxia commented 2026-08-12 16:08:11 +08:00
Owner
Copy Link
Copy Source

问题

PR #1343 中，totalDuration 在 EditorDrawersProps interface 和 EditorDrawers 组件 props 传递中各被定义了两次：

  • interface: 第72行(pip区块) 和 第96行(封面区块) 重复定义
  • EditingPlanner.tsx: 第324行(pip区块) 和 第344行(封面区块) 重复传递

导致 TypeScript 编译错误。

修复

  1. EditorDrawers.tsx: 删除封面区块的 totalDuration: number（保留pip区块已有的）
  2. EditingPlanner.tsx: 删除封面区块的 totalDuration={totalDuration}（保留pip区块已有的）

验收

  • tsc --noEmit 零错误
  • prettier 检查通过
## 问题 PR #1343 中，totalDuration 在 EditorDrawersProps interface 和 EditorDrawers 组件 props 传递中各被定义了两次： - interface: 第72行(pip区块) 和 第96行(封面区块) 重复定义 - EditingPlanner.tsx: 第324行(pip区块) 和 第344行(封面区块) 重复传递 导致 TypeScript 编译错误。 ## 修复 1. **EditorDrawers.tsx**: 删除封面区块的 `totalDuration: number`（保留pip区块已有的） 2. **EditingPlanner.tsx**: 删除封面区块的 `totalDuration={totalDuration}`（保留pip区块已有的） ## 验收 - tsc --noEmit 零错误 - prettier 检查通过
xiaoxia added the bugfrontend labels 2026-08-12 16:08:11 +08:00
xiaoxia added 1 commit 2026-08-12 16:08:11 +08:00
fix(#1341): 修复 EditorDrawers totalDuration 重复定义
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 36s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 38s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 41s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m18s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m26s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m34s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m52s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m30s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m59s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m54s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 8m44s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 9s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 52s
Details
86afbb3eaf
auto-approve-bot commented 2026-08-12 16:09:30 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1344

⚠️ 问题（0个需要修改）

💡 建议（0个可选）

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-08-12 08:09:30 | 模型:

## 代码审查结果 - PR #1344 ### ⚠️ 问题（0个需要修改） ### 💡 建议（0个可选） --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-12 08:09:30 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-12 16:09:45 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1344
预览链接 https://pr-1344.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1344 | | 预览链接 | [https://pr-1344.preview.xiaoxiajianji.com](https://pr-1344.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-08-15 09:49:15 +08:00
xiaoxia commented 2026-08-15 09:49:15 +08:00
Author
Owner
Copy Link
Copy Source

#1371 重构后 EditorDrawers 已重写，不存在此问题，此PR关闭。感谢贡献。

#1371 重构后 EditorDrawers 已重写，不存在此问题，此PR关闭。感谢贡献。
gitea-actions bot commented 2026-08-15 09:50:06 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1344 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1344 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 36s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 38s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 41s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m18s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m26s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m34s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m52s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m30s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m59s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m54s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 8m44s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 9s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 52s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label bug frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1344
Delete Branch "fix/totalDuration-duplicate-develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?