xiaoxia/xiaoxia-saas

fix: ASR字幕路径叠加标题，修复封面没有标题的问题 #1374

Merged

xiaoxia merged 4 commits from fix/cover-title-asr-path into develop

2026-08-15 14:21:09 +08:00

Author	SHA1	Message	Date
CI Bot	25873c0b89	fix: 隔离_overlay_title_on_ass异常，防止ASR数据被覆盖 CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 40s Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m12s Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m20s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m22s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m40s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m10s Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m24s Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m23s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m28s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m1s Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Production (pull_request) Has been skipped Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped Details AI Code Review / AI Code Review (pull_request) Successful in 4m29s Details CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m27s Details CI/CD Pipeline / CI Gate (pull_request) Successful in 6s Details Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 30s Details ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 30s Details AI Review发现：_overlay_title_on_ass在ASR的try块内，如果叠加标题失败，会进入except分支覆盖已生成的ASR字幕数据。修复：用独立try-except包裹_overlay_title_on_ass调用，叠加失败时记录warning但保留ASR生成的ASS文件。新增测试：test_overlay_failure_preserves_asr_data 验证叠加失败时 ASR数据完整保留。	2026-08-15 14:14:49 +08:00
CI Bot	3d9e084a32	fix: ruff E741 - rename ambiguous variable 'l' to 'ln' in test_overlay_title_on_ass CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 45s Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m11s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m15s Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 28s Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m17s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m42s Details AI Code Review / AI Code Review (pull_request) Failing after 2m20s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m6s Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m9s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m29s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m9s Details CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Production (pull_request) Has been skipped Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped Details CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m40s Details CI/CD Pipeline / CI Gate (pull_request) Successful in 8s Details	2026-08-15 14:04:31 +08:00
CI Bot	486fa7b20d	style: auto-format with black + isort + prettier [skip ci-format-check] CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 31s Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m43s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m43s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m47s Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m49s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m53s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m49s Details CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Production (pull_request) Has been skipped Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m14s Details CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m58s Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m14s Details CI/CD Pipeline / CI Gate (pull_request) Failing after 6s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m3s Details AI Code Review / AI Code Review (pull_request) Failing after 6m30s Details	2026-08-15 05:53:33 +00:00
xiaoxia	17761124c2	fix: ASR字幕路径叠加标题，修复封面没有标题的问题 CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m20s Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m26s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m33s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m59s Details AI Code Review / AI Code Review (pull_request) Failing after 2m28s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m11s Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m49s Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m50s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m28s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m58s Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Production (pull_request) Has been skipped Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped Details CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m53s Details CI/CD Pipeline / CI Gate (pull_request) Failing after 7s Details 根因： 1. _maybe_generate_ass 的 ASR 路径直接 return，跳过了 generate_ass_subtitles() （负责标题叠加），导致 ASR 字幕生成的 ASS 文件中没有标题 2. generation.py 设置 auto_generated=True 但未设置 enabled=True，导致模板 subtitle.enabled=false 时 ASR 路径从未被触发修复： - unified_render_service.py: - ASR 路径生成 ASS 后，调用 _overlay_title_on_ass() 追加标题事件 - ASR 无结果/失败时，如有标题仍降级生成标题 ASS - 新增 _overlay_title_on_ass() 辅助函数：复用 build_ass_content 生成 TitleStyle + Dialogue，插入到 ASR 生成的 ASS 文件中 - generation.py: - voice_ids 注入时同步设置 subtitle_cfg['enabled'] = True 新增 6 个测试，全量 13651 passed	2026-08-15 13:49:16 +08:00