xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: E2E测试适配新步骤顺序-标题(4)→预览(5) #1383

Closed
xiaoxia wants to merge 1 commits from fix/e2e-step-order-adapt into develop
pull from: fix/e2e-step-order-adapt
merge into: xiaoxia:develop
Conversation 2 Commits 1 Files Changed 1
+9 -9
xiaoxia commented 2026-08-15 23:30:29 +08:00
Owner
Copy Link
Copy Source

问题

PR #1377 将步骤顺序从 预览(4)→标题(5) 调整为 标题(4)→预览(5)，但 E2E 测试仍按旧顺序定位步骤，导致 CI 失败：

core-generation.spec.ts:204: Error: locator.click: Error: strict mode violation

修改

  • apps/web/e2e/core-generation.spec.ts：交换 Step4（标题）和 Step5（预览）的内容，适配新步骤顺序
  • 其余步骤不变

验收

  • CI 通过（core-generation E2E 测试不再因步骤顺序报错）
## 问题 PR #1377 将步骤顺序从 预览(4)→标题(5) 调整为 标题(4)→预览(5)，但 E2E 测试仍按旧顺序定位步骤，导致 CI 失败： ``` core-generation.spec.ts:204: Error: locator.click: Error: strict mode violation ``` ## 修改 - `apps/web/e2e/core-generation.spec.ts`：交换 Step4（标题）和 Step5（预览）的内容，适配新步骤顺序 - 其余步骤不变 ## 验收 - CI 通过（core-generation E2E 测试不再因步骤顺序报错）
xiaoxia added the bugfrontend labels 2026-08-15 23:30:29 +08:00
xiaoxia added 1 commit 2026-08-15 23:30:29 +08:00
fix: E2E测试适配新步骤顺序-标题(4)→预览(5)
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 48s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m6s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m33s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m41s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m44s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m8s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m14s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m6s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m32s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m55s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 47s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 45s
Details
69fd60a3f9
auto-approve-bot commented 2026-08-15 23:34:01 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：1 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

  1. [apps/web/e2e/core-generation.spec.ts: 217] 避免使用硬编码等待
    • 具体内容：代码中使用了 await page.waitForTimeout(2000) 来等待组件完全渲染。硬编码的等待时间（sleep）会导致测试执行变慢，且在不同性能环境下稳定性较差（慢了可能不够，快了则浪费时间）。
    • 建议：替换为显式等待，例如使用 await expect(titleInput).toBeVisible() 或 toBeEditable()，以确保组件真正处于可交互状态后再进行操作。

✅ 良好实践

  • 注释更新及时，准确描述了业务逻辑的变更（"新顺序：标题在预览之前"），便于后续维护。
  • 针对耗时的后端渲染操作（预览生成）保留了合理的长超时设置（300_000ms），有效避免了因环境波动导致的非必要失败。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-15 15:34:01 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：1 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 1. **[apps/web/e2e/core-generation.spec.ts: 217] 避免使用硬编码等待** - 具体内容：代码中使用了 `await page.waitForTimeout(2000)` 来等待组件完全渲染。硬编码的等待时间（sleep）会导致测试执行变慢，且在不同性能环境下稳定性较差（慢了可能不够，快了则浪费时间）。 - 建议：替换为显式等待，例如使用 `await expect(titleInput).toBeVisible()` 或 `toBeEditable()`，以确保组件真正处于可交互状态后再进行操作。 ### ✅ 良好实践 - 注释更新及时，准确描述了业务逻辑的变更（"新顺序：标题在预览之前"），便于后续维护。 - 针对耗时的后端渲染操作（预览生成）保留了合理的长超时设置（300_000ms），有效避免了因环境波动导致的非必要失败。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-15 15:34:01 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-08-16 16:59:45 +08:00
gitea-actions bot commented 2026-08-16 17:00:31 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1383 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1383 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 48s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 1m6s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m33s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m41s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m44s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m8s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 1m14s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m6s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m4s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m32s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 6m55s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 47s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 45s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label bug frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1383
Delete Branch "fix/e2e-step-order-adapt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?