xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions 1 Packages Projects Releases 7 Wiki Activity

fix: 修复 test_title_font_size 断言适配 PR #1393 字号上限 #1397

Merged
auto-approve-bot merged 1 commits from fix/test-font-size-assertion into develop 2026-08-16 22:01:01 +08:00
Conversation 5 Commits 1 Files Changed 1
+1 -1
xiaoxia commented 2026-08-16 21:49:36 +08:00
Owner
Copy Link
Copy Source

问题

PR #1393 将标题字号上限从 48 统一为 36，但 tests/unit/domain/test_ass_subtitle_builder.py 中的 test_title_font_size 仍断言旧值 72。

修复

  • tests/unit/domain/test_ass_subtitle_builder.py 第 415 行：assert parts[2] == "72" → "36"

测试

  • 151 个 ass_subtitle_builder 相关测试全部通过
  • 无其他测试断言旧字号/描边值
## 问题 PR #1393 将标题字号上限从 48 统一为 36，但 `tests/unit/domain/test_ass_subtitle_builder.py` 中的 `test_title_font_size` 仍断言旧值 72。 ## 修复 - `tests/unit/domain/test_ass_subtitle_builder.py` 第 415 行：`assert parts[2] == "72"` → `"36"` ## 测试 - 151 个 ass_subtitle_builder 相关测试全部通过 - 无其他测试断言旧字号/描边值
xiaoxia added 1 commit 2026-08-16 21:49:36 +08:00
fix: update test_title_font_size assertion for PR #1393 font cap
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 24s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m26s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m33s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m44s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m52s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m55s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m0s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m5s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m7s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m36s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 5m12s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m37s
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 43s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m7s
Details
0c6bf35dd8 
PR #1393 capped title font size at 36, but the existing test in
tests/unit/domain/test_ass_subtitle_builder.py still asserted the
old uncapped value of 72. Updated to expect 36.
auto-approve-bot commented 2026-08-16 21:51:08 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

无

🤖 由 AI 代码审查机器人自动生成 | 2026-08-16 13:51:08 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 无 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-16 13:51:08 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-16 21:51:31 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1397
预览链接 https://pr-1397.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1397 | | 预览链接 | [https://pr-1397.preview.xiaoxiajianji.com](https://pr-1397.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-16 21:55:30 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-16 21:55:30 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit b8fbd5705d into develop 2026-08-16 22:01:01 +08:00
auto-approve-bot deleted branch fix/test-font-size-assertion 2026-08-16 22:01:01 +08:00
gitea-actions bot commented 2026-08-16 22:02:07 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1397 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1397 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1397
Delete Branch "fix/test-font-size-assertion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?