xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 3 Packages Projects Releases 7 Wiki Activity

fix: 修正PreviewVideoPanel显示条件,面板从Step4开始显示,标题预览仅在Step4 #1398

Merged
auto-approve-bot merged 1 commits from fix/preview-panel-step4-and-title-step4 into develop 2026-08-16 22:51:01 +08:00
Conversation 5 Commits 1 Files Changed 1
+3 -3
xiaoxia commented 2026-08-16 22:45:05 +08:00
Owner
Copy Link
Copy Source

修改内容

修正 PreviewVideoPanel 的两处显示条件（PR #1395 写反了）：

  1. 面板渲染条件：currentStep >= 5 → currentStep >= 4
    • 让预览视频面板从 Step4（选择标题）就开始显示
  2. 标题预览叠加：showTitlePreview={currentStep === 5} → showTitlePreview={currentStep === 4}
    • 标题 Canvas 叠加只在 Step4 显示，Step5（生成预览）只显示纯视频

效果

  • Step4（选择标题）：预览视频面板 + 标题预览叠加 ✅
  • Step5（生成预览）：预览视频面板（无标题叠加）✅

修改文件

  • apps/web/src/pages/generate/GeneratePage.tsx：3 行修改

验证

  • ✅ TypeScript 编译通过
  • ✅ Prettier 格式化通过
## 修改内容 修正 PreviewVideoPanel 的两处显示条件（PR #1395 写反了）： 1. 面板渲染条件：`currentStep >= 5` → `currentStep >= 4` - 让预览视频面板从 Step4（选择标题）就开始显示 2. 标题预览叠加：`showTitlePreview={currentStep === 5}` → `showTitlePreview={currentStep === 4}` - 标题 Canvas 叠加只在 Step4 显示，Step5（生成预览）只显示纯视频 ## 效果 - **Step4（选择标题）**：预览视频面板 + 标题预览叠加 ✅ - **Step5（生成预览）**：预览视频面板（无标题叠加）✅ ## 修改文件 - `apps/web/src/pages/generate/GeneratePage.tsx`：3 行修改 ## 验证 - ✅ TypeScript 编译通过 - ✅ Prettier 格式化通过
xiaoxia added the bugfrontend labels 2026-08-16 22:45:05 +08:00
xiaoxia added 1 commit 2026-08-16 22:45:05 +08:00
fix: 修正PreviewVideoPanel显示条件,面板从Step4开始显示,标题预览仅在Step4
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 42s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m48s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m48s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m11s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m8s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m12s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m31s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m5s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m59s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m29s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m31s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 6s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 53s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 1m28s
Details
b6dad0b43f
auto-approve-bot commented 2026-08-16 22:47:11 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1398

⚠️ 问题（1个需要修改）

  1. GeneratePage.tsx 第255行：数据源与渲染条件不匹配。代码将组件渲染逻辑提前到了 Step 4 (currentStep >= 4)，但传入的数据源依然是 step5Preview。变量命名强烈暗示该数据与 Step 5 强绑定。如果在 Step 4 阶段 step5Preview 对象尚未初始化或其内部数据（如 previewResult）为空，将导致 PreviewVideoPanel 组件崩溃或显示异常状态。需确认 Step 4 时数据是否已就绪，或同步调整数据获取逻辑。

💡 建议（2个可选）

  1. 变量命名语义化：如果预览功能确实已调整为从 Step 4 开始，建议将 step5Preview 重命名为更具通用性的名称（如 previewData 或 videoPreview），以避免与特定步骤号强绑定，造成后续维护困惑。
  2. 性能关注：将视频预览面板的渲染从 Step 5 提前至 Step 4，意味着用户在进入 Step 4 时就会加载该组件。如果 PreviewVideoPanel 包含较重的视频解码或网络请求，可能会影响 Step 4 页面的加载速度和交互流畅度，建议评估性能影响。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-08-16 14:47:11 | 模型:

## 代码审查结果 - PR #1398 ### ⚠️ 问题（1个需要修改） 1. **GeneratePage.tsx 第255行**：数据源与渲染条件不匹配。代码将组件渲染逻辑提前到了 Step 4 (`currentStep >= 4`)，但传入的数据源依然是 `step5Preview`。变量命名强烈暗示该数据与 Step 5 强绑定。如果在 Step 4 阶段 `step5Preview` 对象尚未初始化或其内部数据（如 `previewResult`）为空，将导致 `PreviewVideoPanel` 组件崩溃或显示异常状态。需确认 Step 4 时数据是否已就绪，或同步调整数据获取逻辑。 ### 💡 建议（2个可选） 1. **变量命名语义化**：如果预览功能确实已调整为从 Step 4 开始，建议将 `step5Preview` 重命名为更具通用性的名称（如 `previewData` 或 `videoPreview`），以避免与特定步骤号强绑定，造成后续维护困惑。 2. **性能关注**：将视频预览面板的渲染从 Step 5 提前至 Step 4，意味着用户在进入 Step 4 时就会加载该组件。如果 `PreviewVideoPanel` 包含较重的视频解码或网络请求，可能会影响 Step 4 页面的加载速度和交互流畅度，建议评估性能影响。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-16 14:47:11 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-08-16 22:47:33 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1398
预览链接 https://pr-1398.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1398 | | 预览链接 | [https://pr-1398.preview.xiaoxiajianji.com](https://pr-1398.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-16 22:48:05 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-16 22:48:05 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit b88683fcff into develop 2026-08-16 22:51:01 +08:00
auto-approve-bot deleted branch fix/preview-panel-step4-and-title-step4 2026-08-16 22:51:01 +08:00
gitea-actions bot commented 2026-08-16 22:51:54 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1398 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1398 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label bug frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1398
Delete Branch "fix/preview-panel-step4-and-title-step4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?